Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFG_LIBDIR specified by target triples in platform.mk #5577

Closed
wants to merge 1 commit into from
Closed

CFG_LIBDIR specified by target triples in platform.mk #5577

wants to merge 1 commit into from

Conversation

yichoi
Copy link
Contributor

@yichoi yichoi commented Mar 27, 2013

mk

  • CFG_LIBDIR changed to specify with target triples like CFG_LIB_DIR_$(target), following other naming convention like CFG_SRC_DIR, CFG_LIB_NAME_$(target)

configure :

  • rename ambiguous CFG_LIBDIR to CFG_DEFAULT_LIB_DIR, which is used filesearch.rs.
  • CFG_DEFAULT_LIB_DIR is associated with CFG_LIB_DIR_$(target) in platform.mk

@yichoi yichoi closed this Mar 31, 2013
@yichoi
Copy link
Contributor Author

yichoi commented Mar 31, 2013

discuss later when needed

@yichoi
Copy link
Contributor Author

yichoi commented Mar 31, 2013

referenced from #5223

This was referenced May 7, 2013
Closed
Merged
bors added a commit that referenced this pull request May 7, 2013
@bors
auto merge of #6295 : yichoi/rust/pull-mingw32, r=brson
3a34e93 
fix for #6279 #6253

mk: rt.mk regression patch for mingw32 after #6176

currently do not pass optimization option just make it works only

mk: target.mk host.mk fix for duplicated rules of mingw32 after #6235

It can be simply fixed with CFG_LIB check whether bin or lib however considering multiple target triples with linux and windows, CFG_LIB needs to configurable #5223 and #5577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yichoi