New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial addition of the Embedded Rust Book #56291

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@jamesmunns
Member

jamesmunns commented Nov 27, 2018

This PR adds the Embedded Rust Book to the bookshelf as a submodule, and adds text for the bookshelf page. I have added a new section after "Master Rust" called "Specialize Rust", with the plan that future domain WG books can also reside here. This now extends the titles down to H3, where formerly only H1 and H2 were used.

The added submodule tracks the master branch of the Embedded WG repo.

If there are additional steps necessary to make this work in CI (perhaps adding this to src/ci/docker/x86_64-gnu-tools/checktools.sh:32 or so?), please let me know.

CC @steveklabnik @japaric

Also CC issue rust-embedded/wg#257

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Nov 27, 2018

r? @GuillaumeGomez

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Nov 27, 2018

⚠️ Warning ⚠️

  • These commits modify submodules.
@rust-highfive

This comment was marked as outdated.

Collaborator

rust-highfive commented Nov 27, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:159d8f90:start=1543343823544017395,finish=1543343825315236869,duration=1771219474
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:00:00] Cleared directory 'src/tools/rls'
[00:00:00] Cleared directory 'src/tools/rust-installer'
[00:00:00] Cleared directory 'src/tools/rustfmt'
[00:00:00] Submodule 'src/dlmalloc' (https://github.com/alexcrichton/dlmalloc-rs.git) registered for path 'src/dlmalloc'
[00:00:00] Submodule 'src/doc/embedded-book' (https://github.com/rust-embedded/book.git) registered for path 'src/doc/embedded-book'
[00:00:00] Submodule 'src/doc/reference' (https://github.com/rust-lang-nursery/reference.git) registered for path 'src/doc/reference'
[00:00:00] Submodule 'src/libbacktrace' (https://github.com/rust-lang-nursery/libbacktrace.git) registered for path 'src/libbacktrace'
[00:00:00] Submodule 'src/libcompiler_builtins' (https://github.com/rust-lang-nursery/compiler-builtins.git) registered for path 'src/libcompiler_builtins'
[00:00:00] Submodule 'src/liblibc' (https://github.com/rust-lang/libc.git) registered for path 'src/liblibc'
---

[00:02:57] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:02:57] tidy error: /checkout/src/doc/embedded-book/ci/install.sh:4: line longer than 100 chars
[00:02:59] some tidy checks failed
[00:02:59] 
[00:02:59] 
[00:02:59] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:02:59] 
[00:02:59] 
[00:02:59] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:02:59] Build completed unsuccessfully in 0:00:55
[00:02:59] Build completed unsuccessfully in 0:00:55
[00:02:59] Makefile:79: recipe for target 'tidy' failed
[00:02:59] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:011c118c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Nov 27 18:40:13 UTC 2018
---
travis_time:end:122f4312:start=1543344013496758017,finish=1543344013502017681,duration=5259664
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00ee2938
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:01b3f5d0
travis_time:start:01b3f5d0
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0a578208
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@jamesmunns

This comment has been minimized.

Member

jamesmunns commented Nov 27, 2018

One of our CI scripts was exactly one line column too long. Moving to a WIP branch to resolve any issues. Please do not merge until I have moved the submodule back to tracking "master".

@steveklabnik

This comment has been minimized.

Member

steveklabnik commented Nov 27, 2018

This looks great!

If there are additional steps necessary to make this work in CI (perhaps adding this to src/ci/docker/x86_64-gnu-tools/checktools.sh:32 or so?), please let me know.

Yes, you'll need to modify rustbuild as well. It should be as easy as adding a line in here https://github.com/rust-lang/rust/blob/master/src/bootstrap/doc.rs#L70-L76

@rust-highfive

This comment was marked as outdated.

Collaborator

rust-highfive commented Nov 27, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:1480349b:start=1543344821282012911,finish=1543344822353429122,duration=1071416211
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:00:00] Cleared directory 'src/tools/rls'
[00:00:00] Cleared directory 'src/tools/rust-installer'
[00:00:00] Cleared directory 'src/tools/rustfmt'
[00:00:00] Submodule 'src/dlmalloc' (https://github.com/alexcrichton/dlmalloc-rs.git) registered for path 'src/dlmalloc'
[00:00:00] Submodule 'src/doc/embedded-book' (https://github.com/rust-embedded/book.git) registered for path 'src/doc/embedded-book'
[00:00:00] Submodule 'src/doc/reference' (https://github.com/rust-lang-nursery/reference.git) registered for path 'src/doc/reference'
[00:00:00] Submodule 'src/libbacktrace' (https://github.com/rust-lang-nursery/libbacktrace.git) registered for path 'src/libbacktrace'
[00:00:00] Submodule 'src/libcompiler_builtins' (https://github.com/rust-lang-nursery/compiler-builtins.git) registered for path 'src/libcompiler_builtins'
[00:00:00] Submodule 'src/liblibc' (https://github.com/rust-lang/libc.git) registered for path 'src/liblibc'
---
[00:50:01] .................................................................................................... 100/5064
[00:50:04] .................................................................................................... 200/5064
[00:50:07] .............................ii............................................ii...................ii.. 300/5064
[00:50:09] ..............................................................................................iii... 400/5064
[00:50:12] .....iiiiiiii.iii............................iii...........................................i........ 500/5064
[00:50:19] .................................................................................................... 700/5064
[00:50:24] ................................................................................................i... 800/5064
[00:50:28] ........i........................................................................................... 900/5064
[00:50:31] ...............iiiii..................ii.iiii....................................................... 1000/5064
---
[00:51:10] .................................................................................................... 2300/5064
[00:51:14] .................................................................................................... 2400/5064
[00:51:18] .................................................................................................... 2500/5064
[00:51:21] .................................................................................................... 2600/5064
[00:51:25] .......iiiiiiiii.................................................................................... 2700/5064
[00:51:31] .................................................................................................... 2900/5064
[00:51:34] .................................................................................................... 3000/5064
[00:51:38] ......................................................................i............................. 3100/5064
[00:51:41] .................................................................................................... 3200/5064
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:05:22] 
[01:05:22] running 117 tests
[01:05:25] i..ii...iii..iiii.....i...i.........i..iii...........i.....i.....ii...i..i.ii..............i...ii..i 100/117
[01:05:25] i.i.....iiii.....
[01:05:25] 
[01:05:25]  finished in 3.424
[01:05:25] travis_fold:end:test_codegen

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:05:39] 
[01:05:39] running 118 tests
[01:06:03] .iiiii...i.....i..i...i..i.i..i.i..i.....i..i....i..........iiii.........i.i....i...i.......ii.i.i.i 100/118
[01:06:07] ......iii.i.....ii
[01:06:07] 
[01:06:07]  finished in 27.857
[01:06:07] travis_fold:end:test_debuginfo

---
[01:34:15] travis_fold:end:stage0-linkchecker

[01:34:15] travis_time:end:stage0-linkchecker:start=1543350484457610554,finish=1543350486851739619,duration=2394129065

[01:34:15] index.html:103: broken link - embedded-book/index.html
none            4.0K     0  4.0K   0% /sys/fs/cgroup
none            5.0M     0  5.0M   0% /run/lock
none            7.4G     0  7.4G   0% /run/shm
none            100M     0  100M   0% /run/user
none            100M     0  100M   0% /run/user
none            768M     0  768M   0% /var/ramfs
60 ./obj/build/bootstrap/debug/incremental/bootstrap-1plb86h2refwc
134656 ./obj/build/bootstrap/debug/incremental/bootstrap-1plb86h2refwc/s-f72ivlhz8s-d8n60a-18zp7vy2v2s65
129168 ./.git/modules/src
123696 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps
115736 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/release
115352 ./src/llvm/test/CodeGen
---
36560 ./.git/modules/src/libcompiler_builtins/modules
36044 ./.git/modules/src/libcompiler_builtins/modules/compiler-rt
35640 ./src/tools/clang/lib
35580 ./.git/modules/src/libcompiler_builtins/modules/compiler-rt/objects
35572 ./.git/modules/src/libcompiler_builtins/modules/compileores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Nov 27, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:10909bdb:start=1543351689175491871,finish=1543351691414729242,duration=2239237371
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:00:00] Cleared directory 'src/tools/rls'
[00:00:00] Cleared directory 'src/tools/rust-installer'
[00:00:00] Cleared directory 'src/tools/rustfmt'
[00:00:00] Submodule 'src/dlmalloc' (https://github.com/alexcrichton/dlmalloc-rs.git) registered for path 'src/dlmalloc'
[00:00:00] Submodule 'src/doc/embedded-book' (https://github.com/rust-embedded/book.git) registered for path 'src/doc/embedded-book'
[00:00:00] Submodule 'src/doc/reference' (https://github.com/rust-lang-nursery/reference.git) registered for path 'src/doc/reference'
[00:00:00] Submodule 'src/libbacktrace' (https://github.com/rust-lang-nursery/libbacktrace.git) registered for path 'src/libbacktrace'
[00:00:00] Submodule 'src/libcompiler_builtins' (https://github.com/rust-lang-nursery/compiler-builtins.git) registered for path 'src/libcompiler_builtins'
[00:00:00] Submodule 'src/liblibc' (https://github.com/rust-lang/libc.git) registered for path 'src/liblibc'
---
[00:50:14] .................................................................................................... 100/5064
[00:50:17] .................................................................................................... 200/5064
[00:50:20] .............................ii............................................ii...................ii.. 300/5064
[00:50:22] ..............................................................................................iii... 400/5064
[00:50:25] .....iiiiiiii.iii............................iii...........................................i........ 500/5064
[00:50:32] .................................................................................................... 700/5064
[00:50:37] ................................................................................................i... 800/5064
[00:50:41] ........i........................................................................................... 900/5064
[00:50:44] ...............iiiii..................ii.iiii....................................................... 1000/5064
---
[00:51:23] .................................................................................................... 2300/5064
[00:51:27] .................................................................................................... 2400/5064
[00:51:30] .................................................................................................... 2500/5064
[00:51:34] .................................................................................................... 2600/5064
[00:51:37] .......iiiiiiiii.................................................................................... 2700/5064
[00:51:43] .................................................................................................... 2900/5064
[00:51:47] .................................................................................................... 3000/5064
[00:51:50] ......................................................................i............................. 3100/5064
[00:51:53] .................................................................................................... 3200/5064
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:05:37] 
[01:05:37] running 117 tests
[01:05:40] i..ii...iii..iiii.....i...i.........i..iii...........i.....i.....ii...i..i.ii..............i...ii..i 100/117
[01:05:40] i.i.....iiii.....
[01:05:40] 
[01:05:40]  finished in 3.394
[01:05:40] travis_fold:end:test_codegen

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:05:55] 
[01:05:55] running 118 tests
[01:06:19] .iiiii...i.....i..i...i..i.i..i.i..i.....i..i....i..........iiii.........i.i....i...i.......ii.i.i.i 100/118
[01:06:23] ......iii.i.....ii
[01:06:23] 
[01:06:23]  finished in 28.999
[01:06:23] travis_fold:end:test_debuginfo

---
[01:35:27] travis_fold:end:stage0-linkchecker

[01:35:27] travis_time:end:stage0-linkchecker:start=1543357425135618272,finish=1543357427553407992,duration=2417789720

[01:35:28] index.html:103: broken link - embedded-book/index.html
[01:39:20] thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:49:9
[01:39:20] 
[01:39:20] 
[01:39:20] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:39:20] expected success, got: exit code: 101
[01:39:20] expected success, got: exit code: 101
[01:39:20] 
[01:39:20] 
[01:39:20] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:39:20] Build completed unsuccessfully in 0:53:05
[01:39:20] make: *** [check] Error 1
[01:39:20] Makefile:58: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0d86b6fb
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Nov 27 22:27:40 UTC 2018
---
travis_time:end:003937d8:start=1543357666017388027,finish=1543357666227483637,duration=210095610
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0c69a2b0
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0118cc5e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@jamesmunns

This comment has been minimized.

Member

jamesmunns commented Nov 28, 2018

I know (EDIT: thought I knew) what is going wrong here, mainly that the embedded book doesn't have an explicit top level index.html that is generated. I will need to look in to the best way to implement this, likely as either:

  • A redirect to our actual landing page intro/index.html
  • Moving our actual landing page to index.md, so it is rendered in the correct location

I hope to address this in the next day or so in my working branch.

@steveklabnik

This comment has been minimized.

Member

steveklabnik commented Nov 28, 2018

I thought that mdbook always put the first page of the book as index.html; maybe I'm wrong...

@jamesmunns

This comment has been minimized.

Member

jamesmunns commented Nov 28, 2018

Hmm, you seem to be right @steveklabnik:

➜  embedded-book git:(master) rm -rf ./book
➜  embedded-book git:(master) mdbook build
2018-11-28 15:30:59 [INFO] (mdbook::book): Book building has started
2018-11-28 15:30:59 [INFO] (mdbook::book): Running the html backend
➜  embedded-book git:(master) ls -hal ./book/index.html
-rw-r--r-- 1 james james 19K Nov 28 15:30 ./book/index.html

I guess this means I have some investigating to do, support would be appreciated, otherwise I'll look once I have a chance.

@steveklabnik

This comment has been minimized.

Member

steveklabnik commented Nov 28, 2018

I cannot get this to build due to a really strange error

running: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\VC\\Tools\\MSVC\\14.15.26726\\bin\\HostX64\\x64\\cl.exe" "/nologo" "/MT"
"/O2" "/Zl" "/D__func__=__FUNCTION__" "/FoC:\\Users\\steve\\src\\rust\\build\\x86_64-pc-windows-msvc\\stage0-std\\x86_64-pc-windows-msvc\\release\\bui
ld\\compiler_builtins-5994e1b3add468a9\\out\\../../libcompiler_builtins\\compiler-rt/lib/builtins\\absvdi2.o" "/c" "../../libcompiler_builtins\\compil
er-rt/lib/builtins\\absvdi2.c"
absvdi2.c
c1: fatal error C1083: Cannot open source file: '../../libcompiler_builtins\compiler-rt/lib/builtins\absvdi2.c': No such file or directory
exit code: 2

that file does not exist, so I'm not sure why it's looking for it.

@bors

This comment has been minimized.

Contributor

bors commented Nov 29, 2018

☔️ The latest upstream changes (presumably #56340) made this pull request unmergeable. Please resolve the merge conflicts.

@jamesmunns jamesmunns referenced this pull request Nov 29, 2018

Open

Embedded Page tracking issue #230

0 of 7 tasks complete

@steveklabnik steveklabnik referenced this pull request Nov 30, 2018

Merged

Update books #56373

@steveklabnik

Sooooooooooooo @jamesmunns , I forgot a crucial step:

diff --git a/src/bootstrap/builder.rs b/src/bootstrap/builder.rs
index 079fdee7e8..97d3ecba04 100644
--- a/src/bootstrap/builder.rs
+++ b/src/bootstrap/builder.rs
@@ -442,7 +442,8 @@ impl<'a> Builder<'a> {
                 doc::RustdocBook,
                 doc::RustByExample,
                 doc::RustcBook,
-                doc::CargoBook
+                doc::CargoBook,
+                doc::EmbeddedBook
             ),
             Kind::Dist => describe!(
                 dist::Docs,

the changes you have define the build, but don't actually do the building.

after that, we get this report:

embedded-book\intro\install\linux.html:237: broken link - embedded-book\verify.md
embedded-book\intro\install\macos.html:147: broken link - embedded-book\verify.md
embedded-book\intro\install\verify.html:170: broken link - hardware.md
embedded-book\intro\install\verify.html:177: broken link - hardware.md
embedded-book\intro\install\verify.html:180: broken link - embedded-book\linux.md
embedded-book\intro\install\windows.html:161: broken link - embedded-book\verify.md
embedded-book\intro\install.html:160: broken link - embedded-book\install\linux.md
embedded-book\intro\install.html:161: broken link - embedded-book\install\windows.md
embedded-book\intro\install.html:162: broken link - embedded-book\install\macos.md
embedded-book\print.html:374: broken link - embedded-book\install\linux.md
embedded-book\print.html:375: broken link - embedded-book\install\windows.md
embedded-book\print.html:376: broken link - embedded-book\install\macos.md
embedded-book\print.html:479: broken link - embedded-book\verify.md
embedded-book\print.html:491: broken link - embedded-book\verify.md
embedded-book\print.html:517: broken link - embedded-book\verify.md
embedded-book\print.html:552: broken link - hardware.md
embedded-book\print.html:559: broken link - hardware.md
embedded-book\print.html:562: broken link - embedded-book\linux.md
embedded-book\print.html:628: broken link - embedded-book\hardware.md
embedded-book\print.html:1107: broken link - embedded-book\qemu.md
embedded-book\print.html:1151: broken link - intro\install\verify.md
embedded-book\print.html:1173: broken link - intro\install\verify.md
embedded-book\print.html:1329: broken link - portability\index.md
embedded-book\print.html:1352: broken link - peripherals\index.md
embedded-book\start\hardware.html:177: broken link - embedded-book\qemu.md
embedded-book\start\hardware.html:221: broken link - intro\install\verify.md
embedded-book\start\hardware.html:243: broken link - intro\install\verify.md
embedded-book\start\index.html:146: broken link - embedded-book\hardware.md
embedded-book\start\registers.html:142: broken link - portability\index.md
embedded-book\start\registers.html:165: broken link - peripherals\index.md

all of the print ones are duplicates of the regular pages, so this list is only half as long.

make sense?

@jamesmunns

This comment has been minimized.

Member

jamesmunns commented Nov 30, 2018

I'll take a look tomorrow, I've got some time on the train. I'll see what I can get together :)

@Dylan-DPC

This comment has been minimized.

Member

Dylan-DPC commented Dec 10, 2018

ping from triage @jamesmunns you need to update this with the changes requested.

@jamesmunns

This comment has been minimized.

Member

jamesmunns commented Dec 10, 2018

Thanks @Dylan-DPC, I still intend to finish this as soon as I can.

@jamesmunns jamesmunns force-pushed the jamesmunns:upstream-embedded-book branch from caa785d to a28006c Dec 10, 2018

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Dec 10, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:03ce1320:start=1544468232109732892,finish=1544468233350606338,duration=1240873446
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:00:00] Attempting with retry: sh -c rm -f download-src-tools-lld.tar.gz &&         curl -sSL -o download-src-tools-lld.tar.gz https://github.com/rust-lang/lld/archive/1928c5eeb613a4c6d232fc47ae91914bbfd92a79.tar.gz
[00:00:00] rm 'src/tools/lldb'
[00:00:00] Attempting with retry: sh -c rm -f download-src-tools-lldb.tar.gz &&         curl -sSL -o download-src-tools-lldb.tar.gz https://github.com/rust-lang-nursery/lldb/archive/8ad0817ce45b0eef9d374691b23f2bd69c164254.tar.gz
[00:00:00] rm 'src/tools/clang'
[00:00:00] Attempting with retry: sh -c git submodule deinit -f  src/tools/rust-installer src/liblibc src/doc/nomicon src/tools/cargo src/doc/reference src/tools/rls src/libcompiler_builtins src/tools/clippy src/tools/rustfmt src/tools/miri src/dlmalloc src/stdsimd src/libbacktrace src/doc/rustc-guide src/doc/edition-guide src/rust-sgx src/doc/embedded-book &&     git submodule sync &&     git submodule update -j 16 --init --recursive  src/tools/rust-installer src/liblibc src/doc/nomicon src/tools/cargo src/doc/reference src/tools/rls src/libcompiler_builtins src/tools/clippy src/tools/rustfmt src/tools/miri src/dlmalloc src/stdsimd src/libbacktrace src/doc/rustc-guide src/doc/edition-guide src/rust-sgx src/doc/embedded-book
[00:00:00] Cleared directory 'src/dlmalloc'
[00:00:00] Cleared directory 'src/doc/edition-guide'
[00:00:00] Cleared directory 'src/doc/embedded-book'
[00:00:00] Cleared directory 'src/doc/nomicon'
---
[00:00:00] Cleared directory 'src/tools/rust-installer'
[00:00:00] Cleared directory 'src/tools/rustfmt'
[00:00:00] Submodule 'src/dlmalloc' (https://github.com/alexcrichton/dlmalloc-rs.git) registered for path 'src/dlmalloc'
[00:00:00] Submodule 'src/doc/edition-guide' (https://github.com/rust-lang-nursery/edition-guide) registered for path 'src/doc/edition-guide'
[00:00:00] Submodule 'src/doc/embedded-book' (https://github.com/rust-embedded/book.git) registered for path 'src/doc/embedded-book'
[00:00:00] Submodule 'src/doc/reference' (https://github.com/rust-lang-nursery/reference.git) registered for path 'src/doc/reference'
[00:00:00] Submodule 'src/doc/rustc-guide' (https://github.com/rust-lang/rustc-guide.git) registered for path 'src/doc/rustc-guide'
[00:00:00] Submodule 'src/libbacktrace' (https://github.com/rust-lang-nursery/libbacktrace.git) registered for path 'src/libbacktrace'
[00:00:00] Submodule 'src/libcompiler_builtins' (https://github.com/rust-lang-nursery/compiler-builtins.git) registered for path 'src/libcompiler_builtins'
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:55:35] 
[00:55:35] running 120 tests
[00:55:38] i..ii...iii..iiii.....i...i..........i..iii.............i.....i.....ii...i..i.ii..............i...ii 100/120
[00:55:38] ..ii.i.....iiii.....
[00:55:38] 
[00:55:38]  finished in 3.450
[00:55:38] travis_fold:end:test_codegen

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:55:53] 
[00:55:53] running 118 tests
[00:56:16] .iiiii...i.....i..i...i..i.i..i.i..i.....i..i....i..........iiii.........i.i....i...i.......ii.i.i.i 100/118
[00:56:20] ......iii.i.....ii
[00:56:20] 
[00:56:20]  finished in 27.178
[00:56:20] travis_fold:end:test_debuginfo

---
[01:21:06] travis_fold:end:stage0-linkchecker

[01:21:06] travis_time:end:stage0-linkchecker:start=1544473105736719694,finish=1544473108036872422,duration=2300152728

[01:21:06] index.html:106: broken link - embedded-book/index.html
[01:21:12] thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:49:9
[01:21:12] 
[01:21:12] 
[01:21:12] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:21:12] expected success, got: exit code: 101
[01:21:12] expected success, got: exit code: 101
[01:21:12] 
[01:21:12] 
[01:21:12] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:21:12] Build completed unsuccessfully in 0:36:08
[01:21:12] make: *** [check] Error 1
[01:21:12] Makefile:58: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0d52d498
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon Dec 10 20:18:34 UTC 2018
---
travis_time:end:25ccfe1e:start=1544473116457021205,finish=1544473116547228790,duration=90207585
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:087ce538
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:047a9a46
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@jamesmunns

This comment has been minimized.

Member

jamesmunns commented Dec 10, 2018

@steveklabnik I think I know what the issue is, the main rust repo uses an older version of mdbook than the embedded wg (0.1.7 vs 0.2.2). We rely on using links to relative md files within the pre-rendered markdown, and newer versions of mdbook automatically render this to .html links.

In this change, I update the dependency to 0.2.2. After updating, x.py dist still seems to complete successfully.

Let's see how the CI goes.

@steveklabnik

This comment has been minimized.

Member

steveklabnik commented Dec 10, 2018

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Dec 10, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:00e77a37:start=1544474800582637503,finish=1544474802829172747,duration=2246535244
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:00:00] rm 'src/tools/lldb'
[00:00:00] Attempting with retry: sh -c rm -f download-src-tools-lldb.tar.gz &&         curl -sSL -o download-src-tools-lldb.tar.gz https://github.com/rust-lang-nursery/lldb/archive/8ad0817ce45b0eef9d374691b23f2bd69c164254.tar.gz
[00:00:00] rm 'src/tools/clang'
[00:00:00] Attempting with retry: sh -c rm -f download-src-tools-clang.tar.gz &&         curl -sSL -o download-src-tools-clang.tar.gz https://github.com/rust-lang-nursery/clang/archive/032312dd0140a7074c9b89d305fe44eb0e44e407.tar.gz
[00:00:00] Attempting with retry: sh -c git submodule deinit -f  src/tools/rust-installer src/liblibc src/doc/nomicon src/tools/cargo src/doc/reference src/tools/rls src/libcompiler_builtins src/tools/clippy src/tools/rustfmt src/tools/miri src/dlmalloc src/stdsimd src/libbacktrace src/doc/rustc-guide src/doc/edition-guide src/rust-sgx src/doc/embedded-book &&     git submodule sync &&     git submodule update -j 16 --init --recursive  src/tools/rust-installer src/liblibc src/doc/nomicon src/tools/cargo src/doc/reference src/tools/rls src/libcompiler_builtins src/tools/clippy src/tools/rustfmt src/tools/miri src/dlmalloc src/stdsimd src/libbacktrace src/doc/rustc-guide src/doc/edition-guide src/rust-sgx src/doc/embedded-book
[00:00:00] Cleared directory 'src/doc/edition-guide'
[00:00:00] Cleared directory 'src/doc/embedded-book'
[00:00:00] Cleared directory 'src/doc/nomicon'
[00:00:00] Cleared directory 'src/doc/reference'
---
[00:00:00] Cleared directory 'src/tools/rust-installer'
[00:00:00] Cleared directory 'src/tools/rustfmt'
[00:00:00] Submodule 'src/dlmalloc' (https://github.com/alexcrichton/dlmalloc-rs.git) registered for path 'src/dlmalloc'
[00:00:00] Submodule 'src/doc/edition-guide' (https://github.com/rust-lang-nursery/edition-guide) registered for path 'src/doc/edition-guide'
[00:00:00] Submodule 'src/doc/embedded-book' (https://github.com/rust-embedded/book.git) registered for path 'src/doc/embedded-book'
[00:00:00] Submodule 'src/doc/reference' (https://github.com/rust-lang-nursery/reference.git) registered for path 'src/doc/reference'
[00:00:00] Submodule 'src/doc/rustc-guide' (https://github.com/rust-lang/rustc-guide.git) registered for path 'src/doc/rustc-guide'
[00:00:00] Submodule 'src/libbacktrace' (https://github.com/rust-lang-nursery/libbacktrace.git) registered for path 'src/libbacktrace'
[00:00:00] Submodule 'src/libcompiler_builtins' (https://github.com/rust-lang-nursery/compiler-builtins.git) registered for path 'src/libcompiler_builtins'
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:54:07] 
[00:54:07] running 120 tests
[00:54:10] i..ii...iii..iiii.....i...i..........i..iii.............i.....i.....ii...i..i.ii..............i...ii 100/120
[00:54:10] ..ii.i.....iiii.....
[00:54:10] 
[00:54:10]  finished in 3.231
[00:54:10] travis_fold:end:test_codegen

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:54:24] 
[00:54:24] running 118 tests
[00:54:47] .iiiii...i.....i..i...i..i.i..i.i..i.....i..i....i..........iiii.........i.i....i...i.......ii.i.i.i 100/118
[00:54:51] ......iii.i.....ii
[00:54:51] 
[00:54:51]  finished in 26.904
[00:54:51] travis_fold:end:test_debuginfo

---
[01:20:02] travis_fold:end:stage0-linkchecker

[01:20:02] travis_time:end:stage0-linkchecker:start=1544479613327137280,finish=1544479615444019918,duration=2116882638

[01:20:02] cargo/appendix/glossary.html:150: broken link - cargo/appendix/reference/manifest.html
[01:20:02] cargo/appendix/glossary.html:154: broken link - cargo/appendix/reference/manifest.html
[01:20:02] cargo/appendix/glossary.html:167: broken link - cargo/appendix/guide/cargo-toml-vs-cargo-lock.html
[01:20:02] cargo/appendix/glossary.html:169: broken link - cargo/appendix/reference/manifest.html
[01:20:02] cargo/appendix/glossary.html:171: broken link - cargo/appendix/reference/manifest.html
[01:20:02] cargo/appendix/glossary.html:182: broken link - cargo/appendix/reference/pkgid-spec.html
[01:20:02] cargo/appendix/glossary.html:198: broken link - cargo/appendix/reference/source-replacement.html
[01:20:02] cargo/appendix/glossary.html:200: broken link - cargo/appendix/reference/source-replacement.html
[01:20:02] cargo/appendix/glossary.html:202: broken link - cargo/appendix/reference/specifying-dependencies.html
[01:20:02] cargo/appendix/glossary.html:202: broken link - cargo/appendix/reference/specifying-dependencies.html
[01:20:02] cargo/appendix/glossary.html:203: broken link - cargo/appendix/reference/specifying-dependencies.html
[01:20:02] cargo/appendix/glossary.html:204: broken link - cargo/appendix/reference/source-replacement.html
[01:20:02] cargo/appendix/glossary.html:206: broken link - cargo/appendix/reference/source-replacement.html
[01:20:02] cargo/appendix/glossary.html:214: broken link - cargo/appendix/reference/manifest.html
[01:20:02] cargo/appendix/glossary.html:215: broken link - cargo/appendix/reference/manifest.html
[01:20:02] cargo/appendix/glossary.html:224: broken link - cargo/appendix/reference/config.html
[01:20:02] cargo/appendix/glossary.html:229: broken link - cargo/appendix/reference/environment-variables.html
[01:20:02] cargo/appendix/glossary.html:230: broken link - cargo/appendix/reference/config.html
[01:20:02] cargo/appendix/glossary.html:240: broken link - cargo/appendix/reference/manifest.html
[01:20:02] cargo/appendix/glossary.html:243: broken link - cargo/appendix/reference/manifest.html
[01:20:02] cargo/appendix/glossary.html:248: broken link - cargo/appendix/reference/manifest.html
[01:20:02] cargo/appendix/glossary.html:251: broken link - cargo/appendix/reference/manifest.html
[01:20:02] cargo/guide/project-layout.html:169: broken link - cargo/guide/reference/manifest.html
[01:20:02] cargo/guide/cargo-toml-vs-cargo-lock.html:151: broken link - cargo/guide/faq.html
[01:20:02] cargo/guide/cargo-toml-vs-cargo-lock.html:218: broken link - cargo/guide/reference/pkgid-spec.html
[01:20:02] cargo/guide/index.html:143: broken link - cargo/guide/guide/why-cargo-exists.html
[01:20:02] cargo/guide/index.html:144: broken link - cargo/guide/guide/creating-a-new-project.html
[01:20:02] cargo/guide/index.html:145: broken link - cargo/guide/guide/working-on-an-existing-project.html
[01:20:02] cargo/guide/index.html:146: broken link - cargo/guide/guide/dependencies.html
[01:20:02] cargo/guide/index.html:147: broken link - cargo/guide/guide/project-layout.html
[01:20:02] cargo/guide/index.html:148: broken link - cargo/guide/guide/cargo-toml-vs-cargo-lock.html
[01:20:02] cargo/guide/index.html:149: broken link - cargo/guide/guide/tests.html
[01:20:02] cargo/guide/index.html:150: broken link - cargo/guide/guide/continuous-integration.html
[01:20:02] cargo/guide/index.html:151: broken link - cargo/guide/guide/build-cache.html
[01:20:02] cargo/guide/dependencies.html:151: broken link - cargo/guide/reference/specifying-dependencies.html
[01:20:02] cargo/getting-started/index.html:142: broken link - cargo/getting-started/getting-started/installation.html
[01:20:02] cargo/getting-started/index.html:143: broken link - cargo/getting-started/getting-started/first-steps.html
[01:20:02] cargo/getting-started/first-steps.html:183: broken link - cargo/getting-started/guide/index.html
[01:20:02] cargo/reference/config.html:142: broken link - cargo/reference/reference/manifest.html
[01:20:02] cargo/reference/config.html:277: broken link - cargo/reference/reference/source-replacement.html
[01:20:02] cargo/reference/config.html:280: broken link - cargo/reference/reference/environment-variables.html
[01:20:02] cargo/reference/unstable.html:296: broken link - cargo/reference/reference/config.html
[01:20:02] cargo/reference/manifest.html:178: broken link - cargo/reference/reference/build-scripts.html
[01:20:02] cargo/reference/manifest.html:180: broken link - cargo/reference/reference/build-scripts.html
[01:20:02] cargo/reference/manifest.html:187: broken link - cargo/reference/reference/build-scripts.html
[01:20:02] cargo/reference/manifest.html:378: broken link - cargo/reference/reference/specifying-dependencies.html
[01:20:02] cargo/reference/manifest.html:785: broken link - cargo/reference/reference/specifying-dependencies.html
[01:20:02] cargo/reference/manifest.html:814: broken link - cargo/reference/reference/specifying-dependencies.html
[01:20:02] cargo/reference/manifest.html:818: broken link - cargo/reference/reference/specifying-dependencies.html
[01:20:02] cargo/reference/manifest.html:824: broken link - cargo/reference/reference/pkgid-spec.html
[01:20:02] cargo/reference/manifest.html:831: broken link - cargo/reference/reference/specifying-dependencies.html
[01:20:02] cargo/reference/publishing.html:208: broken link - cargo/reference/reference/manifest.html
[01:20:02] cargo/reference/publishing.html:213: broken link - cargo/reference/reference/manifest.html
[01:20:02] cargo/reference/build-scripts.html:169: broken link - cargo/reference/reference/environment-variables.html
[01:20:02] cargo/reference/build-scripts.html:309: broken link - cargo/reference/reference/config.html
[01:20:02] cargo/reference/index.html:142: broken link - cargo/reference/reference/specifying-dependencies.html
[01:20:02] cargo/reference/index.html:143: broken link - cargo/reference/reference/manifest.html
[01:20:02] cargo/reference/index.html:144: broken link - cargo/reference/reference/config.html
[01:20:02] cargo/reference/index.html:145: broken link - cargo/reference/reference/environment-variables.html
[01:20:02] cargo/reference/index.html:146: broken link - cargo/reference/reference/build-scripts.html
[01:20:02] cargo/reference/index.html:147: broken link - cargo/reference/reference/publishing.html
[01:20:02] cargo/reference/index.html:148: broken link - cargo/reference/reference/pkgid-spec.html
[01:20:02] cargo/reference/index.html:149: broken link - cargo/reference/reference/source-replacement.html
[01:20:02] cargo/reference/index.html:150: broken link - cargo/reference/reference/external-tools.html
[01:20:02] cargo/reference/index.html:151: broken link - cargo/reference/reference/unstable.html
[01:20:02] cargo/reference/source-replacement.html:141: broken link - cargo/reference/reference/specifying-dependencies.html
[01:20:02] cargo/reference/source-replacement.html:145: broken link - cargo/reference/reference/config.html
[01:20:02] cargo/reference/source-replacement.html:192: broken link - cargo/reference/reference/manifest.html
[01:20:02] cargo/reference/source-replacement.html:195: broken link - cargo/reference/reference/config.html
[01:20:02] cargo/reference/specifying-dependencies.html:148: broken link - cargo/reference/guide/index.html
[01:20:02] cargo/reference/specifying-dependencies.html:228: broken link - cargo/reference/guide/index.html
[01:20:02] cargo/reference/specifying-dependencies.html:276: broken link - cargo/reference/reference/manifest.html
[01:20:02] cargo/reference/specifying-dependencies.html:278: broken link - cargo/reference/reference/manifest.html
[01:20:02] cargo/reference/specifying-dependencies.html:427: broken link - cargo/reference/reference/config.html
[01:20:02] cargo/reference/specifying-dependencies.html:527: broken link - cargo/reference/reference/manifest.html
[01:20:02] cargo/reference/environment-variables.html:174: broken link - cargo/reference/reference/config.html
[01:20:02] cargo/reference/environment-variables.html:252: broken link - cargo/reference/reference/build-scripts.html
[01:20:02] cargo/reference/environment-variables.html:259: broken link - cargo/reference/reference/config.html
[01:20:02] embedded-book/print.html:377: broken link - embedded-book/install/linux.html
[01:20:02] embedded-book/print.html:378: broken link - embedded-book/install/windows.html
[01:20:02] embedded-book/print.html:379: broken link - embedded-book/install/macos.html
[01:20:02] embedded-book/print.html:482: broken link - embedded-book/verify.html
[01:20:02] embedded-book/print.html:494: broken link - embedded-book/verify.html
[01:20:02] embedded-book/print.html:520: broken link - embedded-book/verify.html
[01:20:02] embedded-book/print.html:555: broken link - hardware.html
[01:20:02] embedded-book/print.html:562: broken link - hardware.html
[01:20:02] embedded-book/print.html:565: broken link - embedded-book/linux.html
[01:20:02] embedded-book/print.html:631: broken link - embedded-book/hardware.html
[01:20:02] embedded-book/print.html:1110: broken link - embedded-book/qemu.html
[01:20:02] embedded-book/print.html:1154: broken link - intro/install/verify.html
[01:20:02] embedded-book/print.html:1176: broken link - intro/install/verify.html
[01:20:02] embedded-book/print.html:1332: broken link - portability/index.html
[01:20:02] embedded-book/print.html:1355: broken link - peripherals/index.html
[01:20:05] edition-guide/rust-2018/the-compiler/index.html:141: broken link - edition-guide/rust-2018/the-compiler/rust-2018/the-compiler/improved-error-messages.html
[01:20:05] edition-guide/rust-2018/macros/index.html:141: broken link - edition-guide/rust-2018/macros/rust-2018/macros/custom-derive.html
[01:20:05] edition-guide/rust-2018/cargo-and-crates-io/index.html:141: broken link - edition-guide/rust-2018/cargo-and-crates-io/rust-2018/cargo-and-crates-io/cargo-check-for-faster-checking.html
[01:20:05] edition-guide/rust-2018/documentation/index.html:141: broken link - edition-guide/rust-2018/documentation/rust-2018/documentation/new-editions-of-the-book.html
[01:20:05] edition-guide/rust-2018/control-flow/index.html:141: broken link - edition-guide/rust-2018/control-flow/rust-2018/control-flow/async-await-for-easier-concurrency.html
[01:20:05] edition-guide/rust-2018/module-system/path-clarity.html:217: broken link - edition-guide/rust-2018/module-system/rust-2018/macros/macro-changes.html
[01:20:05] edition-guide/rust-2018/module-system/index.html:141: broken link - edition-guide/rust-2018/module-system/rust-2018/module-system/path-clarity.html
[01:20:05] edition-guide/rust-2018/trait-system/index.html:141: broken link - edition-guide/rust-2018/trait-system/rust-2018/trait-system/impl-trait-for-returning-complex-types-with-ease.html
[01:20:05] edition-guide/rust-2018/trait-system/dyn-trait-for-trait-objects.html:172: broken link - edition-guide/rust-2018/trait-system/rust-2018/trait-system/impl-trait-for-returning-complex-types-with-ease.html
[01:20:05] edition-guide/rust-2018/platform-and-target-support/index.html:141: broken link - edition-guide/rust-2018/platform-and-target-support/rust-2018/platform-and-target-support/libcore-for-low-level-rust.html
[01:20:05] edition-guide/rust-2018/rustdoc/index.html:141: broken link - edition-guide/rust-2018/rustdoc/rust-2018/rustdoc/documentation-tests-can-now-compile-fail.html
[01:20:05] edition-guide/rust-2018/ownership-and-lifetimes/lifetime-elision-in-impl.html:182: broken link - edition-guide/rust-2018/ownership-and-lifetimes/rust-2018/ownership-and-lifetimes/the-anonymous-lifetime.html
[01:20:05] edition-guide/rust-2018/ownership-and-lifetimes/index.html:141: broken link - edition-guide/rust-2018/ownership-and-lifetimes/rust-2018/ownership-and-lifetimes/default-match-bindings.html
[01:20:05] edition-guide/rust-2018/data-types/index.html:141: broken link - edition-guide/rust-2018/data-types/rust-2018/data-types/field-init-shorthand.html
[01:20:05] edition-guide/rust-2018/error-handling-and-panics/index.html:141: broken link - edition-guide/rust-2018/error-handling-and-panics/rust-2018/error-handling-and-panics/the-question-mark-operator-for-easier-error-handling.html
[01:20:05] edition-guide/editions/transitioning-an-existing-project-to-a-new-edition.html:160: broken link - edition-guide/editions/rust-2018/trait-system/no-anon-params.html
[01:20:05] edition-guide/editions/transitioning-an-existing-project-to-a-new-edition.html:212: broken link - edition-guide/editions/rust-2018/trait-system/dyn-trait-for-trait-objects.html
[01:20:07] unstable-book/language-features/asm.html:293: broken link - unstable-book/language-features/language-features/global-asm.html
[01:20:07] unstable-book/language-features/box-syntax.html:141: broken link - unstable-book/language-features/language-features/box-patterns.html
[01:20:07] unstable-book/language-features/unboxed-closures.html:141: broken link - unstable-book/language-features/library-features/fn-traits.html
[01:20:07] unstable-book/language-features/box-patterns.html:141: broken link - unstable-book/language-features/language-features/box-syntax.html
[01:20:07] unstable-book/language-features/non-ascii-idents.html:171: broken link - unstable-book/reference/keywords.html
[01:20:07] unstable-book/language-features/plugin.html:142: broken link - unstable-book/language-features/language-features/plugin-registrar.html
[01:20:07] unstable-book/language-features/plugin.html:164: broken link - unstable-book/book/macros.html
[01:20:07] unstable-book/language-features/plugin.html:248: broken link - unstable-book/reference/attributes.html
[01:20:07] unstable-book/language-features/plugin.html:278: broken link - unstable-book/reference/attributes.html
[01:20:07] unstable-book/language-features/plugin.html:351: broken link - unstable-book/reference/attributes.html
[01:20:07] unstable-book/language-features/lang-items.html:308: broken link - unstable-book/language-features/library-features/compiler-builtins-lib.html
[01:20:07] unstable-book/language-features/plugin-registrar.html:142: broken link - unstable-book/language-features/language-features/plugin.html
[01:20:07] unstable-book/language-features/global-asm.html:199: broken link - unstable-book/language-features/language-features/asm.html
[01:20:07] unstable-book/library-features/fn-traits.html:141: broken link - unstable-book/library-features/language-features/unboxed-closures.html
[01:20:07] reference/items/static-items.html:145: broken link - reference/items/identifiers.html
[01:20:07] reference/items/static-items.html:145: broken link - reference/items/types.html
[01:20:07] reference/items/static-items.html:146: broken link - reference/items/expressions.html
[01:20:07] reference/items/static-items.html:148: broken link - reference/items/items/constant-items.html
[01:20:07] reference/items/static-items.html:152: broken link - reference/items/interior-mutability.html
[01:20:07] reference/items/static-items.html:153: broken link - reference/items/destructors.html
[01:20:07] reference/items/static-items.html:158: broken link - reference/items/const_eval.html
[01:20:07] reference/items/type-aliases.html:145: broken link - reference/items/identifiers.html
[01:20:07] reference/items/type-aliases.html:145: broken link - reference/items/items/generics.html
[01:20:07] reference/items/type-aliases.html:146: broken link - reference/items/items/generics.html
[01:20:07] reference/items/type-aliases.html:146: broken link - reference/items/types.html
[01:20:07] reference/items/type-aliases.html:148: broken link - reference/items/types.html
[01:20:07] reference/items/traits.html:145: broken link - reference/items/identifiers.html
[01:20:07] reference/items/traits.html:146: broken link - reference/items/items/generics.html
[01:20:07] reference/items/traits.html:147: broken link - reference/items/trait-bounds.html
[01:20:07] reference/items/traits.html:148: broken link - reference/items/items/generics.html
[01:20:07] reference/items/traits.html:152: broken link - reference/items/attributes.html
[01:20:07] reference/items/traits.html:157: broken link - reference/items/macros.html
[01:20:07] reference/items/traits.html:160: broken link - reference/items/expressions/block-expr.html
[01:20:07] reference/items/traits.html:162: broken link - reference/items/expressions/block-expr.html
[01:20:07] reference/items/traits.html:164: broken link - reference/items/items/functions.html
[01:20:07] reference/items/traits.html:164: broken link - reference/items/identifiers.html
[01:20:07] reference/items/traits.html:164: broken link - reference/items/items/generics.html
[01:20:07] reference/items/traits.html:166: broken link - reference/items/items/functions.html
[01:20:07] reference/items/traits.html:166: broken link - reference/items/items/generics.html
[01:20:07] reference/items/traits.html:168: broken link - reference/items/items/functions.html
[01:20:07] reference/items/traits.html:168: broken link - reference/items/identifiers.html
[01:20:07] reference/items/traits.html:168: broken link - reference/items/items/generics.html
[01:20:07] reference/items/traits.html:169: broken link - reference/items/items/associated-items.html
[01:20:07] reference/items/traits.html:170: broken link - reference/items/items/functions.html
[01:20:07] reference/items/traits.html:170: broken link - reference/items/items/generics.html
[01:20:07] reference/items/traits.html:174: broken link - reference/items/patterns.html
[01:20:07] reference/items/traits.html:174: broken link - reference/items/types.html
[01:20:07] reference/items/traits.html:176: broken link - reference/items/identifiers.html
[01:20:07] reference/items/traits.html:176: broken link - reference/items/types.html
[01:20:07] reference/items/traits.html:176: broken link - reference/items/expressions.html
[01:20:07] reference/items/traits.html:178: broken link - reference/items/identifiers.html
[01:20:07] reference/items/traits.html:178: broken link - reference/items/trait-bounds.html
[01:20:07] reference/items/traits.html:181: broken link - reference/items/items/associated-items.html
[01:20:07] reference/items/traits.html:183: broken link - reference/items/items/associated-items.html
[01:20:07] reference/items/traits.html:184: broken link - reference/items/items/associated-items.html
[01:20:07] reference/items/traits.html:185: broken link - reference/items/items/associated-items.html
[01:20:07] reference/items/traits.html:190: broken link - reference/items/items/generics.html
[01:20:07] reference/items/traits.html:191: broken link - reference/items/items/implementations.html
[01:20:07] reference/items/traits.html:197: broken link - reference/items/trait-bounds.html
[01:20:07] reference/items/traits.html:200: broken link - reference/items/items/functions.html
[01:20:07] reference/items/traits.html:211: broken link - reference/items/types/trait-object.html
[01:20:07] reference/items/traits.html:219: broken link - reference/items/items/associated-items.html
[01:20:07] reference/items/traits.html:227: broken link - reference/items/items/generics.html
[01:20:07] reference/items/traits.html:227: broken link - reference/items/types/trait-object.html
[01:20:07] reference/items/traits.html:240: broken link - reference/items/items/generics.html
[01:20:07] reference/items/traits.html:289: broken link - reference/items/unsafety.html
[01:20:07] reference/items/traits.html:290: broken link - reference/items/items/implementations.html
[01:20:07] reference/items/traits.html:291: broken link - reference/items/special-types-and-traits.html
[01:20:07] reference/items/traits.html:291: broken link - reference/items/special-types-and-traits.html
[01:20:07] reference/items/traits.html:293: broken link - reference/items/identifiers.html
[01:20:07] reference/items/traits.html:294: broken link - reference/items/patterns.html
[01:20:07] reference/items/traits.html:294: broken link - reference/items/identifiers.html
[01:20:07] reference/items/traits.html:308: broken link - reference/items/identifiers.html
[01:20:07] reference/items/traits.html:309: broken link - reference/items/identifiers.html
[01:20:07] reference/items/traits.html:310: broken link - reference/items/patterns.html
[01:20:07] reference/items/traits.html:311: broken link - reference/items/identifiers.html
[01:20:07] reference/items/traits.html:312: broken link - reference/items/identifiers.html
[01:20:07] reference/items/modules.html:145: broken link - reference/items/identifiers.html
[01:20:07] reference/items/modules.html:146: broken link - reference/items/identifiers.html
[01:20:07] reference/items/modules.html:147: broken link - reference/items/attributes.html
[01:20:07] reference/items/modules.html:148: broken link - reference/items/items.html
[01:20:07] reference/items/modules.html:151: broken link - reference/items/items.html
[01:20:07] reference/items/modules.html:182: broken link - reference/items/paths.html
[01:20:07] reference/items/modules.html:247: broken link - reference/items/crates-and-source-files.html
[01:20:07] reference/items/modules.html:249: broken link - reference/items/crates-and-source-files.html
[01:20:07] reference/items/modules.html:250: broken link - reference/items/attributes.html
[01:20:07] reference/items/modules.html:255: broken link - reference/items/conditional-compilation.html
[01:20:07] reference/items/modules.html:256: broken link - reference/items/attributes.html
[01:20:07] reference/items/modules.html:256: broken link - reference/items/attributes.html
[01:20:07] reference/items/modules.html:256: broken link - reference/items/attributes.html
[01:20:07] reference/items/enumerations.html:146: broken link - reference/items/identifiers.html
[01:20:07] reference/items/enumerations.html:147: broken link - reference/items/items/generics.html
[01:20:07] reference/items/enumerations.html:148: broken link - reference/items/items/generics.html
[01:20:07] reference/items/enumerations.html:154: broken link - reference/items/identifiers.html
[01:20:07] reference/items/enumerations.html:157: broken link - reference/items/items/structs.html
[01:20:07] reference/items/enumerations.html:159: broken link - reference/items/items/structs.html
[01:20:07] reference/items/enumerations.html:161: broken link - reference/items/expressions.html
[01:20:07] reference/items/enumerations.html:164: broken link - reference/items/types/enum.html
[01:20:07] reference/items/enumerations.html:195: broken link - reference/std/mem/fn.discriminant.html
[01:20:07] reference/items/enumerations.html:200: broken link - reference/items/expressions/operator-expr.html
[01:20:07] reference/items/enumerations.html:201: broken link - reference/items/const_eval.html
[01:20:07] reference/items/enumerations.html:217: broken link - reference/items/type-layout.html
[01:20:07] reference/items/enumerations.html:220: broken link - reference/items/type-layout.html
[01:20:07] reference/items/enumerations.html:220: broken link - reference/items/type-layout.html
[01:20:07] reference/items/functions.html:145: broken link - reference/items/identifiers.html
[01:20:07] reference/items/functions.html:145: broken link - reference/items/items/generics.html
[01:20:07] reference/items/functions.html:147: broken link - reference/items/items/generics.html
[01:20:07] reference/items/functions.html:148: broken link - reference/items/expressions/block-expr.html
[01:20:07] reference/items/functions.html:152: broken link - reference/items/tokens.html
[01:20:07] reference/items/functions.html:152: broken link - reference/items/tokens.html
[01:20:07] reference/items/functions.html:156: broken link - reference/items/patterns.html
[01:20:07] reference/items/functions.html:156: broken link - reference/items/types.html
[01:20:07] reference/items/functions.html:158: broken link - reference/items/types.html
[01:20:07] reference/items/functions.html:160: broken link - reference/items/expressions/block-expr.html
[01:20:07] reference/items/functions.html:162: broken link - reference/items/variables.html
[01:20:07] reference/items/functions.html:164: broken link - reference/items/types.html
[01:20:07] reference/items/functions.html:167: broken link - reference/items/types/function-item.html
[01:20:07] reference/items/functions.html:177: broken link - reference/items/patterns.html
[01:20:07] reference/items/functions.html:209: broken link - reference/items/items/traits.html
[01:20:07] reference/items/functions.html:233: broken link - reference/items/paths.html
[01:20:07] reference/items/functions.html:239: broken link - reference/items/items/external-blocks.html
[01:20:07] reference/items/functions.html:267: broken link - reference/items/const_eval.html
[01:20:07] reference/items/functions.html:290: broken link - reference/items/trait-bounds.html
[01:20:07] reference/items/functions.html:294: broken link - reference/items/trait-bounds.html
[01:20:07] reference/items/functions.html:336: broken link - reference/items/attributes.html
[01:20:07] reference/items/functions.html:336: broken link - reference/items/attributes.html
[01:20:07] reference/items/functions.html:337: broken link - reference/items/expressions/block-expr.html
[01:20:07] reference/items/functions.html:348: broken link - reference/items/conditional-compilation.html
[01:20:07] reference/items/functions.html:348: broken link - reference/items/attributes.html
[01:20:07] reference/items/functions.html:349: broken link - reference/items/attributes.html
[01:20:07] reference/items/functions.html:349: broken link - reference/items/attributes.html
[01:20:07] reference/items/functions.html:350: broken link - reference/items/attributes.html
[01:20:07] reference/items/functions.html:350: broken link - reference/items/procedural-macros.html
[01:20:07] reference/items/functions.html:350: broken link - reference/items/attributes.html
[01:20:07] reference/items/functions.html:351: broken link - reference/items/attributes.html
[01:20:07] reference/items/structs.html:149: broken link - reference/items/identifiers.html
[01:20:07] reference/items/structs.html:150: broken link - reference/items/items/generics.html
[01:20:07] reference/items/structs.html:151: broken link - reference/items/items/generics.html
[01:20:07] reference/items/structs.html:155: broken link - reference/items/identifiers.html
[01:20:07] reference/items/structs.html:156: broken link - reference/items/items/generics.html
[01:20:07] reference/items/structs.html:158: broken link - reference/items/items/generics.html
[01:20:07] reference/items/structs.html:163: broken link - reference/items/attributes.html
[01:20:07] reference/items/structs.html:164: broken link - reference/items/visibility-and-privacy.html
[01:20:07] reference/items/structs.html:165: broken link - reference/items/identifiers.html
[01:20:07] reference/items/structs.html:165: broken link - reference/items/types.html
[01:20:07] reference/items/structs.html:169: broken link - reference/items/attributes.html
[01:20:07] reference/items/structs.html:170: broken link - reference/items/visibility-and-privacy.html
[01:20:07] reference/items/structs.html:171: broken link - reference/items/types.html
[01:20:07] reference/items/structs.html:173: broken link - reference/items/types/struct.html
[01:20:07] reference/items/structs.html:182: broken link - reference/items/types/tuple.html
[01:20:07] reference/items/structs.html:209: broken link - reference/items/type-layout.html
[01:20:07] reference/items/implementations.html:147: broken link - reference/items/items/generics.html
[01:20:07] reference/items/implementations.html:147: broken link - reference/items/types.html
[01:20:07] reference/items/implementations.html:147: broken link - reference/items/items/generics.html
[01:20:07] reference/items/implementations.html:148: broken link - reference/items/attributes.html
[01:20:07] reference/items/implementations.html:152: broken link - reference/items/attributes.html
[01:20:07] reference/items/implementations.html:153: broken link - reference/items/macros.html
[01:20:07] reference/items/implementations.html:154: broken link - reference/items/visibility-and-privacy.html
[01:20:07] reference/items/implementations.html:154: broken link - reference/items/items/constant-items.html
[01:20:07] reference/items/implementations.html:154: broken link - reference/items/items/functions.html
[01:20:07] reference/items/implementations.html:154: broken link - reference/items/items/associated-items.html
[01:20:07] reference/items/implementations.html:157: broken link - reference/items/items/generics.html
[01:20:07] reference/items/implementations.html:158: broken link - reference/items/paths.html
[01:20:07] reference/items/implementations.html:158: broken link - reference/items/types.html
[01:20:07] reference/items/implementations.html:159: broken link - reference/items/items/generics.html
[01:20:07] reference/items/implementations.html:161: broken link - reference/items/attributes.html
[01:20:07] reference/items/implementations.html:165: broken link - reference/items/attributes.html
[01:20:07] reference/items/implementations.html:166: broken link - reference/items/macros.html
[01:20:07] reference/items/implementations.html:167: broken link - reference/items/visibility-and-privacy.html
[01:20:07] reference/items/implementations.html:167: broken link - reference/items/items/type-aliases.html
[01:20:07] reference/items/implementations.html:167: broken link - reference/items/items/constant-items.html
[01:20:07] reference/items/implementations.html:167: broken link - reference/items/items/functions.html
[01:20:07] reference/items/implementations.html:167: broken link - reference/items/items/associated-items.html
[01:20:07] reference/items/implementations.html:177: broken link - reference/items/items/traits.html
[01:20:07] reference/items/implementations.html:207: broken link - reference/items/items/traits.html
[01:20:07] reference/items/implementations.html:218: broken link - reference/items/items/traits.html
[01:20:07] reference/items/implementations.html:295: broken link - reference/items/attributes.html
[01:20:07] reference/items/implementations.html:296: broken link - reference/items/attributes.html
[01:20:07] reference/items/implementations.html:298: broken link - reference/items/conditional-compilation.html
[01:20:07] reference/items/implementations.html:298: broken link - reference/items/attributes.html
[01:20:07] reference/items/implementations.html:298: broken link - reference/items/attributes.html
[01:20:07] reference/items/implementations.html:298: broken link - reference/items/attributes.html
[01:20:07] reference/items/associated-items.html:142: broken link - reference/items/items/traits.html
[01:20:07] reference/items/associated-items.html:143: broken link - reference/items/items/implementations.html
[01:20:07] reference/items/associated-items.html:156: broken link - reference/items/items/functions.html
[01:20:07] reference/items/associated-items.html:164: broken link - reference/items/types/function-item.html
[01:20:07] reference/items/associated-items.html:184: broken link - reference/items/paths.html
[01:20:07] reference/items/associated-items.html:206: broken link - reference/items/items/functions.html
[01:20:07] reference/items/associated-items.html:206: broken link - reference/items/identifiers.html
[01:20:07] reference/items/associated-items.html:206: broken link - reference/items/items/generics.html
[01:20:07] reference/items/associated-items.html:207: broken link - reference/items/items/functions.html
[01:20:07] reference/items/associated-items.html:208: broken link - reference/items/items/functions.html
[01:20:07] reference/items/associated-items.html:208: broken link - reference/items/items/generics.html
[01:20:07] reference/items/associated-items.html:209: broken link - reference/items/expressions/block-expr.html
[01:20:07] reference/items/associated-items.html:211: broken link - reference/items/trait-bounds.html
[01:20:07] reference/items/associated-items.html:212: broken link - reference/items/types.html
[01:20:07] reference/items/associated-items.html:215: broken link - reference/items/expressions/method-call-expr.html
[01:20:07] reference/items/associated-items.html:241: broken link - reference/items/items/implementations.html
[01:20:07] reference/items/associated-items.html:277: broken link - reference/items/items/type-aliases.html
[01:20:07] reference/items/associated-items.html:278: broken link - reference/items/items/implementations.html
[01:20:07] reference/items/associated-items.html:281: broken link - reference/items/identifiers.html
[01:20:07] reference/items/associated-items.html:286: broken link - reference/items/identifiers.html
[01:20:07] reference/items/associated-items.html:286: broken link - reference/items/types.html
[01:20:07] reference/items/associated-items.html:346: broken link - reference/items/items/constant-items.html
[01:20:07] reference/items/associated-items.html:353: broken link - reference/items/items/constant-items.html
[01:20:07] reference/items/extern-crates.html:145: broken link - reference/items/identifiers.html
[01:20:07] reference/items/extern-crates.html:145: broken link - reference/items/identifiers.html
[01:20:07] reference/items/extern-crates.html:148: broken link - reference/items/identifiers.html
[01:20:07] reference/items/extern-crates.html:156: broken link - reference/items/identifiers.html
[01:20:07] reference/items/extern-crates.html:178: broken link - reference/items/items/use-declarations.html
[01:20:07] reference/items/extern-crates.html:180: broken link - reference/items/items/use-declarations.html
[01:20:07] reference/items/extern-crates.html:188: broken link - reference/items/paths.html
[01:20:07] reference/items/extern-crates.html:188: broken link - reference/items/paths.html
[01:20:07] reference/items/use-declarations.html:147: broken link - reference/items/paths.html
[01:20:07] reference/items/use-declarations.html:148: broken link - reference/items/paths.html
[01:20:07] reference/items/use-declarations.html:149: broken link - reference/items/paths.html
[01:20:07] reference/items/use-declarations.html:149: broken link - reference/items/identifiers.html
[01:20:07] reference/items/use-declarations.html:152: broken link - reference/items/paths.html
[01:20:07] reference/items/use-declarations.html:153: broken link - reference/items/items/modules.html
[01:20:07] reference/items/use-declarations.html:154: broken link - reference/items/expressions/block-expr.html
[01:20:07] reference/items/use-declarations.html:157: broken link - reference/items/items/extern-crates.html
[01:20:07] reference/items/use-declarations.html:213: broken link - reference/items/paths.html
[01:20:07] reference/items/generics.html:152: broken link - reference/items/attributes.html
[01:20:07] reference/items/generics.html:152: broken link - reference/items/tokens.html
[01:20:07] reference/items/generics.html:152: broken link - reference/items/trait-bounds.html
[01:20:07] reference/items/generics.html:156: broken link - reference/items/attributes.html
[01:20:07] reference/items/generics.html:156: broken link - reference/items/identifiers.html
[01:20:07] reference/items/generics.html:156: broken link - reference/items/trait-bounds.html
[01:20:07] reference/items/generics.html:156: broken link - reference/items/types.html
[01:20:07] reference/items/generics.html:172: broken link - reference/items/types/pointer.html
[01:20:07] reference/items/generics.html:172: broken link - reference/items/types/pointer.html
[01:20:07] reference/items/generics.html:172: broken link - reference/items/types/array.html
[01:20:07] reference/items/generics.html:172: broken link - reference/items/types/array.html
[01:20:07] reference/items/generics.html:172: broken link - reference/items/types/tuple.html
[01:20:07] reference/items/generics.html:173: broken link - reference/items/types/function-pointer.html
[01:20:07] reference/items/generics.html:184: broken link - reference/items/trait-bounds.html
[01:20:07] reference/items/generics.html:184: broken link - reference/items/trait-bounds.html
[01:20:07] reference/items/generics.html:186: broken link - reference/items/types.html
[01:20:07] reference/items/generics.html:186: broken link - reference/items/trait-bounds.html
[01:20:07] reference/items/generics.html:195: broken link - reference/items/special-types-and-traits.html
[01:20:07] reference/items/generics.html:195: broken link - reference/items/special-types-and-traits.html
[01:20:07] reference/items/generics.html:195: broken link - reference/items/special-types-and-traits.html
[01:20:07] reference/items/generics.html:197: broken link - reference/items/types/trait-object.html
[01:20:07] reference/items/generics.html:197: broken link - reference/items/types/array.html
[01:20:07] reference/items/generics.html:212: broken link - reference/items/attributes.html
[01:20:07] reference/items/unions.html:145: broken link - reference/items/identifiers.html
[01:20:07] reference/items/unions.html:145: broken link - reference/items/items/generics.html
[01:20:07] reference/items/unions.html:145: broken link - reference/items/items/generics.html
[01:20:07] reference/items/unions.html:146: broken link - reference/items/items/structs.html
[01:20:07] reference/items/external-blocks.html:145: broken link - reference/items/items/functions.html
[01:20:07] reference/items/external-blocks.html:146: broken link - reference/items/attributes.html
[01:20:07] reference/items/external-blocks.html:150: broken link - reference/items/attributes.html
[01:20:07] reference/items/external-blocks.html:151: broken link - reference/items/visibility-and-privacy.html
[01:20:07] reference/items/external-blocks.html:154: broken link - reference/items/identifiers.html
[01:20:07] reference/items/external-blocks.html:154: broken link - reference/items/types.html
[01:20:07] reference/items/external-blocks.html:156: broken link - reference/items/identifiers.html
[01:20:07] reference/items/external-blocks.html:156: broken link - reference/items/items/generics.html
[01:20:07] reference/items/external-blocks.html:158: broken link - reference/items/items/functions.html
[01:20:07] reference/items/external-blocks.html:158: broken link - reference/items/items/generics.html
[01:20:07] reference/items/external-blocks.html:162: broken link - reference/items/identifiers.html
[01:20:07] reference/items/external-blocks.html:162: broken link - reference/items/types.html
[01:20:07] reference/items/external-blocks.html:172: broken link - reference/items/identifiers.html
[01:20:07] reference/items/external-blocks.html:182: broken link - reference/items/attributes.html
[01:20:07] reference/items/constant-items.html:145: broken link - reference/items/identifiers.html
[01:20:07] reference/items/constant-items.html:145: broken link - reference/items/types.html
[01:20:07] reference/items/constant-items.html:145: broken link - reference/items/expressions.html
[01:20:07] reference/items/constant-items.html:147: broken link - reference/items/const_eval.html
[01:20:07] reference/items/constant-items.html:156: broken link - reference/items/lifetime-elision.html
[01:20:07] reference/expressions/operator-expr.html:177: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:178: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:181: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:188: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:188: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:222: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:225: broken link - reference/expressions/types/pointer.html
[01:20:07] reference/expressions/operator-expr.html:227: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:231: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:246: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:292: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:293: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:299: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:318: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:318: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:319: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:319: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:320: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:320: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:321: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:321: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:322: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:322: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:323: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:323: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:324: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:324: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:325: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:325: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:326: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:326: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:327: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:327: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:333: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:369: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:369: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:370: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:370: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:371: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:371: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:372: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:372: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:373: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:373: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:374: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:374: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:387: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:416: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:416: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:417: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:417: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:436: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:436: broken link - reference/expressions/types.html
[01:20:07] reference/expressions/operator-expr.html:453: broken link - reference/expressions/type-coercions.html
[01:20:07] reference/expressions/operator-expr.html:465: broken link - reference/expressions/types/function-pointer.html
[01:20:07] reference/expressions/operator-expr.html:528: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:528: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:530: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:531: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:532: broken link - reference/expressions/types/tuple.html
[01:20:07] reference/expressions/operator-expr.html:533: broken link - reference/expressions/destructors.html
[01:20:07] reference/expressions/operator-expr.html:535: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:550: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:550: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:551: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:551: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:552: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:552: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:553: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:553: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:554: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:554: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:555: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:555: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:556: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:556: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:557: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:557: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:558: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:558: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:559: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:559: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/operator-expr.html:564: broken link - reference/expressions/types/tuple.html
[01:20:07] reference/expressions/operator-expr.html:567: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/if-expr.html:146: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/if-expr.html:146: broken link - reference/expressions/expressions/block-expr.html
[01:20:07] reference/expressions/if-expr.html:148: broken link - reference/expressions/expressions/block-expr.html
[01:20:07] reference/expressions/if-expr.html:185: broken link - reference/expressions/patterns.html
[01:20:07] reference/expressions/if-expr.html:185: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/if-expr.html:186: broken link - reference/expressions/expressions/block-expr.html
[01:20:07] reference/expressions/if-expr.html:188: broken link - reference/expressions/expressions/block-expr.html
[01:20:07] reference/expressions/if-expr.html:246: broken link - reference/expressions/expressions/operator-expr.html
[01:20:07] reference/expressions/loop-expr.html:167: broken link - reference/expressions/expressions/block-expr.html
[01:20:07] reference/expressions/loop-expr.html:172: broken link - reference/expressions/types/never.html
[01:20:07] reference/expressions/loop-expr.html:179: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/loop-expr.html:179: broken link - reference/expressions/expressions/block-expr.html
[01:20:07] reference/expressions/loop-expr.html:200: broken link - reference/expressions/patterns.html
[01:20:07] reference/expressions/loop-expr.html:200: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/loop-expr.html:201: broken link - reference/expressions/expressions/block-expr.html
[01:20:07] reference/expressions/loop-expr.html:236: broken link - reference/expressions/patterns.html
[01:20:07] reference/expressions/loop-expr.html:236: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/loop-expr.html:237: broken link - reference/expressions/expressions/block-expr.html
[01:20:07] reference/expressions/loop-expr.html:291: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/loop-expr.html:299: broken link - reference/expressions/tokens.html
[01:20:07] reference/expressions/loop-expr.html:312: broken link - reference/expressions/tokens.html
[01:20:07] reference/expressions/loop-expr.html:312: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/loop-expr.html:347: broken link - reference/expressions/tokens.html
[01:20:07] reference/expressions/struct-expr.html:149: broken link - reference/expressions/paths.html
[01:20:07] reference/expressions/struct-expr.html:149: broken link - reference/expressions/attributes.html
[01:20:07] reference/expressions/struct-expr.html:153: broken link - reference/expressions/identifiers.html
[01:20:07] reference/expressions/struct-expr.html:154: broken link - reference/expressions/identifiers.html
[01:20:07] reference/expressions/struct-expr.html:154: broken link - reference/expressions/tokens.html
[01:20:07] reference/expressions/struct-expr.html:154: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/struct-expr.html:156: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/struct-expr.html:158: broken link - reference/expressions/paths.html
[01:20:07] reference/expressions/struct-expr.html:159: broken link - reference/expressions/attributes.html
[01:20:07] reference/expressions/struct-expr.html:160: broken link - reference/expressions/expressions.html
[01:20:07] reference/expressions/struct-expr.html:160: broken link - reference/expressions/expressions.html
---
travis_time:end:005fe3b2:start=1544479623887270472,finish=1544479623895043057,duration=7772585
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:109f749a
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0cad6efc
travis_time:start:0cad6efc
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:10b0b52c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@jamesmunns

This comment has been minimized.

Member

jamesmunns commented Dec 10, 2018

Oh. That's unfortunate. Let me ask the folks at the next embedded meeting whether we are okay with breaking convention on how relative links should be formatted.

@steveklabnik how would I run exactly the same test that CI is running for this check? I don't get the same errors when I just run x.py dist or x.py doc, I think it's missing the linkcheck step?

I might be interested in chipping away at the mdbook 0.2 changes, if they are mostly mechanical.

@steveklabnik

This comment has been minimized.

Member

steveklabnik commented Dec 11, 2018

@bors

This comment has been minimized.

Contributor

bors commented Dec 11, 2018

☔️ The latest upstream changes (presumably #56627) made this pull request unmergeable. Please resolve the merge conflicts.

@jamesmunns

This comment has been minimized.

Member

jamesmunns commented Dec 11, 2018

Okay, let me take a pass at this, and see how much damage I can do.

rust-embedded/book#55 is relevant, it's where the embedded wg decided on a canonical link format (using mdbook 0.2).

jamesmunns added some commits Dec 11, 2018

@jamesmunns

This comment has been minimized.

Member

jamesmunns commented Dec 11, 2018

Hey @steveklabnik, I had a bit of an idea. Would you be up for supporting multiple versions of mdbook at the same time? I think this could solve our problem today, and it could make it easier to incrementally port books between versions.

Take a look at this commit, particularly:

There are definitely some cleanups to be made, and the print links are still failing for some reason, but I wanted to check with you to see if this is a route you would be willing to take.

@jamesmunns

This comment has been minimized.

Member

jamesmunns commented Dec 11, 2018

Oh, it looks like fixing print.html might be difficult, we currently skip linkchecking print.html in the embedded book, as mdbook does not render these links as expected.

@steveklabnik is the contents of print.html important in this context? If so, fixing this upstream in mdbook might be required.

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Dec 11, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0263f7ab:start=1544535081973781003,finish=1544535203572342663,duration=121598561660
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:00:00] Attempting with retry: sh -c rm -f download-src-tools-lld.tar.gz &&         curl -sSL -o download-src-tools-lld.tar.gz https://github.com/rust-lang/lld/archive/1928c5eeb613a4c6d232fc47ae91914bbfd92a79.tar.gz
[00:00:00] rm 'src/tools/lldb'
[00:00:00] Attempting with retry: sh -c rm -f download-src-tools-lldb.tar.gz &&         curl -sSL -o download-src-tools-lldb.tar.gz https://github.com/rust-lang-nursery/lldb/archive/8ad0817ce45b0eef9d374691b23f2bd69c164254.tar.gz
[00:00:00] rm 'src/tools/clang'
[00:00:00] Attempting with retry: sh -c git submodule deinit -f  src/tools/rust-installer src/liblibc src/doc/nomicon src/tools/cargo src/doc/reference src/tools/rls src/libcompiler_builtins src/tools/clippy src/tools/rustfmt src/tools/miri src/dlmalloc src/stdsimd src/libbacktrace src/doc/rustc-guide src/doc/edition-guide src/rust-sgx src/doc/embedded-book &&     git submodule sync &&     git submodule update -j 16 --init --recursive  src/tools/rust-installer src/liblibc src/doc/nomicon src/tools/cargo src/doc/reference src/tools/rls src/libcompiler_builtins src/tools/clippy src/tools/rustfmt src/tools/miri src/dlmalloc src/stdsimd src/libbacktrace src/doc/rustc-guide src/doc/edition-guide src/rust-sgx src/doc/embedded-book
[00:00:00] Cleared directory 'src/dlmalloc'
[00:00:00] Cleared directory 'src/doc/edition-guide'
[00:00:00] Cleared directory 'src/doc/embedded-book'
[00:00:00] Cleared directory 'src/doc/nomicon'
---
[00:00:00] Cleared directory 'src/tools/rust-installer'
[00:00:00] Cleared directory 'src/tools/rustfmt'
[00:00:00] Submodule 'src/dlmalloc' (https://github.com/alexcrichton/dlmalloc-rs.git) registered for path 'src/dlmalloc'
[00:00:00] Submodule 'src/doc/edition-guide' (https://github.com/rust-lang-nursery/edition-guide) registered for path 'src/doc/edition-guide'
[00:00:00] Submodule 'src/doc/embedded-book' (https://github.com/rust-embedded/book.git) registered for path 'src/doc/embedded-book'
[00:00:00] Submodule 'src/doc/reference' (https://github.com/rust-lang-nursery/reference.git) registered for path 'src/doc/reference'
[00:00:00] Submodule 'src/doc/rustc-guide' (https://github.com/rust-lang/rustc-guide.git) registered for path 'src/doc/rustc-guide'
[00:00:00] Submodule 'src/libbacktrace' (https://github.com/rust-lang-nursery/libbacktrace.git) registered for path 'src/libbacktrace'
[00:00:00] Submodule 'src/libcompiler_builtins' (https://github.com/rust-lang-nursery/compiler-builtins.git) registered for path 'src/libcompiler_builtins'
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:54:35] 
[00:54:35] running 120 tests
[00:54:38] i..ii...iii..iiii.....i...i..........i...iii............i.....i.....ii...i..i.ii..............i...ii 100/120
[00:54:38] ..ii.i.....iiii.....
[00:54:38] 
[00:54:38]  finished in 3.345
[00:54:38] travis_fold:end:test_codegen

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:54:52] 
[00:54:52] running 118 tests
[00:55:14] .iiiii...i.....i..i...i..i.i..i.i..i.....i..i....i..........iiii.........i.i....i...i.......ii.i.i.i 100/118
[00:55:18] ......iii.i.....ii
[00:55:18] 
[00:55:18]  finished in 26.444
[00:55:18] travis_fold:end:test_debuginfo

---
[01:19:26] travis_fold:end:stage0-linkchecker

[01:19:26] travis_time:end:stage0-linkchecker:start=1544539976208694202,finish=1544539978550606666,duration=2341912464

[01:19:26] embedded-book/print.html:377: broken link - embedded-book/install/linux.html
[01:19:26] embedded-book/print.html:378: broken link - embedded-book/install/windows.html
[01:19:26] embedded-book/print.html:379: broken link - embedded-book/install/macos.html
[01:19:26] embedded-book/print.html:482: broken link - embedded-book/verify.html
[01:19:26] embedded-book/print.html:494: broken link - embedded-book/verify.html
[01:19:26] embedded-book/print.html:520: broken link - embedded-book/verify.html
[01:19:26] embedded-book/print.html:555: broken link - hardware.html
[01:19:26] embedded-book/print.html:562: broken link - hardware.html
[01:19:26] embedded-book/print.html:565: broken link - embedded-book/linux.html
[01:19:26] embedded-book/print.html:631: broken link - embedded-book/hardware.html
[01:19:26] embedded-book/print.html:1110: broken link - embedded-book/qemu.html
[01:19:26] embedded-book/print.html:1154: broken link - intro/install/verify.html
[01:19:26] embedded-book/print.html:1176: broken link - intro/install/verify.html
[01:19:26] embedded-book/print.html:1332: broken link - portability/index.html
[01:19:26] embedded-book/print.html:1355: broken link - peripherals/index.html
[01:19:31] thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:49:9
[01:19:31] 
[01:19:31] 
[01:19:31] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:19:31] expected success, got: exit code: 101
[01:19:31] expected success, got: exit code: 101
[01:19:31] 
[01:19:31] 
[01:19:31] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:19:31] Build completed unsuccessfully in 0:35:09
[01:19:31] Makefile:58: recipe for target 'check' failed
[01:19:31] make: *** [check] Error 1
3128556 ./obj
3113272 ./obj/build
2458616 ./obj/build/x86_64-unknown-linux-gnu
1168224 ./src

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@steveklabnik

This comment has been minimized.

Member

steveklabnik commented Dec 11, 2018

Would you be up for supporting multiple versions of mdbook at the same time? I think this could solve our problem today, and it could make it easier to incrementally port books between versions.

I think this might be really helpful. I am not sure if @rust-lang/infra is happy with it though. If they are, I am! This would be super useful to make the ports incremental, and then we can revert to a single version once it's done.

@steveklabnik is the contents of print.html important in this context? If so, fixing this upstream in mdbook might be required.

Yes; people print these to PDF and expect links to work and stuff. We should fix whatever the print.html issue is, for sure.

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Dec 11, 2018

Dealing with multiple mdbook versions is largely just a matter of build time most likely, and this seems unlikely to cause too much of a slowdown. It'd be great to have numbers on this but we can also eat the time and figure out how to make it faster later

@bors

This comment has been minimized.

Contributor

bors commented Dec 12, 2018

☔️ The latest upstream changes (presumably #56092) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment