New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify resolve typo suggestion #57477

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
4 participants
@euclio
Copy link
Contributor

euclio commented Jan 9, 2019

Include the kind of the binding that we're suggesting, and use a
structured suggestion.

Fixes #53445.

clarify resolve typo suggestion
Include the kind of the binding that we're suggesting, and use a
structured suggestion.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 9, 2019

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@zackmdavis

This comment has been minimized.

Copy link
Member

zackmdavis commented Jan 11, 2019

I'll review this tonight

let suggestion = this.lookup_typo_candidate(path, ns, is_expected, span);
if let Some(suggestion) = suggestion {
let msg = format!(
"{} {} with a similar name exists",

This comment has been minimized.

@zackmdavis

zackmdavis Jan 13, 2019

Member

I like this wording! (I had been unhappy with "did you mean"—the docs even say we don't want to phrase it as a question—but I wasn't sure what to replace it with.

@zackmdavis

This comment has been minimized.

Copy link
Member

zackmdavis commented Jan 13, 2019

I'll review this tonight

That was slightly optimistic, but only by a day

@euclio thanks!! 💖 ✏️

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 13, 2019

📌 Commit 404ad50 has been approved by zackmdavis

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57477 - euclio:clarify-lev-suggestion, r=za…
…ckmdavis

clarify resolve typo suggestion

Include the kind of the binding that we're suggesting, and use a
structured suggestion.

Fixes rust-lang#53445.

bors added a commit that referenced this pull request Jan 14, 2019

Auto merge of #57590 - Centril:rollup, r=Centril
Rollup of 5 pull requests

Successful merges:

 - #57322 (Stabilize core::convert::identity)
 - #57388 (use ignore directives for run-make tests)
 - #57477 (clarify resolve typo suggestion)
 - #57556 (privacy: Fix private-in-public check for existential types)
 - #57584 (Remove the `connect_timeout_unroutable` test.)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57477 - euclio:clarify-lev-suggestion, r=za…
…ckmdavis

clarify resolve typo suggestion

Include the kind of the binding that we're suggesting, and use a
structured suggestion.

Fixes rust-lang#53445.

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57477 - euclio:clarify-lev-suggestion, r=za…
…ckmdavis

clarify resolve typo suggestion

Include the kind of the binding that we're suggesting, and use a
structured suggestion.

Fixes rust-lang#53445.

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57477 - euclio:clarify-lev-suggestion, r=za…
…ckmdavis

clarify resolve typo suggestion

Include the kind of the binding that we're suggesting, and use a
structured suggestion.

Fixes rust-lang#53445.

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57477 - euclio:clarify-lev-suggestion, r=za…
…ckmdavis

clarify resolve typo suggestion

Include the kind of the binding that we're suggesting, and use a
structured suggestion.

Fixes rust-lang#53445.

bors added a commit that referenced this pull request Jan 14, 2019

Auto merge of #57592 - Centril:rollup, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #57232 (Parallelize and optimize parts of HIR map creation)
 - #57418 (MetadataOnlyCodegenBackend: run the collector only once)
 - #57465 (Stabilize cfg_target_vendor)
 - #57477 (clarify resolve typo suggestion)
 - #57556 (privacy: Fix private-in-public check for existential types)
 - #57584 (Remove the `connect_timeout_unroutable` test.)

Failed merges:

r? @ghost

@bors bors merged commit 404ad50 into rust-lang:master Jan 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@euclio euclio deleted the euclio:clarify-lev-suggestion branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment