New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privacy: Fix private-in-public check for existential types #57556

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
4 participants
@petrochenkov
Copy link
Contributor

petrochenkov commented Jan 12, 2019

Fixes #53546 (regression from #56878)

r? @arielb1

@arielb1

This comment has been minimized.

Copy link
Contributor

arielb1 commented Jan 13, 2019

Annoying regression. Luckily, this is only in nightly so we don't need to think about beta. At least we now have a test!

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 13, 2019

📌 Commit f8028b0 has been approved by arielb1

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57556 - petrochenkov:privexist, r=arielb1
privacy: Fix private-in-public check for existential types

Fixes rust-lang#53546 (regression from rust-lang#56878)

r? @arielb1

bors added a commit that referenced this pull request Jan 14, 2019

Auto merge of #57590 - Centril:rollup, r=Centril
Rollup of 5 pull requests

Successful merges:

 - #57322 (Stabilize core::convert::identity)
 - #57388 (use ignore directives for run-make tests)
 - #57477 (clarify resolve typo suggestion)
 - #57556 (privacy: Fix private-in-public check for existential types)
 - #57584 (Remove the `connect_timeout_unroutable` test.)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57556 - petrochenkov:privexist, r=arielb1
privacy: Fix private-in-public check for existential types

Fixes rust-lang#53546 (regression from rust-lang#56878)

r? @arielb1

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57556 - petrochenkov:privexist, r=arielb1
privacy: Fix private-in-public check for existential types

Fixes rust-lang#53546 (regression from rust-lang#56878)

r? @arielb1

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57556 - petrochenkov:privexist, r=arielb1
privacy: Fix private-in-public check for existential types

Fixes rust-lang#53546 (regression from rust-lang#56878)

r? @arielb1

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57556 - petrochenkov:privexist, r=arielb1
privacy: Fix private-in-public check for existential types

Fixes rust-lang#53546 (regression from rust-lang#56878)

r? @arielb1

bors added a commit that referenced this pull request Jan 14, 2019

Auto merge of #57592 - Centril:rollup, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #57232 (Parallelize and optimize parts of HIR map creation)
 - #57418 (MetadataOnlyCodegenBackend: run the collector only once)
 - #57465 (Stabilize cfg_target_vendor)
 - #57477 (clarify resolve typo suggestion)
 - #57556 (privacy: Fix private-in-public check for existential types)
 - #57584 (Remove the `connect_timeout_unroutable` test.)

Failed merges:

r? @ghost

@bors bors merged commit f8028b0 into rust-lang:master Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment