Rollup of 5 pull requests #57590

Centril · 2019-01-14T06:57:04Z

Successful merges:

Stabilize core::convert::identity #57322 (Stabilize core::convert::identity)
use ignore directives for run-make tests #57388 (use ignore directives for run-make tests)
clarify resolve typo suggestion #57477 (clarify resolve typo suggestion)
privacy: Fix private-in-public check for existential types #57556 (privacy: Fix private-in-public check for existential types)
Remove the connect_timeout_unroutable test. #57584 (Remove the connect_timeout_unroutable test.)

Failed merges:

Use the `collect_and_partition_mono_items ` query to avoid calling the collector

This function has no side effects, and its result is ignored.

Include the kind of the binding that we're suggesting, and use a structured suggestion.

It requires an unreachable IP address, but there is no such thing, and this has caused it to fail for multiple people. Fixes rust-lang#44698, fixes rust-lang#50065.

Centril · 2019-01-14T06:57:17Z

@bors r+ p=5

bors · 2019-01-14T06:57:18Z

📌 Commit 77ef320eb1a48541286687ed0c795d1761c54683 has been approved by Centril

bors · 2019-01-14T09:21:48Z

⌛ Testing commit 77ef320eb1a48541286687ed0c795d1761c54683 with merge fb9c5fd8d65413eb553e61f0485de479401a71ce...

bors · 2019-01-14T10:22:17Z

💔 Test failed - checks-travis

rust-highfive · 2019-01-14T10:22:19Z

The job dist-various-1 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:05:36]  ---> f2d758482422
[00:05:36] Step 3/49 : WORKDIR /build
[00:05:36]  ---> Using cache
[00:05:36]  ---> ce0fba60179c
[00:05:36] Step 4/49 : RUN add-apt-repository ppa:team-gcc-arm-embedded/ppa &&     apt-get update &&     apt-get install -y --no-install-recommends gcc-arm-embedded
[00:05:36]  ---> c97f3431e7cc
[00:05:36] Step 5/49 : COPY dist-various-1/build-rumprun.sh /build
[00:05:36]  ---> Using cache
[00:05:36]  ---> 948411f72c3d
---
[00:58:17] [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "compiletest", path: "src/tools/compiletest", mode: ToolBootstrap, is_optional_tool: false, source_type: InTree, extra_features: [] } -- 86.849
[00:58:17] travis_fold:start:test_run-make
travis_time:start:test_run-make
Check compiletest suite=run-make mode=run-make (x86_64-unknown-linux-gnu -> thumbv6m-none-eabi)
[00:58:17] thread 'main' panicked at 'Cannot determine OS from triple', src/tools/compiletest/src/util.rs:77:5
[00:58:17] 
[00:58:17] 
[00:58:17] 
[00:58:17] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv6m-none-eabi/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-make" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make" "--stage-id" "stage2-thumbv6m-none-eabi" "--mode" "run-make" "--target" "thumbv6m-none-eabi" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--linker" "arm-none-eabi-gcc" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/thumbv6m-none-eabi/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--llvm-version" "8.0.0svn\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:58:17] 
[00:58:17] 
[00:58:17] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf src/test/run-make
[00:58:17] Build completed unsuccessfully in 0:50:57
---
travis_time:end:12ca00cd:start=1547461311891254181,finish=1547461311904412830,duration=13158649
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:17c52420
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:03e54c84
travis_time:start:03e54c84
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:02d54a80
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@michaelwoerister

…oerister Parallelize and optimize parts of HIR map creation r? @michaelwoerister

…ster MetadataOnlyCodegenBackend: run the collector only once Use the `collect_and_partition_mono_items` query to avoid calling the collector directly twice. Fixes rust-lang#57406.

…dor, r=joshtriplett,Centril Stabilize cfg_target_vendor This stabilizes the use of `cfg(target_vendor = "...")` and removes the corresponding `cfg_target_vendor` feature. Other unstable cfgs remain behind their existing feature gates. This functionality was added back in 2015 in rust-lang#28612 to complete the coverage of target tuples (`<arch><sub>-<vendor>-<os>-<env>`). [RFC 131](https://github.com/rust-lang/rfcs/blob/master/text/0131-target-specification.md) governs the target specification, not including `target_vendor` seems to have just been an oversight. `target_os`, `target_family`, and `target_arch` are stable as of 1.0.0. `target_env` was also not mentioned in RFC 131, was added in rust-lang#24777, never behind a feature_gate, and insta-stable at 1.1.0. The functionality is tested in [test/run-pass/cfg/cfg-target-vendor.rs](https://github.com/rust-lang/rust/blob/master/src/test/run-pass/cfg/cfg-target-vendor.rs). Closes rust-lang#29718

…ckmdavis clarify resolve typo suggestion Include the kind of the binding that we're suggesting, and use a structured suggestion. Fixes rust-lang#53445.

@arielb1

privacy: Fix private-in-public check for existential types Fixes rust-lang#53546 (regression from rust-lang#56878) r? @arielb1

@sfackler

…utable, r=sfackler Remove the `connect_timeout_unroutable` test. It requires an unreachable IP address, but there is no such thing, and this has caused it to fail for multiple people. Fixes rust-lang#44698, fixes rust-lang#50065. r? @sfackler

rust-highfive · 2019-01-14T10:32:46Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

lqd and others added 6 commits January 7, 2019 19:48

Codegen: run the collector only once

c075e24

Use the `collect_and_partition_mono_items ` query to avoid calling the collector

MetadataOnlyCodegenBackend: remove is_inline call

e5318f3

This function has no side effects, and its result is ignored.

clarify resolve typo suggestion

404ad50

Include the kind of the binding that we're suggesting, and use a structured suggestion.

privacy: Fix private-in-public check for existential types

f8028b0

Remove the connect_timeout_unroutable test.

24a9ac7

It requires an unreachable IP address, but there is no such thing, and this has caused it to fail for multiple people. Fixes rust-lang#44698, fixes rust-lang#50065.

Parallelize and optimize parts of HIR map creation

cbb5a00

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 14, 2019

Jethro Beekman added 2 commits January 14, 2019 14:32

Add additional human-readable cfg strings to rustdoc

6080318

Stabilize cfg_target_vendor, rust-lang#29718

972bba7

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 14, 2019

bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2019

Centril force-pushed the rollup branch 2 times, most recently from 93857dc to 1d029c6 Compare January 14, 2019 10:29

Rollup merge of rust-lang#57232 - Zoxc:par-collector-misc, r=michaelw…

473e1aa

…oerister Parallelize and optimize parts of HIR map creation r? @michaelwoerister

Centril force-pushed the rollup branch from 9ff338b to 1d029c6 Compare January 14, 2019 10:31

Centril added 5 commits January 14, 2019 11:31

Rollup merge of rust-lang#57418 - lqd:collector_query, r=michaelwoeri…

3e869d7

…ster MetadataOnlyCodegenBackend: run the collector only once Use the `collect_and_partition_mono_items` query to avoid calling the collector directly twice. Fixes rust-lang#57406.

Rollup merge of rust-lang#57477 - euclio:clarify-lev-suggestion, r=za…

731f1d8

…ckmdavis clarify resolve typo suggestion Include the kind of the binding that we're suggesting, and use a structured suggestion. Fixes rust-lang#53445.

Rollup merge of rust-lang#57556 - petrochenkov:privexist, r=arielb1

7453da1

privacy: Fix private-in-public check for existential types Fixes rust-lang#53546 (regression from rust-lang#56878) r? @arielb1

Centril closed this Jan 14, 2019

Centril deleted the rollup branch January 14, 2019 10:31

Centril added the rollup A PR which is a rollup label Oct 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 5 pull requests #57590

Rollup of 5 pull requests #57590

Centril commented Jan 14, 2019

Centril commented Jan 14, 2019

bors commented Jan 14, 2019

bors commented Jan 14, 2019

bors commented Jan 14, 2019

rust-highfive commented Jan 14, 2019

rust-highfive commented Jan 14, 2019

Rollup of 5 pull requests #57590

Rollup of 5 pull requests #57590

Conversation

Centril commented Jan 14, 2019

Centril commented Jan 14, 2019

bors commented Jan 14, 2019

bors commented Jan 14, 2019

bors commented Jan 14, 2019

rust-highfive commented Jan 14, 2019

rust-highfive commented Jan 14, 2019