New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpanic_unwind => 2018 #58110

Merged
merged 3 commits into from Feb 14, 2019

Conversation

Projects
None yet
4 participants
@Centril
Copy link
Contributor

Centril commented Feb 3, 2019

Transitions libpanic_unwind to Rust 2018; cc #58099

r? @oli-obk

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Feb 3, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:2be6318c:start=1549205987189677815,finish=1549206059916418023,duration=72726740208
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:59:08]     Checking getopts v0.2.17
[00:59:08]     Checking proc_macro v0.0.0 (/checkout/src/libproc_macro)
[00:59:08]     Checking term v0.0.0 (/checkout/src/libterm)
[00:59:12]  Documenting test v0.0.0 (/checkout/src/libtest)
[00:59:13] error: internal compiler error: src/librustc/hir/def.rs:257: attempted .def_id() on invalid def: NonMacroAttr(Builtin)
[00:59:13] thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:605:9
[00:59:13] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[00:59:13] 
[00:59:13] error: Unrecognized option: 'crate-version'
[00:59:13] error: Unrecognized option: 'crate-version'
[00:59:13] 
[00:59:13] error: Could not document `test`.
[00:59:13] 
[00:59:13] Caused by:
[00:59:13]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --crate-name test src/libtest/lib.rs --color always --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/doc -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/release/deps --extern getopts=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libgetopts-2cd31f015e79e3a8.rmeta --extern proc_macro=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libproc_macro-9b2503eb72968b11.rmeta --extern term=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libterm-0bd89f567a02c34d.rmeta` (exit code: 1)
[00:59:13] 
[00:59:13] 
[00:59:13] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "doc" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "--no-deps" "-p" "test"
[00:59:13] 
[00:59:13] 
[00:59:13] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap doc
[00:59:13] Build completed unsuccessfully in 0:06:24
[00:59:13] Build completed unsuccessfully in 0:06:24
[00:59:13] make: *** [all] Error 1
[00:59:13] Makefile:18: recipe for target 'all' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0628093c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Feb  3 16:00:22 UTC 2019
---
travis_time:end:0cf22440:start=1549209623510304227,finish=1549209623516193620,duration=5889393
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0e051c78
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:144246cf
travis_time:start:144246cf
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0c87c4b9
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Feb 4, 2019

r=me rollup with travis passing

@taiki-e taiki-e referenced this pull request Feb 6, 2019

Open

libstd => 2018 #58208

@Centril Centril force-pushed the Centril:libpanic_unwind-2018 branch from 19786bc to 6127151 Feb 11, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 12, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:38d132b4:start=1549926145966202930,finish=1549926148023732451,duration=2057529521
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[01:03:02]     Checking term v0.0.0 (/checkout/src/libterm)
[01:03:02]     Checking proc_macro v0.0.0 (/checkout/src/libproc_macro)
[01:03:02]     Checking getopts v0.2.17
[01:03:06]  Documenting test v0.0.0 (/checkout/src/libtest)
[01:03:06] error: internal compiler error: src/librustc/hir/def.rs:259: attempted .def_id() on invalid def: NonMacroAttr(Builtin)
[01:03:06] thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:595:9
[01:03:06] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:03:06] 
[01:03:06] error: Unrecognized option: 'crate-version'
[01:03:06] error: Unrecognized option: 'crate-version'
[01:03:06] 
[01:03:06] error: Could not document `test`.
[01:03:06] 
[01:03:06] Caused by:
[01:03:06]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2018 --crate-name test src/libtest/lib.rs --color always --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/doc -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/release/deps --extern getopts=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libgetopts-2cd31f015e79e3a8.rmeta --extern proc_macro=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libproc_macro-9b2503eb72968b11.rmeta --extern term=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libterm-0bd89f567a02c34d.rmeta` (exit code: 1)
[01:03:06] 
[01:03:06] 
[01:03:06] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "doc" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "--no-deps" "-p" "test"
[01:03:06] 
[01:03:06] 
[01:03:06] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap doc
[01:03:06] Build completed unsuccessfully in 0:06:00
[01:03:06] Build completed unsuccessfully in 0:06:00
[01:03:06] make: *** [all] Error 1
[01:03:06] Makefile:18: recipe for target 'all' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:08aef890
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Feb 12 00:05:47 UTC 2019
---
travis_time:end:173befb1:start=1549929948354846608,finish=1549929948360079636,duration=5233028
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:023b829a
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:143f01af
travis_time:start:143f01af
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:030a2401
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril

This comment was marked as resolved.

Copy link
Contributor Author

Centril commented Feb 12, 2019

@petrochenkov @taiki-e Seems like the ICE still persists?

@Centril

This comment has been minimized.

Copy link
Contributor Author

Centril commented Feb 12, 2019

@oli-obk Here's a full dump with backtrace: https://gist.github.com/Centril/70b383fd22cb4e233a3cbcd6f750f600 ; it doesn't exactly happen at the same point, but hopefully it has enough detail...

@Centril Centril force-pushed the Centril:libpanic_unwind-2018 branch from 6127151 to c34e14e Feb 12, 2019

@Centril

This comment has been minimized.

Copy link
Contributor Author

Centril commented Feb 12, 2019

@oli-obk Resolved the ICEs locally, but please double check that it was done in a way that doesn't have bad implications elsewhere.

@Centril Centril force-pushed the Centril:libpanic_unwind-2018 branch from c34e14e to 3657eaa Feb 13, 2019

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Feb 13, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 13, 2019

📌 Commit 3657eaa has been approved by oli-obk

Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019

Rollup merge of rust-lang#58110 - Centril:libpanic_unwind-2018, r=oli…
…-obk

libpanic_unwind => 2018

Transitions `libpanic_unwind` to Rust 2018; cc rust-lang#58099

r? @oli-obk

bors added a commit that referenced this pull request Feb 13, 2019

Auto merge of #58428 - Centril:rollup, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #58110 (libpanic_unwind => 2018)
 - #58167 (HirId-ify hir::BodyId)
 - #58202 (Ignore future deprecations in #[deprecated])
 - #58272 (Cut down on number formating code size)
 - #58276 (Improve the error messages for missing stability attributes)
 - #58354 (Fix ICE and invalid filenames in MIR printing code)
 - #58381 (Only suggest imports if not imported.)
 - #58386 (Fix #54242)
 - #58400 (Fix rustc_driver swallowing errors when compilation is stopped)
 - #58420 (target/uefi: clarify documentation)

Failed merges:

r? @ghost
@Centril

This comment has been minimized.

Copy link
Contributor Author

Centril commented Feb 13, 2019

Failed in rollup (#58428 (comment)), @bors r-

@Centril Centril force-pushed the Centril:libpanic_unwind-2018 branch from 3657eaa to bb08499 Feb 13, 2019

@Centril

This comment has been minimized.

Copy link
Contributor Author

Centril commented Feb 13, 2019

@bors r=oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 13, 2019

📌 Commit bb08499 has been approved by oli-obk

Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019

Rollup merge of rust-lang#58110 - Centril:libpanic_unwind-2018, r=oli…
…-obk

libpanic_unwind => 2018

Transitions `libpanic_unwind` to Rust 2018; cc rust-lang#58099

r? @oli-obk

bors added a commit that referenced this pull request Feb 13, 2019

Auto merge of #58432 - Centril:rollup, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #58110 (libpanic_unwind => 2018)
 - #58167 (HirId-ify hir::BodyId)
 - #58202 (Ignore future deprecations in #[deprecated])
 - #58272 (Cut down on number formating code size)
 - #58276 (Improve the error messages for missing stability attributes)
 - #58354 (Fix ICE and invalid filenames in MIR printing code)
 - #58381 (Only suggest imports if not imported.)
 - #58386 (Fix #54242)
 - #58400 (Fix rustc_driver swallowing errors when compilation is stopped)
 - #58420 (target/uefi: clarify documentation)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Feb 13, 2019

Auto merge of #58432 - Centril:rollup, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #58110 (libpanic_unwind => 2018)
 - #58167 (HirId-ify hir::BodyId)
 - #58202 (Ignore future deprecations in #[deprecated])
 - #58272 (Cut down on number formating code size)
 - #58276 (Improve the error messages for missing stability attributes)
 - #58354 (Fix ICE and invalid filenames in MIR printing code)
 - #58381 (Only suggest imports if not imported.)
 - #58386 (Fix #54242)
 - #58400 (Fix rustc_driver swallowing errors when compilation is stopped)
 - #58420 (target/uefi: clarify documentation)

Failed merges:

r? @ghost

@bors bors merged commit bb08499 into rust-lang:master Feb 14, 2019

@Centril Centril deleted the Centril:libpanic_unwind-2018 branch Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment