Ignore future deprecations in #[deprecated] #58202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
varkor
changed the title
This comment has been minimized.
This comment has been minimized.
varkor
force-pushed
the
deprecated-future-external
branch
from
3ea9d40
to
d8bf945
Compare
|
Looks good to me. Please add a test for rustdoc as well and we're good to go! |
This comment has been minimized.
This comment has been minimized.
|
I've added a new test and updated the old one to ensure that we're checking both places the attribute can affect the docs. |
|
☔ The latest upstream changes (presumably #58266) made this pull request unmergeable. Please resolve the merge conflicts. |
varkor
force-pushed
the
deprecated-future-external
branch
from
e5089a7
to
18ca33b
Compare
|
Thanks! @bors: r+ |
|
📌 Commit 18ca33bde20b17352eb34cbde202d65daec30b5d has been approved by |
bors
added
S-waiting-on-bors
RalfJung
reviewed
Feb 8, 2019
varkor
force-pushed
the
deprecated-future-external
branch
2 times, most recently
from
a2666e8
to
241aad2
Compare
|
Added a test specifically for @bors r=GuillaumeGomez |
|
📌 Commit 241aad22f5c81c4bb57685d8f528781b1e1951a0 has been approved by |
varkor
force-pushed
the
deprecated-future-external
branch
from
241aad2
to
afad118
Compare
This comment has been minimized.
This comment has been minimized.
varkor
force-pushed
the
deprecated-future-external
branch
from
afad118
to
b5fa870
Compare
|
@bors r=GuillaumeGomez |
|
📌 Commit b5fa870 has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 13, 2019
…r=GuillaumeGomez Ignore future deprecations in #[deprecated] The future deprecation warnings should only apply to `#[rustc_deprecated]` as they take into account rustc's version. Fixes rust-lang#57952. I've also slightly modified rustdoc's display of future deprecation notices to make it more consistent, so I'm assigning a rustdoc team member for review to make sure this is okay. r? @GuillaumeGomez
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 13, 2019
…r=GuillaumeGomez Ignore future deprecations in #[deprecated] The future deprecation warnings should only apply to `#[rustc_deprecated]` as they take into account rustc's version. Fixes rust-lang#57952. I've also slightly modified rustdoc's display of future deprecation notices to make it more consistent, so I'm assigning a rustdoc team member for review to make sure this is okay. r? @GuillaumeGomez
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 13, 2019
…r=GuillaumeGomez Ignore future deprecations in #[deprecated] The future deprecation warnings should only apply to `#[rustc_deprecated]` as they take into account rustc's version. Fixes rust-lang#57952. I've also slightly modified rustdoc's display of future deprecation notices to make it more consistent, so I'm assigning a rustdoc team member for review to make sure this is okay. r? @GuillaumeGomez
bors
added a commit
that referenced
this pull request
Feb 13, 2019
Rollup of 10 pull requests Successful merges: - #58110 (libpanic_unwind => 2018) - #58167 (HirId-ify hir::BodyId) - #58202 (Ignore future deprecations in #[deprecated]) - #58272 (Cut down on number formating code size) - #58276 (Improve the error messages for missing stability attributes) - #58354 (Fix ICE and invalid filenames in MIR printing code) - #58381 (Only suggest imports if not imported.) - #58386 (Fix #54242) - #58400 (Fix rustc_driver swallowing errors when compilation is stopped) - #58420 (target/uefi: clarify documentation) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The future deprecation warnings should only apply to
#[rustc_deprecated]as they take into account rustc's version. Fixes #57952.I've also slightly modified rustdoc's display of future deprecation notices to make it more consistent, so I'm assigning a rustdoc team member for review to make sure this is okay.
r? @GuillaumeGomez