New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore future deprecations in #[deprecated] #58202

Merged
merged 7 commits into from Feb 14, 2019

Conversation

Projects
None yet
5 participants
@varkor
Copy link
Member

varkor commented Feb 5, 2019

The future deprecation warnings should only apply to #[rustc_deprecated] as they take into account rustc's version. Fixes #57952.

I've also slightly modified rustdoc's display of future deprecation notices to make it more consistent, so I'm assigning a rustdoc team member for review to make sure this is okay.

r? @GuillaumeGomez

@varkor varkor changed the title Deprecated future external Ignore future deprecations in #[deprecated] Feb 5, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 5, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:1a254572:start=1549403686974300723,finish=1549403687855527144,duration=881226421
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:50:48]    Compiling parking_lot_core v0.3.0
[00:50:50]    Compiling parking_lot v0.6.4
[00:50:52]    Compiling tempfile v3.0.5
[00:50:53]    Compiling rustdoc v0.0.0 (/checkout/src/librustdoc)
[00:50:57] error[E0609]: no field `deprecation` on type `std::option::Option<clean::Stability>`
[00:50:57]     --> src/librustdoc/html/render.rs:2804:45
[00:50:57]      |
[00:50:57] 2804 |         if let Some(since) = item.stability.deprecation.since {
[00:50:57] 
[00:50:57] 
[00:50:57] error[E0609]: no field `deprecation` on type `std::option::Option<clean::Stability>`
[00:50:57]     --> src/librustdoc/html/render.rs:2843:63
[00:50:57]      |
[00:50:57] 2843 |         let mut message = if let Some(since) = item.stability.deprecation.since {
[00:50:57] 
[00:50:58] error: aborting due to 2 previous errors
[00:50:58] 
[00:50:58] For more information about this error, try `rustc --explain E0609`.
---
[00:50:58] 
[00:50:58] 
[00:50:58] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:50:58] Build completed unsuccessfully in 0:46:32
[00:50:58] make: *** [all] Error 1
[00:50:58] Makefile:18: recipe for target 'all' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:081c0dce
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Feb  5 22:45:58 UTC 2019
---
travis_time:end:017c1bbc:start=1549406759051864515,finish=1549406759057132226,duration=5267711
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2e85b9e6
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@varkor varkor force-pushed the varkor:deprecated-future-external branch from 3ea9d40 to d8bf945 Feb 6, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 6, 2019

Looks good to me. Please add a test for rustdoc as well and we're good to go!

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 6, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0b0455fe:start=1549441708890022009,finish=1549441785011391743,duration=76121369734
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:07:17] 
[01:07:17] running 119 tests
[01:07:43] .iiiii...i.....i..i...i..i.i..i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i.i. 100/119
[01:07:48] i......iii.i.....ii
[01:07:48] 
[01:07:48]  finished in 31.503
[01:07:48] travis_fold:end:test_debuginfo

---
travis_time:start:test_rustdoc
Check compiletest suite=rustdoc mode=rustdoc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:11:27] 
[01:11:27] running 293 tests
[01:12:33] .........................F.iFF...............................................................F...... 100/293
[01:14:20] .............................................................................................
[01:14:20] failures:
[01:14:20] 
[01:14:20] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:502:22
[01:14:20] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:502:22
[01:14:20] ---- [rustdoc] rustdoc/deprecated-future.rs stdout ----
[01:14:20] 
[01:14:20] error: htmldocck failed!
[01:14:20] status: exit code: 1
[01:14:20] command: "/usr/bin/python2.7" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/deprecated-future" "/checkout/src/test/rustdoc/deprecated-future.rs"
[01:14:20] ------------------------------------------
[01:14:20] 
[01:14:20] ------------------------------------------
[01:14:20] stderr:
[01:14:20] stderr:
[01:14:20] ------------------------------------------
[01:14:20] 3: @has check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]  // @has deprecated_future/struct.S.html '//*[@class="stab deprecated"]' 'Deprecating in 99.99.99: effectively never'
[01:14:20] Encountered 1 errors
[01:14:20] 
[01:14:20] ------------------------------------------
[01:14:20] 
[01:14:20] 
[01:14:20] thread '[rustdoc] rustdoc/deprecated-future.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:14:20] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:14:20] 
[01:14:20] ---- [rustdoc] rustdoc/deprecated-impls.rs stdout ----
[01:14:20] 
[01:14:20] error: htmldocck failed!
[01:14:20] status: exit code: 1
[01:14:20] command: "/usr/bin/python2.7" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/deprecated-impls" "/checkout/src/test/rustdoc/deprecated-impls.rs"
[01:14:20] ------------------------------------------
[01:14:20] 
[01:14:20] ------------------------------------------
[01:14:20] stderr:
[01:14:20] stderr:
[01:14:20] ------------------------------------------
[01:14:20] 7: @has check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]      // @has - '//*[@class="stab deprecated"]' 'Deprecated since 1.0.1: fn_with_doc'
[01:14:20] 16: @has check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]      // @has - '//*[@class="stab deprecated"]' 'Deprecated since 1.0.2: fn_without_doc'
[01:14:20] 54: @has check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]      // @has - '//*[@class="stab deprecated"]' 'Deprecated since 1.0.3: fn_empty_with_doc'
[01:14:20] 62: @has check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]      // @has - '//*[@class="stab deprecated"]' 'Deprecated since 1.0.4: fn_empty_without_doc'
[01:14:20] 65: @has check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]      // @has - '//*[@class="stab deprecated"]' 'Deprecated since 1.0.5: fn_def_with_doc'
[01:14:20] 73: @has check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]      // @has - '//*[@class="stab deprecated"]' 'Deprecated since 1.0.6: fn_def_without_doc'
[01:14:20] 76: @has check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]      // @has - '//*[@class="stab deprecated"]' 'Deprecated since 1.0.7: fn_def_def_with_doc'
[01:14:20] 80: @has check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]      // @has - '//*[@class="stab deprecated"]' 'Deprecated since 1.0.8: fn_def_def_without_doc'
[01:14:20] 87: @has check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]      // @has - '//*[@class="stab deprecated"]' 'Deprecated since 1.0.3: fn_empty_with_doc'
[01:14:20] 92: @has check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]      // @has - '//*[@class="stab deprecated"]' 'Deprecated since 1.0.4: fn_empty_without_doc'
[01:14:20] 100: @has check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]      // @has - '//*[@class="stab deprecated"]' 'Deprecated since 1.0.5: fn_def_with_doc'
[01:14:20] 105: @has check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]      // @has - '//*[@class="stab deprecated"]' 'Deprecated since 1.0.6: fn_def_without_doc'
[01:14:20] 113: @has check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]      // @has - '//*[@class="stab deprecated"]' 'Deprecated since 1.0.7: fn_def_def_with_doc'
[01:14:20] 117: @has check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]      // @has - '//*[@class="stab deprecated"]' 'Deprecated since 1.0.8: fn_def_def_without_doc'
[01:14:20] Encountered 14 errors
[01:14:20] 
[01:14:20] ------------------------------------------
[01:14:20] 
[01:14:20] 
[01:14:20] thread '[rustdoc] rustdoc/deprecated-impls.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:14:20] 
[01:14:20] ---- [rustdoc] rustdoc/deprecated.rs stdout ----
[01:14:20] 
[01:14:20] error: htmldocck failed!
[01:14:20] status: exit code: 1
[01:14:20] command: "/usr/bin/python2.7" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/deprecated" "/checkout/src/test/rustdoc/deprecated.rs"
[01:14:20] ------------------------------------------
[01:14:20] 
[01:14:20] ------------------------------------------
[01:14:20] stderr:
[01:14:20] stderr:
[01:14:20] ------------------------------------------
[01:14:20] 5: @has check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]  // @has deprecated/struct.S.html '//*[@class="stab deprecated"]' 'Deprecated since 1.0.0: text'
[01:14:20] 15: @matches check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]  // @matches deprecated/struct.U.html '//*[@class="stab deprecated"]' 'Deprecated since 1.0.0$'
[01:14:20] Encountered 2 errors
[01:14:20] 
[01:14:20] ------------------------------------------
[01:14:20] 
[01:14:20] 
[01:14:20] thread '[rustdoc] rustdoc/deprecated.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:14:20] 
[01:14:20] ---- [rustdoc] rustdoc/inline_local/macro_by_example.rs stdout ----
[01:14:20] 
[01:14:20] error: htmldocck failed!
[01:14:20] status: exit code: 1
[01:14:20] command: "/usr/bin/python2.7" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/inline_local/macro_by_example" "/checkout/src/test/rustdoc/inline_local/macro_by_example.rs"
[01:14:20] ------------------------------------------
[01:14:20] 
[01:14:20] ------------------------------------------
[01:14:20] stderr:
[01:14:20] stderr:
[01:14:20] ------------------------------------------
[01:14:20] 13: @has check failed
[01:14:20]  `XPATH PATTERN` did not match
[01:14:20]      // @has - '//*[@class="stab deprecated"]' 'Deprecated since 1.2.3: text'
[01:14:20] Encountered 1 errors
[01:14:20] 
[01:14:20] ------------------------------------------
[01:14:20] 
---
[01:14:20] test result: FAILED. 287 passed; 4 failed; 2 ignored; 0 measured; 0 filtered out
[01:14:20] 
[01:14:20] 
[01:14:20] 
[01:14:20] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/rustdoc" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "rustdoc" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:14:20] 
[01:14:20] 
[01:14:20] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:14:20] Build completed unsuccessfully in 0:18:45
[01:14:20] Build completed unsuccessfully in 0:18:45
[01:14:20] Makefile:48: recipe for target 'check' failed
[01:14:20] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:04078140
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Wed Feb  6 09:44:15 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@varkor

This comment has been minimized.

Copy link
Member Author

varkor commented Feb 6, 2019

I've added a new test and updated the old one to ensure that we're checking both places the attribute can affect the docs.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 7, 2019

☔️ The latest upstream changes (presumably #58266) made this pull request unmergeable. Please resolve the merge conflicts.

@varkor varkor force-pushed the varkor:deprecated-future-external branch from e5089a7 to 18ca33b Feb 7, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 8, 2019

Thanks!

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 8, 2019

📌 Commit 18ca33b has been approved by GuillaumeGomez

@varkor varkor force-pushed the varkor:deprecated-future-external branch 2 times, most recently from a2666e8 to 241aad2 Feb 11, 2019

@varkor

This comment has been minimized.

Copy link
Member Author

varkor commented Feb 11, 2019

Added a test specifically for rustc_deprecated, as there didn't appear to be one already.

@bors r=GuillaumeGomez

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 11, 2019

📌 Commit 241aad2 has been approved by GuillaumeGomez

@varkor varkor force-pushed the varkor:deprecated-future-external branch from 241aad2 to afad118 Feb 11, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 11, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:08d6915c:start=1549885160560376841,finish=1549885268714441333,duration=108154064492
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:59:26] .................................................................................................... 500/5381
[00:59:29] ..............................i..................................................................... 600/5381
[00:59:33] .................................................................................................... 700/5381
[00:59:38] .................................................................................................... 800/5381
[00:59:43] .................................................................................i...............i.. 900/5381
[00:59:47] .....................F.............................................................................. 1000/5381
[00:59:50] .........iiiii...................................................................................... 1100/5381
[00:59:55] .................................................................................................... 1300/5381
[00:59:58] .................................................................................................... 1400/5381
[01:00:01] .................................................................................................... 1500/5381
[01:00:04] .................................................................................................... 1600/5381
---
[01:02:26] 
[01:02:26] ---- [ui] ui/deprecation/rustc_deprecation-in-future.rs stdout ----
[01:02:26] diff of stderr:
[01:02:26] 
[01:02:26] 1 error: use of item 'S' that will be deprecated in future version 99.99.99: effectively never
[01:02:26] 3    |
[01:02:26] 3    |
[01:02:26] - LL |     let _ = S; //~ ERROR  use of item 'S' that will be deprecated in future version 99.99.99: effectively never
[01:02:26] + LL |     let _ = S; //~ ERROR use of item 'S' that will be deprecated in future version 99.99.99: effectively never
[01:02:26] 6    |
[01:02:26] 6    |
[01:02:26] precation-in-future.rs","byte_start":341,"byte_end":342,"line_start":14,"line_end":14,"column_start":13,"column_end":14,"is_primary":true,"text":[{"text":"    let _ = S; //~ ERROR use of item 'S' that will be deprecated in future version 99.99.99: effectively never","highlight_start":13,"highlight_end":14}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"lint level defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/deprecation/rustc_deprecation-in-future.rs","byte_start":35,"byte_end":55,"line_start":3,"line_end":3,"column_start":9,"column_end":29,"is_primary":true,"text":[{"text":"#![deny(deprecated_in_future)]","highlight_start":9,"highlight_end":29}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"error: use of item 'S' that will be deprecated in future version 99.99.99: effectively never\n  --> /checkout/src/test/ui/deprecation/rustc_deprecation-in-future.rs:14:13\n   |\nLL |     let _ = S; //~ ERROR use of item 'S' that will be deprecated in future version 99.99.99: effectively never\n   |             ^\n   |\nnote: lint level defined here\n  --> /checkout/src/test/ui/deprecation/rustc_deprecation-in-future.rs:3:9\n   |\nLL | #![deny(deprecated_in_future)]\n   |         ^^^^^^^^^^^^^^^^^^^^\n\n"}
[01:02:26] 
[01:02:26] ------------------------------------------
[01:02:26] 
[01:02:26] thread '[ui] ui/deprecation/rustc_deprecation-in-future.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
---
[01:02:26] 
[01:02:26] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:02:26] 
[01:02:26] 
[01:02:26] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:02:26] 
[01:02:26] 
[01:02:26] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:02:26] Build completed unsuccessfully in 0:04:16
[01:02:26] Build completed unsuccessfully in 0:04:16
[01:02:26] Makefile:48: recipe for target 'check' failed
[01:02:26] make: *** [check] Error 1
2651656 ./obj
2651616 ./obj/build
1980992 ./obj/build/x86_64-unknown-linux-gnu
1346608 ./src
---
151304 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu
151300 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release
147808 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps
141200 ./obj/build/bootstrap/debug/incremental/bootstrap-2ahv8almm435e
141196 ./obj/build/bootstrap/debug/incremental/bootstrap-2ahv8almm435e/s-f9dzj1r959-z5nhvo-170x7pprjykmo
137064 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release
134288 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps
123292 ./src/llvm-project/llvm/test/CodeGen
108528 ./src/llvm-project/lldb

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@varkor varkor force-pushed the varkor:deprecated-future-external branch from afad118 to b5fa870 Feb 11, 2019

@varkor

This comment has been minimized.

Copy link
Member Author

varkor commented Feb 11, 2019

@bors r=GuillaumeGomez

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 11, 2019

📌 Commit b5fa870 has been approved by GuillaumeGomez

Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019

Rollup merge of rust-lang#58202 - varkor:deprecated-future-external, …
…r=GuillaumeGomez

Ignore future deprecations in #[deprecated]

The future deprecation warnings should only apply to `#[rustc_deprecated]` as they take into account rustc's version. Fixes rust-lang#57952.

I've also slightly modified rustdoc's display of future deprecation notices to make it more consistent, so I'm assigning a rustdoc team member for review to make sure this is okay.

r? @GuillaumeGomez

Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019

Rollup merge of rust-lang#58202 - varkor:deprecated-future-external, …
…r=GuillaumeGomez

Ignore future deprecations in #[deprecated]

The future deprecation warnings should only apply to `#[rustc_deprecated]` as they take into account rustc's version. Fixes rust-lang#57952.

I've also slightly modified rustdoc's display of future deprecation notices to make it more consistent, so I'm assigning a rustdoc team member for review to make sure this is okay.

r? @GuillaumeGomez

bors added a commit that referenced this pull request Feb 13, 2019

Auto merge of #58428 - Centril:rollup, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #58110 (libpanic_unwind => 2018)
 - #58167 (HirId-ify hir::BodyId)
 - #58202 (Ignore future deprecations in #[deprecated])
 - #58272 (Cut down on number formating code size)
 - #58276 (Improve the error messages for missing stability attributes)
 - #58354 (Fix ICE and invalid filenames in MIR printing code)
 - #58381 (Only suggest imports if not imported.)
 - #58386 (Fix #54242)
 - #58400 (Fix rustc_driver swallowing errors when compilation is stopped)
 - #58420 (target/uefi: clarify documentation)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019

Rollup merge of rust-lang#58202 - varkor:deprecated-future-external, …
…r=GuillaumeGomez

Ignore future deprecations in #[deprecated]

The future deprecation warnings should only apply to `#[rustc_deprecated]` as they take into account rustc's version. Fixes rust-lang#57952.

I've also slightly modified rustdoc's display of future deprecation notices to make it more consistent, so I'm assigning a rustdoc team member for review to make sure this is okay.

r? @GuillaumeGomez

bors added a commit that referenced this pull request Feb 13, 2019

Auto merge of #58432 - Centril:rollup, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #58110 (libpanic_unwind => 2018)
 - #58167 (HirId-ify hir::BodyId)
 - #58202 (Ignore future deprecations in #[deprecated])
 - #58272 (Cut down on number formating code size)
 - #58276 (Improve the error messages for missing stability attributes)
 - #58354 (Fix ICE and invalid filenames in MIR printing code)
 - #58381 (Only suggest imports if not imported.)
 - #58386 (Fix #54242)
 - #58400 (Fix rustc_driver swallowing errors when compilation is stopped)
 - #58420 (target/uefi: clarify documentation)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Feb 13, 2019

Auto merge of #58432 - Centril:rollup, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #58110 (libpanic_unwind => 2018)
 - #58167 (HirId-ify hir::BodyId)
 - #58202 (Ignore future deprecations in #[deprecated])
 - #58272 (Cut down on number formating code size)
 - #58276 (Improve the error messages for missing stability attributes)
 - #58354 (Fix ICE and invalid filenames in MIR printing code)
 - #58381 (Only suggest imports if not imported.)
 - #58386 (Fix #54242)
 - #58400 (Fix rustc_driver swallowing errors when compilation is stopped)
 - #58420 (target/uefi: clarify documentation)

Failed merges:

r? @ghost

@bors bors merged commit b5fa870 into rust-lang:master Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment