New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the error messages for missing stability attributes #58276

Merged
merged 3 commits into from Feb 14, 2019

Conversation

Projects
None yet
4 participants
@varkor
Copy link
Member

varkor commented Feb 7, 2019

This makes the capitalisation consistent and provides more context (especially for missing top-level attributes).

Improve the error messages for missing stability attributes
This makes the capitalisation consistent and provides more context (especially for missing top-level attributes).
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 7, 2019

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@davidtwco
Copy link
Member

davidtwco left a comment

LGTM. Minor nit below, feel free to fix or just r=me.

_ => self.check_missing_stability(i.id, i.span)
hir::ItemKind::Mod(..) => self.check_missing_stability(i.id, i.span, "module"),

_ => self.check_missing_stability(i.id, i.span, "node")

This comment has been minimized.

@davidtwco

davidtwco Feb 8, 2019

Member

Using i.node.descriptive_variant() might be better than specifying a name manually. Not sure if there is an equivalent for the other functions.

varkor added some commits Feb 8, 2019

@varkor

This comment has been minimized.

Copy link
Member Author

varkor commented Feb 8, 2019

@bors r=davidtwco

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 8, 2019

📌 Commit bb1eed0 has been approved by davidtwco

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Feb 10, 2019

Rollup merge of rust-lang#58276 - varkor:missing-stability-attr-top-l…
…evel, r=davidtwco

Improve the error messages for missing stability attributes

This makes the capitalisation consistent and provides more context (especially for missing top-level attributes).

bors added a commit that referenced this pull request Feb 10, 2019

Auto merge of #58338 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 17 pull requests

Successful merges:

 - #57259 (Update reference of rlibc crate to compiler-builtins crate)
 - #57740 (Use `to_ne_bytes` for converting IPv4Addr to octets)
 - #58085 (Implement more detailed self profiling)
 - #58103 (Make -Zdump-mir dump shims)
 - #58129 (MaybeUninit: some docs, rename into_inner -> into_initialized, return &mut from set)
 - #58151 (Partially HirId-ify rustc)
 - #58152 (Partially HirIdify mir)
 - #58153 (Partially Hiridify typeck)
 - #58203 (rustdoc: display sugared return types for async functions)
 - #58258 (Reduce the size of `hir::Expr`.)
 - #58262 (Add #[must_use] message to Fn* traits)
 - #58272 (Cut down on number formating code size)
 - #58276 (Improve the error messages for missing stability attributes)
 - #58295 (std::sys::unix::stdio: explain why we do into_raw)
 - #58297 (Cleanup JS a bit)
 - #58300 (librustc_typeck => 2018)
 - #58332 (operand-to-place copies should never be overlapping)

Failed merges:

 - #58167 (HirId-ify hir::BodyId)

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019

Rollup merge of rust-lang#58276 - varkor:missing-stability-attr-top-l…
…evel, r=davidtwco

Improve the error messages for missing stability attributes

This makes the capitalisation consistent and provides more context (especially for missing top-level attributes).

Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019

Rollup merge of rust-lang#58276 - varkor:missing-stability-attr-top-l…
…evel, r=davidtwco

Improve the error messages for missing stability attributes

This makes the capitalisation consistent and provides more context (especially for missing top-level attributes).

bors added a commit that referenced this pull request Feb 13, 2019

Auto merge of #58428 - Centril:rollup, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #58110 (libpanic_unwind => 2018)
 - #58167 (HirId-ify hir::BodyId)
 - #58202 (Ignore future deprecations in #[deprecated])
 - #58272 (Cut down on number formating code size)
 - #58276 (Improve the error messages for missing stability attributes)
 - #58354 (Fix ICE and invalid filenames in MIR printing code)
 - #58381 (Only suggest imports if not imported.)
 - #58386 (Fix #54242)
 - #58400 (Fix rustc_driver swallowing errors when compilation is stopped)
 - #58420 (target/uefi: clarify documentation)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019

Rollup merge of rust-lang#58276 - varkor:missing-stability-attr-top-l…
…evel, r=davidtwco

Improve the error messages for missing stability attributes

This makes the capitalisation consistent and provides more context (especially for missing top-level attributes).

bors added a commit that referenced this pull request Feb 13, 2019

Auto merge of #58432 - Centril:rollup, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #58110 (libpanic_unwind => 2018)
 - #58167 (HirId-ify hir::BodyId)
 - #58202 (Ignore future deprecations in #[deprecated])
 - #58272 (Cut down on number formating code size)
 - #58276 (Improve the error messages for missing stability attributes)
 - #58354 (Fix ICE and invalid filenames in MIR printing code)
 - #58381 (Only suggest imports if not imported.)
 - #58386 (Fix #54242)
 - #58400 (Fix rustc_driver swallowing errors when compilation is stopped)
 - #58420 (target/uefi: clarify documentation)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Feb 13, 2019

Auto merge of #58432 - Centril:rollup, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #58110 (libpanic_unwind => 2018)
 - #58167 (HirId-ify hir::BodyId)
 - #58202 (Ignore future deprecations in #[deprecated])
 - #58272 (Cut down on number formating code size)
 - #58276 (Improve the error messages for missing stability attributes)
 - #58354 (Fix ICE and invalid filenames in MIR printing code)
 - #58381 (Only suggest imports if not imported.)
 - #58386 (Fix #54242)
 - #58400 (Fix rustc_driver swallowing errors when compilation is stopped)
 - #58420 (target/uefi: clarify documentation)

Failed merges:

r? @ghost

@bors bors merged commit bb1eed0 into rust-lang:master Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment