New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libstd => 2018 #58208

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@taiki-e
Copy link
Contributor

taiki-e commented Feb 6, 2019

Transitions libstd to Rust 2018; cc #58099

r? @Centril

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 6, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:050047e5:start=1549425809935218963,finish=1549425812322263801,duration=2387044838
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:04:26]    Compiling alloc v0.0.0 (/checkout/src/liballoc)
[00:04:26]    Compiling panic_abort v0.0.0 (/checkout/src/libpanic_abort)
[00:04:26]    Compiling rustc-demangle v0.1.10
[00:04:31]    Compiling panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[00:04:32] error: extern crate `libc` is private, and cannot be re-exported (error E0365), consider declaring with `pub`
[00:04:32]   --> src/libstd/sys/unix/net.rs:15:9
[00:04:32]    |
[00:04:32] 15 | pub use libc as netc;
[00:04:32]    |
[00:04:32]    |
[00:04:32]    = note: #[deny(pub_use_of_private_extern_crate)] on by default
[00:04:32]    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[00:04:32] 
2752840 .
1346352 ./src
1313156 ./obj
---
199364 ./obj/build/cache/2019-01-18
156148 ./src/llvm-project/clang
155464 ./obj/build/bootstrap/debug/incremental
140688 ./obj/build/bootstrap/debug/incremental/bootstrap-2ahv8almm435e
140684 ./obj/build/bootstrap/debug/incremental/bootstrap-2ahv8almm435e/s-f984glc7ym-16gm6th-1rhegn0zm30b4
108528 ./src/llvm-project/lldb
97552 ./src/llvm-project/clang/test
92608 ./.git
89964 ./src/llvm-emscripten/test/CodeGen

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@taiki-e taiki-e force-pushed the taiki-e:libstd-2018 branch from d69f82e to 9dea49e Feb 6, 2019

@@ -211,6 +211,10 @@
#![deny(intra_doc_link_resolution_failure)]
#![deny(missing_debug_implementations)]

#![deny(rust_2018_idioms)]
#![allow(explicit_outlives_requirements)]
#![allow(elided_lifetimes_in_paths)]

This comment has been minimized.

@taiki-e

taiki-e Feb 6, 2019

Author Contributor

It is hard work to change all at once (and review it), so elided_lifetimes_in_paths is allowed.

I will work on it after this PR is merged.

This comment has been minimized.

@Centril

Centril Feb 6, 2019

Contributor

That sounds like a good idea; I think we want to keep #![allow(explicit_outlives_requirements)] around for this crate.

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 6, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:2731df7c:start=1549430160354441515,finish=1549430163473658323,duration=3119216808
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:58:33]     Checking rustc_asan v0.0.0 (/checkout/src/librustc_asan)
[00:58:33]     Checking rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[00:58:33]     Checking rustc_lsan v0.0.0 (/checkout/src/librustc_lsan)
[00:58:33]  Documenting std v0.0.0 (/checkout/src/libstd)
[00:58:37] error: internal compiler error: src/librustc/hir/def.rs:258: attempted .def_id() on invalid def: NonMacroAttr(Builtin)
[00:58:37] thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:605:9
[00:58:37] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[00:58:38] 
[00:58:38] error: Unrecognized option: 'markdown-css'
[00:58:38] error: Unrecognized option: 'markdown-css'
[00:58:38] 
[00:58:38] error: Could not document `std`.
[00:58:38] 
[00:58:38] Caused by:
[00:58:38]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2018 --crate-name std src/libstd/lib.rs --color always --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/doc --cfg 'feature="backtrace"' --cfg 'feature="backtrace-sys"' --cfg 'feature="compiler_builtins"' --cfg 'feature="compiler_builtins_c"' --cfg 'feature="default"' --cfg 'feature="panic-unwind"' --cfg 'feature="panic_unwind"' --markdown-css rust.css --markdown-no-toc --index-page /checkout/src/doc/index.md -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps --extern alloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liballoc-9e6c0311b71511c6.rmeta --extern backtrace_sys=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libbacktrace_sys-f13b165ed9b4dd57.rmeta --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcompiler_builtins-d54fe968dea87029.rmeta --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcore-84e5b9599b1b7754.rmeta --extern libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liblibc-a69fda92b07aedd5.rmeta --extern panic_abort=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libpanic_abort-349a3e5cce9f18ee.rmeta --extern panic_unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libpanic_unwind-d7c48504ff1056b6.rmeta --extern rustc_demangle=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_demangle-20814bca47e9a554.rmeta --extern rustc_asan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_asan-8bc4c4bf1d4ec8f0.rmeta --extern rustc_lsan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_lsan-0814373332ff833c.rmeta --extern rustc_msan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_msan-655667bc8a1522d0.rmeta --extern rustc_tsan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_tsan-5756fbda854daecf.rmeta --extern unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libunwind-5e31c590860d0940.rmeta` (exit code: 1)
[00:58:38] 
[00:58:38] 
[00:58:38] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustdoc" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-Z" "unstable-options" "-p" "std" "--" "--markdown-css" "rust.css" "--markdown-no-toc" "--index-page" "/checkout/src/doc/index.md"
[00:58:38] 
[00:58:38] 
[00:58:38] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap doc
[00:58:38] Build completed unsuccessfully in 0:06:04
[00:58:38] Build completed unsuccessfully in 0:06:04
[00:58:38] Makefile:18: recipe for target 'all' failed
[00:58:38] make: *** [all] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:32958cb5
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Wed Feb  6 06:14:52 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@taiki-e

This comment has been minimized.

Copy link
Contributor Author

taiki-e commented Feb 6, 2019

I think this error is very similar to the error that occurred in #58110.

@Centril

Centril approved these changes Feb 8, 2019

Copy link
Contributor

Centril left a comment

Modulo the ICE, everything looks good.

@taiki-e

This comment has been minimized.

Copy link
Contributor Author

taiki-e commented Feb 8, 2019

libstd has many codes depending on each target. Since testing with PR is done only on some targets, there may be an oversight somewhere. I think the first test on the auto branch may fail (If errors are found, I will fix it immediately).

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Feb 8, 2019

This is an ICE that was fixed in #58058 if I'm not mistaken.

@taiki-e

This comment has been minimized.

Copy link
Contributor Author

taiki-e commented Feb 8, 2019

This is an ICE that was fixed in #58058 if I'm not mistaken.

Thanks for the info!

@taiki-e taiki-e force-pushed the taiki-e:libstd-2018 branch from cf4b73c to 88da225 Feb 8, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 8, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:03950d87:start=1549608425122404099,finish=1549608427479329176,duration=2356925077
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[01:00:29]     Checking term v0.0.0 (/checkout/src/libterm)
[01:00:29]     Checking getopts v0.2.17
[01:00:29]     Checking proc_macro v0.0.0 (/checkout/src/libproc_macro)
[01:00:33]  Documenting test v0.0.0 (/checkout/src/libtest)
[01:00:33] error: internal compiler error: src/librustc/hir/def.rs:258: attempted .def_id() on invalid def: NonMacroAttr(Builtin)
[01:00:33] thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:595:9
[01:00:33] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:00:33] 
[01:00:33] error: Unrecognized option: 'crate-version'
[01:00:33] error: Unrecognized option: 'crate-version'
[01:00:33] 
[01:00:33] error: Could not document `test`.
[01:00:33] 
[01:00:33] Caused by:
[01:00:33]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2018 --crate-name test src/libtest/lib.rs --color always --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/doc -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/release/deps --extern getopts=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libgetopts-2cd31f015e79e3a8.rmeta --extern proc_macro=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libproc_macro-9b2503eb72968b11.rmeta --extern term=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libterm-0bd89f567a02c34d.rmeta` (exit code: 1)
[01:00:33] 
[01:00:33] 
[01:00:33] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "doc" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "--no-deps" "-p" "test"
[01:00:33] 
[01:00:33] 
[01:00:33] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap doc
[01:00:33] Build completed unsuccessfully in 0:06:44
[01:00:33] Build completed unsuccessfully in 0:06:44
[01:00:33] make: *** [all] Error 1
[01:00:33] Makefile:18: recipe for target 'all' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:01aa0758
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Feb  8 07:47:51 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 8, 2019

@taiki-e seems your rebase went a bit wrong... :)

@taiki-e taiki-e force-pushed the taiki-e:libstd-2018 branch from 88da225 to 0ed2442 Feb 8, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 8, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:11a24972:start=1549621213132329780,finish=1549621215707190484,duration=2574860704
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:57:06]     Checking term v0.0.0 (/checkout/src/libterm)
[00:57:06]     Checking proc_macro v0.0.0 (/checkout/src/libproc_macro)
[00:57:06]     Checking getopts v0.2.17
[00:57:09]  Documenting test v0.0.0 (/checkout/src/libtest)
[00:57:09] error: internal compiler error: src/librustc/hir/def.rs:259: attempted .def_id() on invalid def: NonMacroAttr(Builtin)
[00:57:09] thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:595:9
[00:57:09] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[00:57:09] 
[00:57:09] error: Unrecognized option: 'crate-version'
[00:57:09] error: Unrecognized option: 'crate-version'
[00:57:09] 
[00:57:09] error: Could not document `test`.
[00:57:09] 
[00:57:09] Caused by:
[00:57:09]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2018 --crate-name test src/libtest/lib.rs --color always --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/doc -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/release/deps --extern getopts=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libgetopts-2cd31f015e79e3a8.rmeta --extern proc_macro=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libproc_macro-9b2503eb72968b11.rmeta --extern term=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libterm-0bd89f567a02c34d.rmeta` (exit code: 1)
[00:57:09] 
[00:57:09] 
[00:57:09] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "doc" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "--no-deps" "-p" "test"
[00:57:09] 
[00:57:09] 
[00:57:09] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap doc
[00:57:09] Build completed unsuccessfully in 0:06:13
[00:57:09] Build completed unsuccessfully in 0:06:13
[00:57:09] make: *** [all] Error 1
[00:57:09] Makefile:18: recipe for target 'all' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0515b050
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Feb  8 11:17:35 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@taiki-e

This comment has been minimized.

Copy link
Contributor Author

taiki-e commented Feb 8, 2019

@Centril Would you please rebase #58110?

#58253 has similar ICE too , so I would like to gather information from other PRs that have similar ICE.
Currently I do not know if this is a problem unique to my PRs...

@taiki-e taiki-e force-pushed the taiki-e:libstd-2018 branch from 0ed2442 to fdb4461 Feb 9, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 9, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0fc098e8:start=1549720053422350649,finish=1549720055811490030,duration=2389139381
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:57:43]     Checking proc_macro v0.0.0 (/checkout/src/libproc_macro)
[00:57:43]     Checking term v0.0.0 (/checkout/src/libterm)
[00:57:43]     Checking getopts v0.2.17
[00:57:47]  Documenting test v0.0.0 (/checkout/src/libtest)
[00:57:47] error: internal compiler error: src/librustc/hir/def.rs:259: attempted .def_id() on invalid def: NonMacroAttr(Builtin)
[00:57:47] thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:595:9
[00:57:47] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[00:57:47] 
[00:57:47] error: Unrecognized option: 'crate-version'
[00:57:47] error: Unrecognized option: 'crate-version'
[00:57:47] 
[00:57:47] error: Could not document `test`.
[00:57:47] 
[00:57:47] Caused by:
[00:57:47]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2018 --crate-name test src/libtest/lib.rs --color always --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/doc -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/release/deps --extern getopts=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libgetopts-2cd31f015e79e3a8.rmeta --extern proc_macro=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libproc_macro-9b2503eb72968b11.rmeta --extern term=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libterm-0bd89f567a02c34d.rmeta` (exit code: 1)
[00:57:47] 
[00:57:47] 
[00:57:47] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "doc" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "--no-deps" "-p" "test"
[00:57:47] 
[00:57:47] 
[00:57:47] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap doc
[00:57:47] Build completed unsuccessfully in 0:06:24
[00:57:47] Build completed unsuccessfully in 0:06:24
[00:57:47] make: *** [all] Error 1
[00:57:47] Makefile:18: recipe for target 'all' failed
travis_time:end:337bebf0:start=1549723535289633227,finish=1549723535455143089,duration=165509862
The command "date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
" exited with 0.
travis_fold:start:after_failure.1
---
travis_time:end:07ce7ff0:start=1549723536304656546,finish=1549723536311066176,duration=6409630
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:097d93e6
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf tra

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@taiki-e taiki-e force-pushed the taiki-e:libstd-2018 branch from fdb4461 to 56bb17b Feb 10, 2019

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Feb 10, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:033313b0:start=1549827015950859489,finish=1549827018560751280,duration=2609891791
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:56:07]     Checking term v0.0.0 (/checkout/src/libterm)
[00:56:07]     Checking getopts v0.2.17
[00:56:07]     Checking proc_macro v0.0.0 (/checkout/src/libproc_macro)
[00:56:11]  Documenting test v0.0.0 (/checkout/src/libtest)
[00:56:11] error: internal compiler error: src/librustc/hir/def.rs:259: attempted .def_id() on invalid def: NonMacroAttr(Builtin)
[00:56:11] thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:595:9
[00:56:11] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[00:56:11] 
[00:56:11] error: Unrecognized option: 'crate-version'
[00:56:11] error: Unrecognized option: 'crate-version'
[00:56:11] 
[00:56:11] error: Could not document `test`.
[00:56:11] 
[00:56:11] Caused by:
[00:56:11]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2018 --crate-name test src/libtest/lib.rs --color always --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/doc -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/release/deps --extern getopts=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libgetopts-2cd31f015e79e3a8.rmeta --extern proc_macro=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libproc_macro-9b2503eb72968b11.rmeta --extern term=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libterm-0bd89f567a02c34d.rmeta` (exit code: 1)
[00:56:11] 
[00:56:11] 
[00:56:11] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "doc" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "--no-deps" "-p" "test"
[00:56:11] 
[00:56:11] 
[00:56:11] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap doc
[00:56:11] Build completed unsuccessfully in 0:06:22
[00:56:11] Build completed unsuccessfully in 0:06:22
[00:56:11] make: *** [all] Error 1
[00:56:11] Makefile:18: recipe for target 'all' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:05fa7902
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Feb 10 20:26:40 UTC 2019
---
travis_time:end:041324dd:start=1549830401909376098,finish=1549830401914822768,duration=5446670
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:05cd9178
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travi

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril Centril referenced this pull request Feb 11, 2019

Open

Tracking issue for Transitioning crates to Rust 2018 #58099

72 of 77 tasks complete
@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 11, 2019

@taiki-e Will do now that I'm back from All Hands... :)

@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Feb 12, 2019

☔️ The latest upstream changes (presumably #58098) made this pull request unmergeable. Please resolve the merge conflicts.

@taiki-e taiki-e force-pushed the taiki-e:libstd-2018 branch from 56bb17b to 55da078 Feb 12, 2019

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Feb 12, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0ee0b13e:start=1549986021201989431,finish=1549986024525614630,duration=3323625199
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:59:13]     Checking term v0.0.0 (/checkout/src/libterm)
[00:59:13]     Checking proc_macro v0.0.0 (/checkout/src/libproc_macro)
[00:59:13]     Checking getopts v0.2.17
[00:59:17]  Documenting test v0.0.0 (/checkout/src/libtest)
[00:59:17] error: internal compiler error: src/librustc/hir/def.rs:259: attempted .def_id() on invalid def: NonMacroAttr(Builtin)
[00:59:17] thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:596:9
[00:59:17] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[00:59:17] 
[00:59:17] error: Unrecognized option: 'crate-version'
[00:59:17] error: Unrecognized option: 'crate-version'
[00:59:17] 
[00:59:17] error: Could not document `test`.
[00:59:17] 
[00:59:17] Caused by:
[00:59:17]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2018 --crate-name test src/libtest/lib.rs --color always --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/doc -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/release/deps --extern getopts=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libgetopts-2cd31f015e79e3a8.rmeta --extern proc_macro=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libproc_macro-9b2503eb72968b11.rmeta --extern term=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-test/x86_64-unknown-linux-gnu/release/deps/libterm-0bd89f567a02c34d.rmeta` (exit code: 1)
[00:59:17] 
[00:59:17] 
[00:59:17] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "doc" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "--no-deps" "-p" "test"
[00:59:17] 
[00:59:17] 
[00:59:17] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap doc
[00:59:17] Build completed unsuccessfully in 0:06:26
[00:59:17] Build completed unsuccessfully in 0:06:26
[00:59:17] Makefile:18: recipe for target 'all' failed
[00:59:17] make: *** [all] Error 1
The command "date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
" exited with 0.
travis_fold:start:after_failure.1
travis_time:start:08ad7515
---
travis_time:end:020de3f8:start=1549989594107516937,finish=1549989594122592532,duration=15075595
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:009622d1
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:06974c0d
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Feb 13, 2019

☔️ The latest upstream changes (presumably #58235) made this pull request unmergeable. Please resolve the merge conflicts.

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 14, 2019

@taiki-e Try to rebase now and let's see what happens... :)

@taiki-e taiki-e force-pushed the taiki-e:libstd-2018 branch from 55da078 to 2b2e349 Feb 14, 2019

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Feb 14, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:21ce513a:start=1550120216135209234,finish=1550120218453186266,duration=2317977032
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:59:57] .................................................................................................... 1400/5386
[01:00:00] .................................................................................................... 1500/5386
[01:00:03] .................................................................................................... 1600/5386
[01:00:06] ...i..........................................................................i..................... 1700/5386
[01:00:09] ......F............................................................................................. 1800/5386
[01:00:17] .................................................................................................... 2000/5386
[01:00:20] ...................................i................................................................ 2100/5386
[01:00:24] .................................................................................................... 2200/5386
[01:00:28] .................................................................................................... 2300/5386
---
[01:01:57] ..................................i................................................................. 4600/5386
[01:02:03] .................................................................................................... 4700/5386
[01:02:07] .................................................................................................... 4800/5386
[01:02:10] .................................................................................................... 4900/5386
[01:02:14] ..............................F..................................................................... 5000/5386
[01:02:21] .................................................................................................... 5200/5386
[01:02:24] .................................................................................................... 5300/5386
[01:02:26] .........................i............................................................
[01:02:26] failures:
[01:02:26] failures:
[01:02:26] 
[01:02:26] ---- [ui] ui/hygiene/no_implicit_prelude.rs stdout ----
[01:02:26] diff of stderr:
[01:02:26] 
[01:02:26] 7 LL |         Vec::new(); //~ ERROR failed to resolve
[01:02:26] 8    |         ^^^ use of undeclared type or module `Vec`
[01:02:26] 9 
[01:02:26] + error: cannot find macro `print!` in this scope
[01:02:26] +   --> $DIR/no_implicit_prelude.rs:16:9
[01:02:26] +    |
[01:02:26] + LL |         println!(); // OK on 2015 edition (at least for now)
[01:02:26] +    |
[01:02:26] +    |
[01:02:26] +    = help: have you added the `#[macro_use]` on the module/import?
[01:02:26] + 
[01:02:26] + 
[01:02:26] 10 error[E0599]: no method named `clone` found for type `()` in the current scope
[01:02:26] 11   --> $DIR/no_implicit_prelude.rs:12:12
[01:02:26] 
[01:02:26] 20    = note: the following trait is implemented but not in scope, perhaps add a `use` for it:
[01:02:26] 21            `use std::clone::Clone;`
[01:02:26] 22 
---
[01:02:26] 26 For more information about an error, try `rustc --explain E0433`.
[01:02:26] 
[01:02:26] 
[01:02:26] The actual stderr differed from the expected stderr.
[01:02:26] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/hygiene/no_implicit_prelude/no_implicit_prelude.stderr
[01:02:26] To update references, rerun the tests and pass the `--bless` flag
[01:02:26] To only update this specific test, also pass `--test-args hygiene/no_implicit_prelude.rs`
[01:02:26] error: 1 errors occurred comparing output.
[01:02:26] status: exit code: 1
[01:02:26] status: exit code: 1
[01:02:26] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/hygiene/no_implicit_prelude.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/hygiene/no_implicit_prelude/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/hygiene/no_implicit_prelude/auxiliary" "-A" "unused"
[01:02:26] ------------------------------------------
[01:02:26] 
[01:02:26] ------------------------------------------
[01:02:26] stderr:
[01:02:26] stderr:
[01:02:26] ------------------------------------------
[01:02:26] {"message":"failed to resolve: use of undeclared type or module `Vec`","code":{"code":"E0433","explanation":"\nAn undeclared type or module was used.\n\nErroneous code example:\n\n```compile_fail,E0433\nlet map = HashMap::new();\n// error: failed to resolve: use of undeclared type or module `HashMap`\n```\n\nPlease verify you didn't misspell the type/module's name or that you didn't\nforget to import it:\n\n\n```\nuse std::collections::HashMap; // HashMap has been imported.\nlet map: HashMap<u32, u32> = HashMap::new(); // So it can be used!\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/hygiene/no_implicit_prelude.rs","byte_start":172,"byte_end":175,"line_start":11,"line_end":11,"column_start":9,"column_end":12,"is_primary":true,"text":[{"text":"        Vec::new(); //~ ERROR failed to resolve","highlight_start":9,"highlight_end":12}],"label":"use of undeclared type or module `Vec`","suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"/checkout/src/test/ui/hygiene/no_implicit_prelude.rs","byte_start":93,"byte_end":105,"line_start":5,"line_end":5,"column_start":14,"column_end":26,"is_primary":false,"text":[{"text":"    fn f() { ::bar::m!(); }","highlight_start":14,"highlight_end":26}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"::bar::m!","def_site_span":{"file_name":"/checkout/src/test/ui/hygiene/no_implicit_prelude.rs","byte_start":148,"byte_end":276,"line_start":10,"line_end":13,"column_start":5,"column_end":6,"is_primary":false,"text":[{"text":"    pub macro m() {","highlight_start":5,"highlight_end":20},{"text":"        Vec::new(); //~ ERROR failed to resolve","highlight_start":1,"highlight_end":48},{"text":"        ().clone() //~ ERROR no method named `clone` found","highlight_start":1,"highlight_end":59},{"text":"    }","highlight_start":1,"highlight_end":6}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[],"rendered":"error[E0433]: failed to resolve: use of undeclared type or module `Vec`\n  --> /checkout/src/test/ui/hygiene/no_implicit_prelude.rs:11:9\n   |\nLL |     fn f() { ::bar::m!(); }\n   |              ------------ in this macro invocation\n...\nLL |         Vec::new(); //~ ERROR failed to resolve\n   |         ^^^ use of undeclared type or module `Vec`\n\n"}
[01:02:26] {"message":"cannot find macro `print!` in this scope","code":null,"level":"error","spans":[{"file_name":"<::std::macros::println macros>","byte_start":10,"byte_end":15,"line_start":1,"line_end":1,"column_start":11,"column_end":16,"is_primary":true,"text":[{"text":"(  ) => ( print ! ( \"\\n\" ) ) ; ( $ ( $ arg : tt ) * ) => (","highlight_start":11,"highlight_end":16}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"/checkout/src/test/ui/hygiene/no_implicit_prelude.rs","byte_start":319,"byte_end":330,"line_start":16,"line_end":16,"column_start":9,"column_end":20,"is_primary":false,"text":[{"text":"        println!(); // OK on 2015 edition (at least for now)","highlight_start":9,"highlight_end":20}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"println!","def_site_span":{"file_name":"<::std::macros::println macros>","byte_start":0,"byte_end":129,"line_start":1,"line_end":2,"column_start":1,"column_end":71,"is_primary":false,"text":[{"text":"(  ) => ( print ! ( \"\\n\" ) ) ; ( $ ( $ arg : tt ) * ) => (","highlight_start":1,"highlight_end":59},{"text":"{ $ crate :: io :: _print ( format_args_nl ! ( $ ( $ arg ) * ) ) ; } )","highlight_start":1,"highlight_end":71}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[{"message":"have you added the `#[macro_use]` on the module/import?","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: cannot find macro `print!` in this scope\n  --> /checkout/src/test/ui/hygiene/no_implicit_prelude.rs:16:9\n   |\nLL |         println!(); // OK on 2015 edition (at least for now)\n   |         ^^^^^^^^^^^\n   |\n   = help: have you added the `#[macro_use]` on the module/import?\n   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)\n\n"}
[01:02:26] {"message":"no method named `clone` found for type `()` in the current scope","code":{"code":"E0599","explanation":"\nThis error occurs when a method is used on a type which doesn't implement it:\n\nErroneous code example:\n\n```compile_fail,E0599\nstruct Mouth;\n\nlet x = Mouth;\nx.chocolate(); // error: no method named `chocolate` found for type `Mouth`\n               //        in the current scope\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/hygiene/no_implicit_prelude.rs","byte_start":223,"byte_end":228,"line_start":12,"line_end":12,"column_start":12,"column_end":17,"is_primary":true,"text":[{"text":"        ().clone() //~ ERROR no method named `clone` found","highlight_start":12,"highlight_end":17}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"/checkout/src/test/ui/hygiene/no_implicit_prelude.rs","byte_start":93,"byte_end":105,"line_start":5,"line_end":5,"column_start":14,"column_end":26,"is_primary":false,"text":[{"text":"    fn f() { ::bar::m!(); }","highlight_start":14,"highlight_end":26}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"::bar::m!","def_site_span":{"file_name":"/checkout/src/test/ui/hygiene/no_implicit_prelude.rs","byte_start":148,"byte_end":276,"line_start":10,"line_end":13,"column_start":5,"column_end":6,"is_primary":false,"text":[{"text":"    pub macro m() {","highlight_start":5,"highlight_end":20},{"text":"        Vec::new(); //~ ERROR failed to resolve","highlight_start":1,"highlight_end":48},{"text":"        ().clone() //~ ERROR no method named `clone` found","highlight_start":1,"highlight_end":59},{"text":"    }","highlight_start":1,"highlight_end":6}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[{"message":"items from traits can only be used if the trait is in scope","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"the following trait is implemented but not in scope, perhaps add a `use` for it:\n`use std::clone::Clone;`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0599]: no method named `clone` found for type `()` in the current scope\n  --> /checkout/src/test/ui/hygiene/no_implicit_prelude.rs:12:12\n   |\nLL |     fn f() { ::bar::m!(); }\n   |              ------------ in this macro invocation\n...\nLL |         ().clone() //~ ERROR no method named `clone` found\n   |            ^^^^^\n   |\n   = help: items from traits can only be used if the trait is in scope\n   = note: the following trait is implemented but not in scope, perhaps add a `use` for it:\n           `use std::clone::Clone;`\n\n"}
[01:02:26] {"message":"aborting due to 3 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 3 previous errors\n\n"}
[01:02:26] {"message":"Some errors occurred: E0433, E0599.","code":null,"level":"","spans":[],"children":[],"rendered":"Some errors occurred: E0433, E0599.\n"}
[01:02:26] 
[01:02:26] ------------------------------------------
[01:02:26] 
[01:02:26] thread '[ui] ui/hygiene/no_implicit_prelude.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:02:26] thread '[ui] ui/hygiene/no_implicit_prelude.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:02:26] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:02:26] 
[01:02:26] ---- [ui] ui/tag-that-dare-not-speak-its-name.rs stdout ----
[01:02:26] diff of stderr:
[01:02:26] 
[01:02:26] + error: cannot find macro `panic!` in this scope
[01:02:26] +    |
[01:02:26] + LL |     panic!();
[01:02:26] +    |     ^^^^^^^^^
[01:02:26] +    |
[01:02:26] +    |
[01:02:26] +    = help: have you added the `#[macro_use]` on the module/import?
[01:02:26] + 
[01:02:26] 1 error[E0308]: mismatched types
[01:02:26] +   --> $DIR/tag-that-dare-not-speak-its-name.rs:6:28
[01:02:26] +    |
[01:02:26] +    |
[01:02:26] + LL | fn last<T>(v: Vec<&T> ) -> std::option::Option<T> {
[01:02:26] +    |    ----                    ^^^^^^^^^^^^^^^^^^^^^^ expected enum `std::option::Option`, found ()
[01:02:26] +    |    |
[01:02:26] +    |    this function's body doesn't return
[01:02:26] + LL |     panic!();
[01:02:26] +    |             - help: consider removing this semicolon
[01:02:26] +    = note: expected type `std::option::Option<T>`
[01:02:26] +               found type `()`
[01:02:26] + 
[01:02:26] + error[E0308]: mismatched types
[01:02:26] + error[E0308]: mismatched types
[01:02:26] 2   --> $DIR/tag-that-dare-not-speak-its-name.rs:12:20
[01:02:26] 3    |
[01:02:26] 4 LL |     let x : char = last(y);
[01:02:26] 7    = note: expected type `char`
[01:02:26] 8               found type `std::option::Option<_>`
[01:02:26] 9 
[01:02:26] - error: aborting due to previous error
[01:02:26] - error: aborting due to previous error
[01:02:26] + error: aborting due to 3 previous errors
[01:02:26] 11 
[01:02:26] 12 For more information about this error, try `rustc --explain E0308`.
[01:02:26] 13 
[01:02:26] 
[01:02:26] 
[01:02:26] The actual stderr differed from the expected stderr.
[01:02:26] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/tag-that-dare-not-speak-its-name/tag-that-dare-not-speak-its-name.stderr
[01:02:26] To update references, rerun the tests and pass the `--bless` flag
[01:02:26] To only update this specific test, also pass `--test-args tag-that-dare-not-speak-its-name.rs`
[01:02:26] error: 1 errors occurred comparing output.
[01:02:26] status: exit code: 1
[01:02:26] status: exit code: 1
[01:02:26] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/tag-that-dare-not-speak-its-name/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/tag-that-dare-not-speak-its-name/auxiliary" "-A" "unused"
[01:02:26] ------------------------------------------
[01:02:26] 
[01:02:26] ------------------------------------------
[01:02:26] stderr:
[01:02:26] stderr:
[01:02:26] ------------------------------------------
[01:02:26] {"message":"cannot find macro `panic!` in this scope","code":null,"level":"error","spans":[{"file_name":"<::std::macros::panic macros>","byte_start":12,"byte_end":17,"line_start":1,"line_end":1,"column_start":13,"column_end":18,"is_primary":true,"text":[{"text":"(  ) => ( { panic ! ( \"explicit panic\" ) } ) ; ( $ msg : expr ) => (","highlight_start":13,"highlight_end":18}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs","byte_start":115,"byte_end":124,"line_start":7,"line_end":7,"column_start":5,"column_end":14,"is_primary":false,"text":[{"text":"    panic!();","highlight_start":5,"highlight_end":14}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"panic!","def_site_span":{"file_name":"<::std::macros::panic macros>","byte_start":0,"byte_end":427,"line_start":1,"line_end":10,"column_start":1,"column_end":68,"is_primary":false,"text":[{"text":"(  ) => ( { panic ! ( \"explicit panic\" ) } ) ; ( $ msg : expr ) => (","highlight_start":1,"highlight_end":69},{"text":"{","highlight_start":1,"highlight_end":2},{"text":"$ crate :: rt :: begin_panic (","highlight_start":1,"highlight_end":31},{"text":"$ msg , & ( file ! (  ) , line ! (  ) , __rust_unstable_column ! (  ) ) ) } )","highlight_start":1,"highlight_end":78},{"text":"; ( $ msg : expr , ) => ( { panic ! ( $ msg ) } ) ; (","highlight_start":1,"highlight_end":54},{"text":"$ fmt : expr , $ ( $ arg : tt ) + ) => (","highlight_start":1,"highlight_end":41},{"text":"{","highlight_start":1,"highlight_end":2},{"text":"$ crate :: rt :: begin_panic_fmt (","highlight_start":1,"highlight_end":35},{"text":"& format_args ! ( $ fmt , $ ( $ arg ) + ) , & (","highlight_start":1,"highlight_end":48},{"text":"file ! (  ) , line ! (  ) , __rust_unstable_column ! (  ) ) ) } ) ;","highlight_start":1,"highlight_end":68}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[{"message":"have you added the `#[macro_use]` on the module/import?","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: cannot find macro `panic!` in this scope\n  --> /checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs:7:5\n   |\nLL |     panic!();\n   |     ^^^^^^^^^\n   |\n   = help: have you added the `#[macro_use]` on the module/import?\n   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)\n\n"}
[01:02:26] {"message":"mismatched types","code":{"code":"E0308","explanation":"\nThis error occurs when the compiler was unable to infer the concrete type of a\nvariable. It can occur for several cases, the most common of which is a\nmismatch in the expected type that the compiler inferred for a variable's\ninitializing expression, and the actual type explicitly assigned to the\nvariable.\n\nFor example:\n\n```compile_fail,E0308\nlet x: i32 = \"I am not a number!\";\n//     ~~~   ~~~~~~~~~~~~~~~~~~~~\n//      |             |\n//      |    initializing expression;\n//      |    compiler infers type `&str`\n//      |\n//    type `i32` assigned to variable `x`\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs","byte_start":86,"byte_end":108,"line_start":6,"line_end":6,"column_start":28,"column_end":50,"is_primary":true,"text":[{"text":"fn last<T>(v: Vec<&T> ) -> std::option::Option<T> {","highlight_start":28,"highlight_end":50}],"label":"expected enum `std::option::Option`, found ()","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs","byte_start":62,"byte_end":66,"line_start":6,"line_end":6,"column_start":4,"column_end":8,"is_primary":false,"text":[{"text":"fn last<T>(v: Vec<&T> ) -> std::option::Option<T> {","highlight_start":4,"highlight_end":8}],"label":"this function's body doesn't return","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"expected type `std::option::Option<T>`\n   found type `()`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"consider removing this semicolon","code":null,"level":"help","spans":[{"file_name":"/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs","byte_start":123,"byte_end":124,"line_start":7,"line_end":7,"column_start":13,"column_end":14,"is_primary":true,"text":[{"text":"    panic!();","highlight_start":13,"highlight_end":14}],"label":null,"suggested_replacement":"","suggestion_applicability":"MachineApplicable","expansion":null}],"children":[],"rendered":null}],"rendered":"error[E0308]: mismatched types\n  --> /checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs:6:28\n   |\nLL | fn last<T>(v: Vec<&T> ) -> std::option::Option<T> {\n   |    ----                    ^^^^^^^^^^^^^^^^^^^^^^ expected enum `std::option::Option`, found ()\n   |    |\n   |    this function's body doesn't return\nLL |     panic!();\n   |             - help: consider removing this semicolon\n   |\n   = note: expected type `std::option::Option<T>`\n              found type `()`\n\n"}
[01:02:26] {"message":"mismatched types","code":{"code":"E0308","explanation":"\nThis error occurs when the compiler was unable to infer the concrete type of a\nvariable. It can occur for several cases, the most common of which is a\nmismatch in the expected type that the compiler inferred for a variable's\ninitializing expression, and the actual type explicitly assigned to the\nvariable.\n\nFor example:\n\n```compile_fail,E0308\nlet x: i32 = \"I am not a number!\";\n//     ~~~   ~~~~~~~~~~~~~~~~~~~~\n//      |             |\n//      |    initializing expression;\n//      |    compiler infers type `&str`\n//      |\n//    type `i32` assigned to variable `x`\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs","byte_start":170,"byte_end":177,"line_start":12,"line_end":12,"column_start":20,"column_end":27,"is_primary":true,"text":[{"text":"    let x : char = last(y);","highlight_start":20,"highlight_end":27}],"label":"expected char, found enum `std::option::Option`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"expected type `char`\n   found type `std::option::Option<_>`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0308]: mismatched types\n  --> /checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs:12:20\n   |\nLL |     let x : char = last(y);\n   |                    ^^^^^^^ expected char, found enum `std::option::Option`\n   |\n   = note: expected type `char`\n              found type `std::option::Option<_>`\n\n"}
[01:02:26] {"message":"For more information about this error, try `rustc --explain E0308`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0308`.\n"}
[01:02:26] 
[01:02:26] ------------------------------------------
[01:02:26] 
---
[01:02:26] 
[01:02:26] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:02:26] 
[01:02:26] 
[01:02:26] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:02:26] 
[01:02:26] 
[01:02:26] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:02:26] Build completed unsuccessfully in 0:04:15
[01:02:26] Build completed unsuccessfully in 0:04:15
[01:02:27] Makefile:48: recipe for target 'check' failed
[01:02:27] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0145ca94
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Thu Feb 14 05:59:37 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Feb 14, 2019

☔️ The latest upstream changes (presumably #58446) made this pull request unmergeable. Please resolve the merge conflicts.

@taiki-e

This comment has been minimized.

Copy link
Contributor Author

taiki-e commented Feb 15, 2019

@Centril Thanks for fix ICE!

@taiki-e taiki-e force-pushed the taiki-e:libstd-2018 branch from 2b2e349 to 55a31a1 Feb 15, 2019

@taiki-e

This comment has been minimized.

Copy link
Contributor Author

taiki-e commented Feb 15, 2019

Currently, occurring errors are the following two places:

Related to #55630 and #56389.

@taiki-e

This comment has been minimized.

Copy link
Contributor Author

taiki-e commented Feb 15, 2019

@petrochenkov Should these tests be rewritten to work with Rust 2018? Or should these tests be tested with Rust 2015 (probably add edition:2015 to header commands?)?

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Feb 15, 2019

@taiki-e
For hygiene/no_implicit_prelude this is an expected change, an ERROR annotation needs to be added.
tag-that-dare-not-speak-its-name needs to be "fixed to work", probably by using std::panic.

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Feb 15, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:1ebf24ac:start=1550223573941862237,finish=1550223576682769422,duration=2740907185
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[01:05:18] .................................................................................................... 1400/5390
[01:05:21] .................................................................................................... 1500/5390
[01:05:24] .................................................................................................... 1600/5390
[01:05:27] ...i..........................................................................i..................... 1700/5390
[01:05:31] ......F............................................................................................. 1800/5390
[01:05:39] .................................................................................................... 2000/5390
[01:05:42] ...................................i................................................................ 2100/5390
[01:05:46] .................................................................................................... 2200/5390
[01:05:51] .................................................................................................... 2300/5390
---
[01:07:25] ......................................i............................................................. 4600/5390
[01:07:31] .................................................................................................... 4700/5390
[01:07:35] .................................................................................................... 4800/5390
[01:07:39] .................................................................................................... 4900/5390
[01:07:43] ...................................F................................................................ 5000/5390
[01:07:50] .................................................................................................... 5200/5390
[01:07:53] .................................................................................................... 5300/5390
[01:07:56] .............................i............................................................
[01:07:56] failures:
[01:07:56] failures:
[01:07:56] 
[01:07:56] ---- [ui] ui/hygiene/no_implicit_prelude.rs stdout ----
[01:07:56] 
[01:07:56] error: /checkout/src/test/ui/hygiene/no_implicit_prelude.rs:16: unexpected error: '16:9: 16:20: cannot find macro `print!` in this scope'
[01:07:56] error: 1 unexpected errors found, 0 expected errors not found
[01:07:56] status: exit code: 1
[01:07:56] status: exit code: 1
[01:07:56] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/hygiene/no_implicit_prelude.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/hygiene/no_implicit_prelude/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/hygiene/no_implicit_prelude/auxiliary" "-A" "unused"
[01:07:56]     Error {
[01:07:56]         line_num: 16,
[01:07:56]         kind: Some(
[01:07:56]             Error
[01:07:56]             Error
[01:07:56]         ),
[01:07:56]         msg: "16:9: 16:20: cannot find macro `print!` in this scope"
[01:07:56] ]
[01:07:56] 
[01:07:56] thread '[ui] ui/hygiene/no_implicit_prelude.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:1378:13
[01:07:56] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:07:56] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:07:56] 
[01:07:56] ---- [ui] ui/tag-that-dare-not-speak-its-name.rs stdout ----
[01:07:56] diff of stderr:
[01:07:56] 
[01:07:56] + error: cannot find macro `panic!` in this scope
[01:07:56] +    |
[01:07:56] + LL |     std::panic!();
[01:07:56] +    |     ^^^^^^^^^^^^^^
[01:07:56] +    |
[01:07:56] +    |
[01:07:56] +    = help: have you added the `#[macro_use]` on the module/import?
[01:07:56] + 
[01:07:56] 1 error[E0308]: mismatched types
[01:07:56] +   --> $DIR/tag-that-dare-not-speak-its-name.rs:6:28
[01:07:56] +    |
[01:07:56] +    |
[01:07:56] + LL | fn last<T>(v: Vec<&T> ) -> std::option::Option<T> {
[01:07:56] +    |    ----                    ^^^^^^^^^^^^^^^^^^^^^^ expected enum `std::option::Option`, found ()
[01:07:56] +    |    |
[01:07:56] +    |    this function's body doesn't return
[01:07:56] + LL |     std::panic!();
[01:07:56] +    |                  - help: consider removing this semicolon
[01:07:56] +    = note: expected type `std::option::Option<T>`
[01:07:56] +               found type `()`
[01:07:56] + 
[01:07:56] + error[E0308]: mismatched types
[01:07:56] + error[E0308]: mismatched types
[01:07:56] 2   --> $DIR/tag-that-dare-not-speak-its-name.rs:12:20
[01:07:56] 3    |
[01:07:56] 4 LL |     let x : char = last(y);
[01:07:56] 7    = note: expected type `char`
[01:07:56] 8               found type `std::option::Option<_>`
[01:07:56] 9 
[01:07:56] - error: aborting due to previous error
[01:07:56] - error: aborting due to previous error
[01:07:56] + error: aborting due to 3 previous errors
[01:07:56] 11 
[01:07:56] 12 For more information about this error, try `rustc --explain E0308`.
[01:07:56] 13 
[01:07:56] 
[01:07:56] 
[01:07:56] The actual stderr differed from the expected stderr.
[01:07:56] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/tag-that-dare-not-speak-its-name/tag-that-dare-not-speak-its-name.stderr
[01:07:56] To update references, rerun the tests and pass the `--bless` flag
[01:07:56] To only update this specific test, also pass `--test-args tag-that-dare-not-speak-its-name.rs`
[01:07:56] error: 1 errors occurred comparing output.
[01:07:56] status: exit code: 1
[01:07:56] status: exit code: 1
[01:07:56] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/tag-that-dare-not-speak-its-name/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/tag-that-dare-not-speak-its-name/auxiliary" "-A" "unused"
[01:07:56] ------------------------------------------
[01:07:56] 
[01:07:56] ------------------------------------------
[01:07:56] stderr:
[01:07:56] stderr:
[01:07:56] ------------------------------------------
[01:07:56] {"message":"cannot find macro `panic!` in this scope","code":null,"level":"error","spans":[{"file_name":"<::std::macros::panic macros>","byte_start":12,"byte_end":17,"line_start":1,"line_end":1,"column_start":13,"column_end":18,"is_primary":true,"text":[{"text":"(  ) => ( { panic ! ( \"explicit panic\" ) } ) ; ( $ msg : expr ) => (","highlight_start":13,"highlight_end":18}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs","byte_start":115,"byte_end":129,"line_start":7,"line_end":7,"column_start":5,"column_end":19,"is_primary":false,"text":[{"text":"    std::panic!();","highlight_start":5,"highlight_end":19}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"std::panic!","def_site_span":{"file_name":"<::std::macros::panic macros>","byte_start":0,"byte_end":427,"line_start":1,"line_end":10,"column_start":1,"column_end":68,"is_primary":false,"text":[{"text":"(  ) => ( { panic ! ( \"explicit panic\" ) } ) ; ( $ msg : expr ) => (","highlight_start":1,"highlight_end":69},{"text":"{","highlight_start":1,"highlight_end":2},{"text":"$ crate :: rt :: begin_panic (","highlight_start":1,"highlight_end":31},{"text":"$ msg , & ( file ! (  ) , line ! (  ) , __rust_unstable_column ! (  ) ) ) } )","highlight_start":1,"highlight_end":78},{"text":"; ( $ msg : expr , ) => ( { panic ! ( $ msg ) } ) ; (","highlight_start":1,"highlight_end":54},{"text":"$ fmt : expr , $ ( $ arg : tt ) + ) => (","highlight_start":1,"highlight_end":41},{"text":"{","highlight_start":1,"highlight_end":2},{"text":"$ crate :: rt :: begin_panic_fmt (","highlight_start":1,"highlight_end":35},{"text":"& format_args ! ( $ fmt , $ ( $ arg ) + ) , & (","highlight_start":1,"highlight_end":48},{"text":"file ! (  ) , line ! (  ) , __rust_unstable_column ! (  ) ) ) } ) ;","highlight_start":1,"highlight_end":68}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[{"message":"have you added the `#[macro_use]` on the module/import?","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: cannot find macro `panic!` in this scope\n  --> /checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs:7:5\n   |\nLL |     std::panic!();\n   |     ^^^^^^^^^^^^^^\n   |\n   = help: have you added the `#[macro_use]` on the module/import?\n   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)\n\n"}
[01:07:56] {"message":"mismatched types","code":{"code":"E0308","explanation":"\nThis error occurs when the compiler was unable to infer the concrete type of a\nvariable. It can occur for several cases, the most common of which is a\nmismatch in the expected type that the compiler inferred for a variable's\ninitializing expression, and the actual type explicitly assigned to the\nvariable.\n\nFor example:\n\n```compile_fail,E0308\nlet x: i32 = \"I am not a number!\";\n//     ~~~   ~~~~~~~~~~~~~~~~~~~~\n//      |             |\n//      |    initializing expression;\n//      |    compiler infers type `&str`\n//      |\n//    type `i32` assigned to variable `x`\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs","byte_start":86,"byte_end":108,"line_start":6,"line_end":6,"column_start":28,"column_end":50,"is_primary":true,"text":[{"text":"fn last<T>(v: Vec<&T> ) -> std::option::Option<T> {","highlight_start":28,"highlight_end":50}],"label":"expected enum `std::option::Option`, found ()","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs","byte_start":62,"byte_end":66,"line_start":6,"line_end":6,"column_start":4,"column_end":8,"is_primary":false,"text":[{"text":"fn last<T>(v: Vec<&T> ) -> std::option::Option<T> {","highlight_start":4,"highlight_end":8}],"label":"this function's body doesn't return","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"expected type `std::option::Option<T>`\n   found type `()`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"consider removing this semicolon","code":null,"level":"help","spans":[{"file_name":"/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs","byte_start":128,"byte_end":129,"line_start":7,"line_end":7,"column_start":18,"column_end":19,"is_primary":true,"text":[{"text":"    std::panic!();","highlight_start":18,"highlight_end":19}],"label":null,"suggested_replacement":"","suggestion_applicability":"MachineApplicable","expansion":null}],"children":[],"rendered":null}],"rendered":"error[E0308]: mismatched types\n  --> /checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs:6:28\n   |\nLL | fn last<T>(v: Vec<&T> ) -> std::option::Option<T> {\n   |    ----                    ^^^^^^^^^^^^^^^^^^^^^^ expected enum `std::option::Option`, found ()\n   |    |\n   |    this function's body doesn't return\nLL |     std::panic!();\n   |                  - help: consider removing this semicolon\n   |\n   = note: expected type `std::option::Option<T>`\n              found type `()`\n\n"}
[01:07:56] {"message":"mismatched types","code":{"code":"E0308","explanation":"\nThis error occurs when the compiler was unable to infer the concrete type of a\nvariable. It can occur for several cases, the most common of which is a\nmismatch in the expected type that the compiler inferred for a variable's\ninitializing expression, and the actual type explicitly assigned to the\nvariable.\n\nFor example:\n\n```compile_fail,E0308\nlet x: i32 = \"I am not a number!\";\n//     ~~~   ~~~~~~~~~~~~~~~~~~~~\n//      |             |\n//      |    initializing expression;\n//      |    compiler infers type `&str`\n//      |\n//    type `i32` assigned to variable `x`\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs","byte_start":175,"byte_end":182,"line_start":12,"line_end":12,"column_start":20,"column_end":27,"is_primary":true,"text":[{"text":"    let x : char = last(y);","highlight_start":20,"highlight_end":27}],"label":"expected char, found enum `std::option::Option`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"expected type `char`\n   found type `std::option::Option<_>`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0308]: mismatched types\n  --> /checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs:12:20\n   |\nLL |     let x : char = last(y);\n   |                    ^^^^^^^ expected char, found enum `std::option::Option`\n   |\n   = note: expected type `char`\n              found type `std::option::Option<_>`\n\n"}
[01:07:56] {"message":"For more information about this error, try `rustc --explain E0308`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0308`.\n"}
[01:07:56] 
[01:07:56] ------------------------------------------
[01:07:56] 
---
[01:07:56] 
[01:07:56] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:07:56] 
[01:07:56] 
[01:07:56] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:07:56] 
[01:07:56] 
[01:07:56] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:07:56] Build completed unsuccessfully in 0:04:32
[01:07:56] Build completed unsuccessfully in 0:04:32
[01:07:56] make: *** [check] Error 1
[01:07:56] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0f861180
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Feb 15 10:47:44 UTC 2019
---
travis_time:end:09a7a948:start=1550227666148044248,finish=1550227666153587862,duration=5543614
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0a84b70e
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:03b52539
travis_time:start:03b52539
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:19981c5a
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@taiki-e taiki-e force-pushed the taiki-e:libstd-2018 branch from a3ef498 to 6e19fcd Feb 15, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 15, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0b1d5126:start=1550230414971846447,finish=1550230417244110807,duration=2272264360
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[01:06:41] ......................................i............................................................. 4600/5390
[01:06:47] .................................................................................................... 4700/5390
[01:06:50] .................................................................................................... 4800/5390
[01:06:54] .................................................................................................... 4900/5390
[01:06:58] .................................F.................................................................. 5000/5390
[01:07:05] .................................................................................................... 5200/5390
[01:07:07] .................................................................................................... 5300/5390
[01:07:10] .............................i............................................................
[01:07:10] failures:
[01:07:10] failures:
[01:07:10] 
[01:07:10] ---- [ui] ui/tag-that-dare-not-speak-its-name.rs stdout ----
[01:07:10] diff of stderr:
[01:07:10] 
[01:07:10] + error: cannot find macro `panic!` in this scope
[01:07:10] +    |
[01:07:10] + LL |     ::std::panic!();
[01:07:10] +    |     ^^^^^^^^^^^^^^^^
[01:07:10] +    |
[01:07:10] +    |
[01:07:10] +    = help: have you added the `#[macro_use]` on the module/import?
[01:07:10] + 
[01:07:10] 1 error[E0308]: mismatched types
[01:07:10] +   --> $DIR/tag-that-dare-not-speak-its-name.rs:6:28
[01:07:10] +    |
[01:07:10] +    |
[01:07:10] + LL | fn last<T>(v: Vec<&T> ) -> std::option::Option<T> {
[01:07:10] +    |    ----                    ^^^^^^^^^^^^^^^^^^^^^^ expected enum `std::option::Option`, found ()
[01:07:10] +    |    |
[01:07:10] +    |    this function's body doesn't return
[01:07:10] + LL |     ::std::panic!();
[01:07:10] +    |                    - help: consider removing this semicolon
[01:07:10] +    = note: expected type `std::option::Option<T>`
[01:07:10] +               found type `()`
[01:07:10] + 
[01:07:10] + error[E0308]: mismatched types
[01:07:10] + error[E0308]: mismatched types
[01:07:10] 2   --> $DIR/tag-that-dare-not-speak-its-name.rs:12:20
[01:07:10] 3    |
[01:07:10] 4 LL |     let x : char = last(y);
[01:07:10] 7    = note: expected type `char`
[01:07:10] 8               found type `std::option::Option<_>`
[01:07:10] 9 
[01:07:10] - error: aborting due to previous error
[01:07:10] - error: aborting due to previous error
[01:07:10] + error: aborting due to 3 previous errors
[01:07:10] 11 
[01:07:10] 12 For more information about this error, try `rustc --explain E0308`.
[01:07:10] 13 
[01:07:10] 
[01:07:10] 
[01:07:10] The actual stderr differed from the expected stderr.
[01:07:10] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/tag-that-dare-not-speak-its-name/tag-that-dare-not-speak-its-name.stderr
[01:07:10] To update references, rerun the tests and pass the `--bless` flag
[01:07:10] To only update this specific test, also pass `--test-args tag-that-dare-not-speak-its-name.rs`
[01:07:10] error: 1 errors occurred comparing output.
[01:07:10] status: exit code: 1
[01:07:10] status: exit code: 1
[01:07:10] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/tag-that-dare-not-speak-its-name/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/tag-that-dare-not-speak-its-name/auxiliary" "-A" "unused"
[01:07:10] ------------------------------------------
[01:07:10] 
[01:07:10] ------------------------------------------
[01:07:10] stderr:
[01:07:10] stderr:
[01:07:10] ------------------------------------------
[01:07:10] {"message":"cannot find macro `panic!` in this scope","code":null,"level":"error","spans":[{"file_name":"<::std::macros::panic macros>","byte_start":12,"byte_end":17,"line_start":1,"line_end":1,"column_start":13,"column_end":18,"is_primary":true,"text":[{"text":"(  ) => ( { panic ! ( \"explicit panic\" ) } ) ; ( $ msg : expr ) => (","highlight_start":13,"highlight_end":18}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs","byte_start":115,"byte_end":131,"line_start":7,"line_end":7,"column_start":5,"column_end":21,"is_primary":false,"text":[{"text":"    ::std::panic!();","highlight_start":5,"highlight_end":21}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"::std::panic!","def_site_span":{"file_name":"<::std::macros::panic macros>","byte_start":0,"byte_end":427,"line_start":1,"line_end":10,"column_start":1,"column_end":68,"is_primary":false,"text":[{"text":"(  ) => ( { panic ! ( \"explicit panic\" ) } ) ; ( $ msg : expr ) => (","highlight_start":1,"highlight_end":69},{"text":"{","highlight_start":1,"highlight_end":2},{"text":"$ crate :: rt :: begin_panic (","highlight_start":1,"highlight_end":31},{"text":"$ msg , & ( file ! (  ) , line ! (  ) , __rust_unstable_column ! (  ) ) ) } )","highlight_start":1,"highlight_end":78},{"text":"; ( $ msg : expr , ) => ( { panic ! ( $ msg ) } ) ; (","highlight_start":1,"highlight_end":54},{"text":"$ fmt : expr , $ ( $ arg : tt ) + ) => (","highlight_start":1,"highlight_end":41},{"text":"{","highlight_start":1,"highlight_end":2},{"text":"$ crate :: rt :: begin_panic_fmt (","highlight_start":1,"highlight_end":35},{"text":"& format_args ! ( $ fmt , $ ( $ arg ) + ) , & (","highlight_start":1,"highlight_end":48},{"text":"file ! (  ) , line ! (  ) , __rust_unstable_column ! (  ) ) ) } ) ;","highlight_start":1,"highlight_end":68}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[{"message":"have you added the `#[macro_use]` on the module/import?","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: cannot find macro `panic!` in this scope\n  --> /checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs:7:5\n   |\nLL |     ::std::panic!();\n   |     ^^^^^^^^^^^^^^^^\n   |\n   = help: have you added the `#[macro_use]` on the module/import?\n   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)\n\n"}
[01:07:10] {"message":"mismatched types","code":{"code":"E0308","explanation":"\nThis error occurs when the compiler was unable to infer the concrete type of a\nvariable. It can occur for several cases, the most common of which is a\nmismatch in the expected type that the compiler inferred for a variable's\ninitializing expression, and the actual type explicitly assigned to the\nvariable.\n\nFor example:\n\n```compile_fail,E0308\nlet x: i32 = \"I am not a number!\";\n//     ~~~   ~~~~~~~~~~~~~~~~~~~~\n//      |             |\n//      |    initializing expression;\n//      |    compiler infers type `&str`\n//      |\n//    type `i32` assigned to variable `x`\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs","byte_start":86,"byte_end":108,"line_start":6,"line_end":6,"column_start":28,"column_end":50,"is_primary":true,"text":[{"text":"fn last<T>(v: Vec<&T> ) -> std::option::Option<T> {","highlight_start":28,"highlight_end":50}],"label":"expected enum `std::option::Option`, found ()","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs","byte_start":62,"byte_end":66,"line_start":6,"line_end":6,"column_start":4,"column_end":8,"is_primary":false,"text":[{"text":"fn last<T>(v: Vec<&T> ) -> std::option::Option<T> {","highlight_start":4,"highlight_end":8}],"label":"this function's body doesn't return","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"expected type `std::option::Option<T>`\n   found type `()`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"consider removing this semicolon","code":null,"level":"help","spans":[{"file_name":"/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs","byte_start":130,"byte_end":131,"line_start":7,"line_end":7,"column_start":20,"column_end":21,"is_primary":true,"text":[{"text":"    ::std::panic!();","highlight_start":20,"highlight_end":21}],"label":null,"suggested_replacement":"","suggestion_applicability":"MachineApplicable","expansion":null}],"children":[],"rendered":null}],"rendered":"error[E0308]: mismatched types\n  --> /checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs:6:28\n   |\nLL | fn last<T>(v: Vec<&T> ) -> std::option::Option<T> {\n   |    ----                    ^^^^^^^^^^^^^^^^^^^^^^ expected enum `std::option::Option`, found ()\n   |    |\n   |    this function's body doesn't return\nLL |     ::std::panic!();\n   |                    - help: consider removing this semicolon\n   |\n   = note: expected type `std::option::Option<T>`\n              found type `()`\n\n"}
[01:07:10] {"message":"mismatched types","code":{"code":"E0308","explanation":"\nThis error occurs when the compiler was unable to infer the concrete type of a\nvariable. It can occur for several cases, the most common of which is a\nmismatch in the expected type that the compiler inferred for a variable's\ninitializing expression, and the actual type explicitly assigned to the\nvariable.\n\nFor example:\n\n```compile_fail,E0308\nlet x: i32 = \"I am not a number!\";\n//     ~~~   ~~~~~~~~~~~~~~~~~~~~\n//      |             |\n//      |    initializing expression;\n//      |    compiler infers type `&str`\n//      |\n//    type `i32` assigned to variable `x`\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs","byte_start":177,"byte_end":184,"line_start":12,"line_end":12,"column_start":20,"column_end":27,"is_primary":true,"text":[{"text":"    let x : char = last(y);","highlight_start":20,"highlight_end":27}],"label":"expected char, found enum `std::option::Option`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"expected type `char`\n   found type `std::option::Option<_>`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0308]: mismatched types\n  --> /checkout/src/test/ui/tag-that-dare-not-speak-its-name.rs:12:20\n   |\nLL |     let x : char = last(y);\n   |                    ^^^^^^^ expected char, found enum `std::option::Option`\n   |\n   = note: expected type `char`\n              found type `std::option::Option<_>`\n\n"}
[01:07:10] {"message":"For more information about this error, try `rustc --explain E0308`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0308`.\n"}
[01:07:10] 
[01:07:10] ------------------------------------------
[01:07:10] 
---
[01:07:10] 
[01:07:10] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:07:10] 
[01:07:10] 
[01:07:10] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:07:10] 
[01:07:10] 
[01:07:10] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:07:10] Build completed unsuccessfully in 0:04:18
[01:07:10] Build completed unsuccessfully in 0:04:18
[01:07:10] make: *** [check] Error 1
[01:07:10] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:007f42b6
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Feb 15 12:40:59 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@taiki-e

This comment has been minimized.

Copy link
Contributor Author

taiki-e commented Feb 16, 2019

CI passed. Thanks for your help @petrochenkov!

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 17, 2019

LGTM! @bors r+ p=1

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 17, 2019

📌 Commit 338656d has been approved by Centril

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment