Upgrade non-LTS Ubuntu images in CI #60665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The canonical repository on fuchsia.googlesource.com is not accessible anymore, neither for anonymous access nor logged in access. This commit switches our CI to fetch the repository from our own mirror.
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ p=1 |
|
📌 Commit c98a27c has been approved by |
bors
added
S-waiting-on-bors
|
As I understand, Zircon now lives under Fuchsia monorepo: https://fuchsia.googlesource.com/fuchsia/+/refs/heads/master/zircon/ |
|
@bors rollup=never |
bors
added a commit
that referenced
this pull request
May 9, 2019
Upgrade non-LTS Ubuntu images in CI This PR bumps `dist-various-2` to 18.04 LTS and both `x86_64-gnu` and `x86_64-gnu-debug` to 19.04. Another change is the switch to [rust-lang/mirror-google-fuchsia-zircon](https://github.com/rust-lang/mirror-google-fuchsia-zircon) as the Zircon repository, used during Fuchsia tests: the original repository ([fuchsia.googlesource.com/zircon](https://fuchsia.googlesource.com/zircon)) is now behind a login wall and it doesn't contain anything at all. r? @alexcrichton cc @cramertj -- what's happening on the Fuchsia side?
|
@sanxiyn is correct, the zircon-standalone repository isn't really a thing anymore. Going forward, we should look to move to artifacts from the published Fuchsia SDK rather than trying to pull down source from the repo. I'd be happy to help work on that. |
|
💔 Test failed - checks-travis |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors: retry Presumably sccache caches got busted |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
May 9, 2019
Upgrade non-LTS Ubuntu images in CI This PR bumps `dist-various-2` to 18.04 LTS and both `x86_64-gnu` and `x86_64-gnu-debug` to 19.04. Another change is the switch to [rust-lang/mirror-google-fuchsia-zircon](https://github.com/rust-lang/mirror-google-fuchsia-zircon) as the Zircon repository, used during Fuchsia tests: the original repository ([fuchsia.googlesource.com/zircon](https://fuchsia.googlesource.com/zircon)) is now behind a login wall and it doesn't contain anything at all. r? @alexcrichton cc @cramertj -- what's happening on the Fuchsia side?
|
That failure is not related to this PR, it will keep happening until #60684 is merged |
|
Can you silence the bot in the meantime? |
|
☀️ Test successful - checks-travis, status-appveyor |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
May 10, 2019
Tested on commit rust-lang/rust@adcd4aa. Direct link to PR: <rust-lang/rust#60665> 🎉 rls on windows: test-fail → test-pass (cc @Xanewok, @rust-lang/infra).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps
dist-various-2to 18.04 LTS and bothx86_64-gnuandx86_64-gnu-debugto 19.04.Another change is the switch to rust-lang/mirror-google-fuchsia-zircon as the Zircon repository, used during Fuchsia tests: the original repository (fuchsia.googlesource.com/zircon) is now behind a login wall and it doesn't contain anything at all.
r? @alexcrichton
cc @cramertj -- what's happening on the Fuchsia side?