Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GlobalArenas and use Arena instead #61389

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Remove GlobalArenas and use Arena instead #61389

merged 1 commit into from
Jun 1, 2019

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented May 31, 2019

r? @eddyb

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 31, 2019
@eddyb
Copy link
Member

eddyb commented May 31, 2019

@bors r+

@bors
Copy link
Contributor

bors commented May 31, 2019

📌 Commit 6d38746 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2019
@mati865
Copy link
Contributor

mati865 commented May 31, 2019

@bors rollup=never to get accurate results on perf.rlo?

@RalfJung
Copy link
Member

@bors rollup=never

@Zoxc
Copy link
Contributor Author

Zoxc commented Jun 1, 2019

This is unlikely to change performance

@bors rollup

Centril added a commit to Centril/rust that referenced this pull request Jun 1, 2019
@Centril
Rollup merge of rust-lang#61389 - Zoxc:arena-cleanup, r=eddyb
760a98f 
Remove GlobalArenas and use Arena instead

r? @eddyb
@Centril Centril mentioned this pull request Jun 1, 2019
Merged
bors added a commit that referenced this pull request Jun 1, 2019
@bors
Auto merge of #61418 - Centril:rollup-yvj33a1, r=Centril
885c7df 
Rollup of 8 pull requests

Successful merges:

 - #60729 (Expand dynamic drop tests for cases in #47949)
 - #61263 (Don't generate div inside header (h4/h3/h...) elements)
 - #61364 (Stabilize reverse_bits feature)
 - #61375 (Make "panic did not include expected string" message consistent)
 - #61387 (Remove ty::BrFresh and RegionConstraintCollector::new_bound)
 - #61389 (Remove GlobalArenas and use Arena instead)
 - #61391 (Doc comment fixes for `rustc::mir::interpret::InterpretCx`)
 - #61403 (Remove unnecessary `-Z continue-parse-after-error` from tests)

Failed merges:

r? @ghost
@bors bors merged commit 6d38746 into rust-lang:master Jun 1, 2019
@Zoxc Zoxc deleted the arena-cleanup branch June 1, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Zoxc @eddyb @bors @mati865 @RalfJung @rust-highfive