Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closures implement Copy and Clone, generators don't #61981

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Closures implement Copy and Clone, generators don't #61981

merged 1 commit into from
Jun 20, 2019

Conversation

shepmaster
Copy link
Member

No description provided.

@shepmaster shepmaster added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-coroutines Area: Coroutines labels Jun 20, 2019
@rust-highfive
Copy link
Collaborator

r? @frewsxcv

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2019
@cramertj
Copy link
Member

Is that true? I thought generators did as well

@shepmaster
Copy link
Member Author

Not based on #57972 and experimental evidence

@frewsxcv frewsxcv removed their assignment Jun 20, 2019
@cramertj
Copy link
Member

Huh, IIRC it was specified in the Copy/Clone closures RFC that this would also apply to generators, but since it's all unstable it seems fine to document the current behavior.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 20, 2019

📌 Commit b0dd7fc has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 20, 2019
@Centril
Rollup merge of rust-lang#61981 - rust-lang:generators-clone-doc, r=c…
fdbc4ce 
…ramertj

Closures implement Copy and Clone, generators don't
@Centril Centril mentioned this pull request Jun 20, 2019
Merged
bors added a commit that referenced this pull request Jun 20, 2019
@bors
Auto merge of #62006 - Centril:rollup-4my59er, r=Centril
1d9981f 
Rollup of 5 pull requests

Successful merges:

 - #61900 (implement Error::source for Box<T: Error>)
 - #61979 (Implement Debug for PlaceBase)
 - #61981 (Closures implement Copy and Clone, generators don't)
 - #61996 (Add unit tests for unescaping raw (byte) strings)
 - #62000 (Add test for issue-54189)

Failed merges:

r? @ghost
@bors bors merged commit b0dd7fc into master Jun 20, 2019
@shepmaster shepmaster deleted the generators-clone-doc branch June 21, 2019 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-coroutines Area: Coroutines C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shepmaster @rust-highfive @cramertj @bors @frewsxcv