Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 14 pull requests #62418

Closed
wants to merge 48 commits into from
Closed

Commits on May 30, 2019

  1. Optimize pointer alignment in utf8 validation

    This uses (and reuses) the u8 arrays's inherent block alignment when checking whether the current index is block aligned.
    
    I initially thought that this would just move the expensive `align_offset` call out of the while loop and replace it with a subtraction and bitwise AND. But it appears this optimizes much better, too...
    
    before: https://rust.godbolt.org/z/WIPvWl
    after: https://rust.godbolt.org/z/-jBPoW
    
    https://github.com/jridgewell/faster-from_utf8/tree/pointer-alignment
    
    ```
    test from_utf8_2_bytes_fast      ... bench:         310 ns/iter (+/- 42) = 1290 MB/s
    test from_utf8_2_bytes_regular   ... bench:         309 ns/iter (+/- 24) = 1294 MB/s
    
    test from_utf8_3_bytes_fast      ... bench:       1,027 ns/iter (+/- 62) = 1168 MB/s
    test from_utf8_3_bytes_regular   ... bench:       1,513 ns/iter (+/- 611) = 793 MB/s
    
    test from_utf8_4_bytes_fast      ... bench:       1,788 ns/iter (+/- 26) = 1342 MB/s
    test from_utf8_4_bytes_regular   ... bench:       1,907 ns/iter (+/- 181) = 1258 MB/s
    
    test from_utf8_all_bytes_fast    ... bench:       3,463 ns/iter (+/- 97) = 1155 MB/s
    test from_utf8_all_bytes_regular ... bench:       4,083 ns/iter (+/- 89) = 979 MB/s
    
    test from_utf8_ascii_fast        ... bench:          88 ns/iter (+/- 4) = 28988 MB/s
    test from_utf8_ascii_regular     ... bench:          88 ns/iter (+/- 8) = 28988 MB/s
    
    test from_utf8_cyr_fast          ... bench:       7,707 ns/iter (+/- 531) = 665 MB/s
    test from_utf8_cyr_regular       ... bench:       8,202 ns/iter (+/- 135) = 625 MB/s
    
    test from_utf8_enwik8_fast       ... bench:   1,135,756 ns/iter (+/- 84,450) = 8804 MB/s
    test from_utf8_enwik8_regular    ... bench:   1,145,468 ns/iter (+/- 79,601) = 8730 MB/s
    
    test from_utf8_jawik10_fast      ... bench:  12,723,844 ns/iter (+/- 473,247) = 785 MB/s
    test from_utf8_jawik10_regular   ... bench:  13,384,596 ns/iter (+/- 666,997) = 747 MB/s
    
    test from_utf8_mixed_fast        ... bench:       2,321 ns/iter (+/- 123) = 2081 MB/s
    test from_utf8_mixed_regular     ... bench:       2,702 ns/iter (+/- 408) = 1788 MB/s
    
    test from_utf8_mostlyasc_fast    ... bench:         249 ns/iter (+/- 10) = 14666 MB/s
    test from_utf8_mostlyasc_regular ... bench:         276 ns/iter (+/- 5) = 13231 MB/s
    ```
    jridgewell committed May 30, 2019
    Configuration menu
    Copy the full SHA
    3d2c4ff View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2019

  1. Configuration menu
    Copy the full SHA
    7d0a952 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    37f09cb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    084c829 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    65c81de View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    08b81f2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7de6f54 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8e087cd View commit details
    Browse the repository at this point in the history
  8. Allow usage_of_ty_tykind only in sty

    and in some special cases
    flip1995 committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    d0625a3 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. Update linked OpenSSL version

    This bumps our linked OpenSSL version from 1.1.1a to 1.1.1c, picking up
    some various bug fixes and minor security issue fixes.
    alexcrichton committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    16b37b5 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2019

  1. Configuration menu
    Copy the full SHA
    e475539 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e32b8eb View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2019

  1. Configuration menu
    Copy the full SHA
    0ffb643 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e4e7eb2 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2019

  1. Fix merge conflicts

    pvdrz committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    e45bbaf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7987719 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4f7ba51 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    37d7e1f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c6131b2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    01e0d83 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    675bfb6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a6030ff View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7f035ba View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    61ddf5e View commit details
    Browse the repository at this point in the history
  11. Update README.md

    markebrooks committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    f4b30f4 View commit details
    Browse the repository at this point in the history
  12. Remove solve_nll_region_constraints measurements from `-Ztime-passe…

    …s` output.
    
    Because it pollutes the output with hundreds or thousands of
    uninteresting lines for which the time duration is always(?) 0.000s.
    nnethercote committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    90419d3 View commit details
    Browse the repository at this point in the history
  13. Add a "total" measurement to -Ztime-passes.

    This is useful for getting the total compilation time at the end.
    To do this, the patch changes `print_time_passes_entry` to not increment
    the depth, which means that `print_time_passes_entry_internal` is no
    longer needed.
    nnethercote committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    87b103d View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2019

  1. Configuration menu
    Copy the full SHA
    050a71b View commit details
    Browse the repository at this point in the history
  2. Lint on invalid values passed to x.py --warnings

    This also introduces support for `--warnings allow` and fixes --warnings
    being overridden by the configuration file, config.toml.
    Mark-Simulacrum committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    f01e5e6 View commit details
    Browse the repository at this point in the history
  3. Remove last use of mem::uninitialized in SGX

    Jethro Beekman committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    7fb17d8 View commit details
    Browse the repository at this point in the history
  4. Remove compile-pass from compiletest

    Also change annotations in some tests
    JohnTitor committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    ce77031 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    db93d01 View commit details
    Browse the repository at this point in the history
  6. Update rustc-guide

    JohnTitor committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    211b52b View commit details
    Browse the repository at this point in the history
  7. Fix test annotation

    JohnTitor committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    1640ab2 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#61339 - jridgewell:pointer-alignment, r=Bur…

    …ntSushi
    
    Optimize pointer alignment in utf8 validation
    
    This uses (and reuses) the u8 arrays's inherent block alignment when checking whether the current index is block aligned.
    
    I initially thought that this would just move the expensive `align_offset` call out of the while loop and replace it with a subtraction and bitwise AND. But it appears this optimizes much better, too...
    
    before: https://rust.godbolt.org/z/WIPvWl
    after: https://rust.godbolt.org/z/-jBPoW
    
    ## Benchmarks
    
    https://github.com/jridgewell/faster-from_utf8/tree/pointer-alignment
    
    ```
    test from_utf8_2_bytes_fast      ... bench:         310 ns/iter (+/- 42) = 1290 MB/s
    test from_utf8_2_bytes_regular   ... bench:         309 ns/iter (+/- 24) = 1294 MB/s
    
    test from_utf8_3_bytes_fast      ... bench:       1,027 ns/iter (+/- 62) = 1168 MB/s
    test from_utf8_3_bytes_regular   ... bench:       1,513 ns/iter (+/- 611) = 793 MB/s
    
    test from_utf8_4_bytes_fast      ... bench:       1,788 ns/iter (+/- 26) = 1342 MB/s
    test from_utf8_4_bytes_regular   ... bench:       1,907 ns/iter (+/- 181) = 1258 MB/s
    
    test from_utf8_all_bytes_fast    ... bench:       3,463 ns/iter (+/- 97) = 1155 MB/s
    test from_utf8_all_bytes_regular ... bench:       4,083 ns/iter (+/- 89) = 979 MB/s
    
    test from_utf8_ascii_fast        ... bench:          88 ns/iter (+/- 4) = 28988 MB/s
    test from_utf8_ascii_regular     ... bench:          88 ns/iter (+/- 8) = 28988 MB/s
    
    test from_utf8_cyr_fast          ... bench:       7,707 ns/iter (+/- 531) = 665 MB/s
    test from_utf8_cyr_regular       ... bench:       8,202 ns/iter (+/- 135) = 625 MB/s
    
    test from_utf8_enwik8_fast       ... bench:   1,135,756 ns/iter (+/- 84,450) = 8804 MB/s
    test from_utf8_enwik8_regular    ... bench:   1,145,468 ns/iter (+/- 79,601) = 8730 MB/s
    
    test from_utf8_jawik10_fast      ... bench:  12,723,844 ns/iter (+/- 473,247) = 785 MB/s
    test from_utf8_jawik10_regular   ... bench:  13,384,596 ns/iter (+/- 666,997) = 747 MB/s
    
    test from_utf8_mixed_fast        ... bench:       2,321 ns/iter (+/- 123) = 2081 MB/s
    test from_utf8_mixed_regular     ... bench:       2,702 ns/iter (+/- 408) = 1788 MB/s
    
    test from_utf8_mostlyasc_fast    ... bench:         249 ns/iter (+/- 10) = 14666 MB/s
    test from_utf8_mostlyasc_regular ... bench:         276 ns/iter (+/- 5) = 13231 MB/s
    ```
    Centril committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    29a035f View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#61545 - flip1995:internal_lints, r=oli-obk

    Implement another internal lints
    
    cc rust-lang#49509
    
    This adds ~~two~~ one internal lint~~s~~:
    1. LINT_PASS_IMPL_WITHOUT_MACRO: Make sure, that the `{declare,impl}_lint_pass` macro is used to implement lint passes. cc rust-lang#59669
    2. ~~USAGE_OF_TYCTXT_AND_SPAN_ARGS: item 2 on the list in rust-lang#49509~~
    
    ~~With 2. I wasn't sure, if this lint should be applied everywhere. That means a careful review of 0955835 would be great. Also 73fb9b4 allows this lint on some functions. Should I also apply this lint there?~~
    
    TODO (not directly relevant for review):
    - [ ] rust-lang#59316 (comment) (not sure yet, if this works or how to query for `rustc_private`, since it's not in [`Features`](https://doc.rust-lang.org/nightly/nightly-rustc/syntax/feature_gate/struct.Features.html) 🤔 cc @eddyb)
    - [x] rust-lang#61735 (comment)
    - [x] Check explicitly for the `{declare,impl}_lint_pass!` macros
    
    r? @oli-obk
    Centril committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    995d34e View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#62110 - nnethercote:improve-Ztime-passes, r…

    …=Zoxc
    
    Improve -Ztime-passes
    
    Two improvements that make `-Ztime-passes` more useful.
    
    r? @Zoxc
    Centril committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    c511f0d View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#62133 - petrochenkov:norustc, r=eddyb

    Feature gate `rustc` attributes harder
    
    Fixes rust-lang#62116
    Centril committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    51454fd View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#62151 - alexcrichton:update-openssl, r=Mark…

    …-Simulacrum
    
    Update linked OpenSSL version
    
    This bumps our linked OpenSSL version from 1.1.1a to 1.1.1c, picking up
    some various bug fixes and minor security issue fixes.
    Centril committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    892c653 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#62158 - christianpoveda:ecx-memory-extra, r…

    …=RalfJung
    
    Add MemoryExtra in InterpretCx constructor params
    
    This is to avoid modifying `MemoryExtra` inside `InterpretCx` after initialization. Related miri PR: rust-lang/miri#792
    
    r? @RalfJung
    Centril committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    4509e89 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#62168 - ljedrz:the_culmination_of_hiridific…

    …ation, r=Zoxc
    
    The (almost) culmination of HirIdification
    
    It's finally over.
    
    This PR removes old `FIXME`s and renames some functions so that the `HirId` variant has the shorter name.
    All that remains (and rightfully so) is stuff in `resolve`, `save_analysis` and (as far as I can tell) in a few places where we can't replace `NodeId` with `HirId`.
    Centril committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    23de4fe View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#62193 - matthewjasper:dynamic-drop-async, r…

    …=Centril
    
    Create async version of the dynamic-drop test
    
    Some of the tests in dynamic-drop have been cut:
    * The tests that are just simpler versions of other tests - these tests are already fairly slow due to all of the unwinding and async functions have more control flow paths than normal functions.
    * The union test - it's for an unstable feature that has an RFC to remove it.
    * The generator test - there aren't async generators yet.
    * The tests that show values being leaked - these can be added once the issue is fixed.
    
    r? @Centril
    cc  rust-lang#62121 @cramertj
    Centril committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    1e83fc1 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#62369 - JohnTitor:remove-compile-pass, r=pe…

    …trochenkov
    
    Remove `compile-pass` from compiletest
    
    This is a part of rust-lang#62277.
    Removes `compile-pass` from compiletest (and modify some tests' annotations).
    
    r? @Centril
    Centril committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    07505c9 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#62380 - eddyb:x64-sysv-regs, r=nagisa

    rustc_target: avoid negative register counts in the SysV x86_64 ABI.
    
    Because `needed_{int,sse}` and `{int,sse}_regs` were only used with integer literals, they were inferred to `i32` and `{int,sse}_regs` could therefore be negative.
    There was a check which prevented that, but *only* for aggregate arguments, not scalars.
    
    Fixes rust-lang#62350.
    
    r? @nagisa or @rkruppe
    Centril committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    b973796 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#62381 - pawroman:fix_typo_in_write_vectored…

    …, r=Centril
    
    Fix a typo in Write::write_vectored docs
    
    Fixed what seems like a typo. "Copy to from" is extremely confusing.
    Centril committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    1d5b632 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#62390 - markebrooks:encourage, r=Centril

    Update README.md
    
    Let's not discourage contributions.
    Centril committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    43e55f1 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#62406 - Mark-Simulacrum:warnings-lint, r=Ra…

    …lfJung
    
    Lint on invalid values passed to x.py --warnings
    
    This also introduces support for `--warnings allow` and fixes --warnings
    being overridden by the configuration file, config.toml.
    
    Fixes rust-lang#62402
    
    r? @RalfJung
    Centril committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    08111e1 View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#62414 - jethrogb:jb/sgx-uninit, r=Mark-Simu…

    …lacrum
    
    Remove last use of mem::uninitialized in SGX
    
    See rust-lang#62397
    Centril committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    7ed1b8c View commit details
    Browse the repository at this point in the history