Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove meaningless comments in src/test #63487

Open
wants to merge 3 commits into
base: master
from

Conversation

@sd234678
Copy link
Contributor

commented Aug 12, 2019

Moved from #63411

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 12, 2019

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@sd234678

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

@Centril
Copy link
Member

left a comment

r=me rollup when green

@Centril

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

📌 Commit 7fb5eb5 has been approved by Centril

bors added a commit that referenced this pull request Aug 14, 2019

Auto merge of #63540 - Mark-Simulacrum:rollup-t0qq657, r=Mark-Simulacrum
Rollup of 11 pull requests

Successful merges:

 - #62760 (Deduplicate error messages in `librsctc_mir`)
 - #62849 (typeck: Prohibit RPIT types that inherit lifetimes)
 - #63383 (`async fn` lifetime elision tests)
 - #63421 (Implement Clone, Display for ascii::EscapeDefault)
 - #63459 (syntax: account for CVarArgs being in the argument list.)
 - #63470 (Utilize -Zbinary-dep-depinfo in rustbuild)
 - #63475 (Bring back suggestion for splitting `<-` into `< -`)
 - #63485 (ci: move mirrors to their standalone bucket)
 - #63488 (improve DiagnosticBuilder docs)
 - #63491 (Update RLS)
 - #63534 (Bump to 1.39)

Failed merges:

 - #63487 (Remove meaningless comments in src/test)

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

☔️ The latest upstream changes (presumably #63544) made this pull request unmergeable. Please resolve the merge conflicts.

@sd234678 sd234678 force-pushed the sd234678:remove-meaningless-comments-in-src/test-2 branch from 7fb5eb5 to 5f50c4a Aug 15, 2019

@Centril

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

📌 Commit 5f50c4a has been approved by Centril

Centril added a commit to Centril/rust that referenced this pull request Aug 15, 2019

Rollup merge of rust-lang#63487 - sd234678:remove-meaningless-comment…
…s-in-src/test-2, r=Centril

Remove meaningless comments in src/test

Moved from rust-lang#63411

bors added a commit that referenced this pull request Aug 15, 2019

Auto merge of #63617 - Centril:rollup-zqsuhyy, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #62593 (Group all ABI tests.)
 - #63487 (Remove meaningless comments in src/test)
 - #63535 (Continue refactoring resolve and hygiene)
 - #63539 (Suggest Rust 2018 on `<expr>.await` with no such field)
 - #63584 (libcore: more cleanups using `#![feature(associated_type_bounds)]`)
 - #63612 (Do not suggest `try_into` for base types inside of macro expansions)
 - #63615 (Fix typo in DoubleEndedIterator::nth_back doc)

Failed merges:

r? @ghost
@Centril

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

Failed in #63617 (comment), @bors r-
You'll also need --bless --compare-mode=nll.

@sd234678 sd234678 force-pushed the sd234678:remove-meaningless-comments-in-src/test-2 branch from 5f50c4a to b21ee49 Aug 16, 2019

@sd234678

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2019

@Centril do I need to do anything else to get bors to pick this back up?

@Centril

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

@sd234678 I need to reapprove the PR when you make a change. However, when you force-push I don't get a notification so you have to leave a comment instead if you want me to see it.

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2019

📌 Commit b21ee49 has been approved by Centril

Centril added a commit to Centril/rust that referenced this pull request Aug 17, 2019

Rollup merge of rust-lang#63487 - sd234678:remove-meaningless-comment…
…s-in-src/test-2, r=Centril

Remove meaningless comments in src/test

Moved from rust-lang#63411

bors added a commit that referenced this pull request Aug 17, 2019

Auto merge of #63671 - Centril:rollup-zufavt5, r=Centril
Rollup of 5 pull requests

Successful merges:

 - #62451 (Add APIs for uninitialized Box, Rc, and Arc. (Plus get_mut_unchecked))
 - #63487 (Remove meaningless comments in src/test)
 - #63657 (Crank up invalid value lint)
 - #63667 (resolve: Properly integrate derives and `macro_rules` scopes)
 - #63669 (fix typos in mir/interpret)

Failed merges:

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.