Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #63926

Merged
merged 52 commits into from
Aug 27, 2019
Merged

Rollup of 6 pull requests #63926

merged 52 commits into from
Aug 27, 2019

Commits on Aug 21, 2019

  1. Configuration menu
    Copy the full SHA
    053afa7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    352d97e View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2019

  1. Configuration menu
    Copy the full SHA
    912feab View commit details
    Browse the repository at this point in the history
  2. Merge pull request rust-lang#8 from Wind-River/set_name_003

    VxWorks does not provide a way to set the task name except at creation time
    BaoshanPang authored Aug 23, 2019
    Configuration menu
    Copy the full SHA
    602bea3 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2019

  1. Configuration menu
    Copy the full SHA
    a577316 View commit details
    Browse the repository at this point in the history
  2. Added an extra line to make the formatting conform to the rest of the…

    … document.
    Christian committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    55f8dde View commit details
    Browse the repository at this point in the history
  3. Fix tidy feature gate error reporting

    Feature gate definitions were split into multiple files in rust-lang#63824 but
    tidy kept reporting the hard-coded path. Now, it shows the full path
    to the correct file.
    killercup committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    8ca9c7b View commit details
    Browse the repository at this point in the history
  4. Use doc comments for feature gate descriptions

    This is just in preparation for future usage of these texts.
    killercup committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    c9619a4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5299d8a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1ba7550 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0bbea47 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    30b841d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d34ee76 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5f57fee View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f852c7c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    21d9b85 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a4a34ab View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    7b59b4f View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    dc5bbaf View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    6498959 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    39f5e5b View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    8f6a0cd View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    b7178ef View commit details
    Browse the repository at this point in the history
  20. parser: document parse_pat.

    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    92d66a1 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    95792b4 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    5f6bec8 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    a9af18b View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    f35432e View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    d3b3bce View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    1ffea18 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    b205055 View commit details
    Browse the repository at this point in the history
  28. parser: bool -> GateOr.

    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    b2966e6 View commit details
    Browse the repository at this point in the history
  29. parser: bool -> TopLevel.

    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    a9ef859 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    3a40542 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    e374772 View commit details
    Browse the repository at this point in the history
  32. parser: reword || recovery.

    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    0ab8430 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    1202cb0 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    083963e View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2019

  1. Configuration menu
    Copy the full SHA
    1caaa40 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6a73199 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    acb1130 View commit details
    Browse the repository at this point in the history
  4. Introduce and use Feature type for feature gates

    This replaces the ad-hoc tuples used in the different feature gate files
    and unifies their content into a common type, leading to more readable
    matches and other good stuff that comes from having named fields. It
    also contains the description of each feature as extracted from the doc
    comment.
    killercup committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    c9d9616 View commit details
    Browse the repository at this point in the history
  5. Refactor feature gate checking code

    Tries to clarify the filtering of active features and make the code more
    expressive.
    killercup committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    94e8ff4 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2019

  1. add link to FileCheck docs

    RalfJung committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    633f67a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2bd27fb View commit details
    Browse the repository at this point in the history
  3. review comment

    estebank committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    7def99a View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#63317 - estebank:dead-code, r=matthewjasper

    Do not complain about unused code when used in `impl` `Self` type
    
    Fix rust-lang#18290.
    Centril authored Aug 26, 2019
    Configuration menu
    Copy the full SHA
    44cfa78 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#63693 - Centril:polish-parse-or-pats, r=est…

    …ebank
    
    Fully implement or-pattern parsing
    
    Builds upon the initial parsing in rust-lang#61708 to fully implement or-pattern (`p | q`) parsing as specified in [the grammar section of RFC 2535](https://github.com/rust-lang/rfcs/blob/master/text/2535-or-patterns.md#grammar).
    
    Noteworthy:
    
    - We allow or-patterns in `[p | q, ...]`.
    - We allow or-patterns in `let` statements and `for` expressions including with leading `|`.
    - We improve recovery for `p || q` (+ tests for that in `multiple-pattern-typo.rs`).
    - We improve recovery for `| p | q` in inner patterns (tests in `or-patterns-syntactic-fail.rs`).
    - We rigorously test or-pattern parsing (in `or-patterns-syntactic-{pass,fail}.rs`).
    - We harden the feature gating tests.
    - We do **_not_** change `ast.rs`. That is, `ExprKind::Let.0` and `Arm.pats` still accept `Vec<P<Pat>>`.
       I was starting work on that but it would be cleaner to do this in a separate PR so this one has a narrower scope.
    
    cc @dlrobertson
    cc the tracking issue rust-lang#54883.
    
    r? @estebank
    Centril authored Aug 26, 2019
    Configuration menu
    Copy the full SHA
    7dc3c93 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#63836 - Wind-River:master_003, r=alexcrichton

    VxWorks does not provide a way to set the task name except at creation time
    
    Make set_name do thing as VxWorks does not provide a way to set the task name except at creation time.
    
    r? @alexcrichton
    
    cc @n-salim
    Centril authored Aug 26, 2019
    Configuration menu
    Copy the full SHA
    9eeb7d5 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#63845 - DevQps:47091-remove-bad-example, r=…

    …nikomatsakis
    
    Removed a confusing FnOnce example
    
    # Description
    See rust-lang#47091 for a discussion.
    
    ## Changes
    - Removed an example that might suggest readers that square_x is (only) FnOnce.
    
    closes rust-lang#47091
    Centril authored Aug 26, 2019
    Configuration menu
    Copy the full SHA
    59fa966 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#63855 - killercup:refactor/feature-gates, r…

    …=Centril
    
    Refactor feature gates
    
    After rust-lang#63824, this goes a few steps further by
    
    - parsing doc comments in the macros to extract descriptions for feature gates, and
    - introducing a common `Feature` type to replace the tuples used previously to improve readability.
    
    The descriptions are not yet used, but I felt like this PR is a useful enough refactoring on its own.
    
    r? @Centril
    Centril authored Aug 26, 2019
    Configuration menu
    Copy the full SHA
    b005a89 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#63921 - RalfJung:file-check, r=alexcrichton

    add link to FileCheck docs
    
    Thanks @gnzlbg for pointing me to those docs.
    Centril authored Aug 26, 2019
    Configuration menu
    Copy the full SHA
    9c5c124 View commit details
    Browse the repository at this point in the history