Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom `PartialEq` impls for `LocalInternedString`. #65426

Conversation

@nnethercote
Copy link
Contributor

nnethercote commented Oct 15, 2019

This is on-trend with the recent changes simplifying
LocalInternedString and reducing its use.

r? @petrochenkov

This is on-trend with the recent changes simplifying
`LocalInternedString` and reducing its use.
@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Oct 15, 2019

I'm surprised how little fallout this had.
Probably because everything using comparisons was converted to symbols earlier.
With this little fallout we can remove this convenience feature.
@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 15, 2019

📌 Commit 57d33b1 has been approved by petrochenkov

Centril added a commit to Centril/rust that referenced this pull request Oct 15, 2019
…String-PartialEq-impls, r=petrochenkov

Remove custom `PartialEq` impls for `LocalInternedString`.

This is on-trend with the recent changes simplifying
`LocalInternedString` and reducing its use.

r? @petrochenkov
bors added a commit that referenced this pull request Oct 15, 2019
Rollup of 4 pull requests

Successful merges:

 - #64035 (Stabilize proc macros generating `macro_rules` items)
 - #65376 (syntax: misc extractions)
 - #65426 (Remove custom `PartialEq` impls for `LocalInternedString`.)
 - #65428 (Refactor: Rename `db` locals to `diag`)

Failed merges:

r? @ghost
@bors bors merged commit 57d33b1 into rust-lang:master Oct 15, 2019
4 checks passed
4 checks passed
pr Build #20191015.6 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
phansch added a commit to phansch/rust-clippy that referenced this pull request Oct 15, 2019
lzutao added a commit to lzutao/rust-clippy that referenced this pull request Oct 15, 2019
lzutao added a commit to lzutao/rust-clippy that referenced this pull request Oct 15, 2019
lzutao added a commit to lzutao/rust-clippy that referenced this pull request Oct 15, 2019
@nnethercote nnethercote deleted the nnethercote:rm-custom-LocalInternedString-PartialEq-impls branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.