Clean-up AST construction in syntax::ext #6611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @jbclements |
bors
added a commit
that referenced
this pull request
May 21, 2013
Fixes #6578 by merging the 3 different ways to build an AST into a single `AstBuilder` trait, creating a more uniform and briefer interface. Also, converts the `ext_ctxt` trait-object to be a plain struct, as well as renaming it to `ExtCtxt`. Seems to make expansion slightly faster for the normal case (e.g. `libcore` and `libstd`), but slower for `librustc` (slightly) and `libsyntax` (0.3s -> 0.8s! I'm investigating this, but I'd prefer this patch to land relatively quickly.). `git blame` suggests maybe @graydon or @erickt are familiar with this area of the code. r?
Merged
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 30, 2021
Fix the reversed suggestion message of `stable_sort_primitive`. Now Clippy emits `stable_sort_primitive` warning as follows: ``` warning: used sort instead of sort_unstable to sort primitive type `usize` --> src\asm.rs:41:13 | 41 | self.successors.sort(); | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.successors.sort_unstable()` | = note: `#[warn(clippy::stable_sort_primitive)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#stable_sort_primitive ``` I think the position of `sort` and `sort_unstable` in the first line should be reversed. changelog: Fix the reversed suggestion message of `stable_sort_primitive`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6578 by merging the 3 different ways to build an AST into a single
AstBuildertrait, creating a more uniform and briefer interface.Also, converts the
ext_ctxttrait-object to be a plain struct, as well as renaming it toExtCtxt.Seems to make expansion slightly faster for the normal case (e.g.
libcoreandlibstd), but slower forlibrustc(slightly) andlibsyntax(0.3s -> 0.8s! I'm investigating this, but I'd prefer this patch to land relatively quickly.).git blamesuggests maybe @graydon or @erickt are familiar with this area of the code. r?