librustc: Only emit visitor glue if it's necessary. #6744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
500K to 600K shaved off librustc.
bors
added a commit
that referenced
this pull request
May 28, 2013
|
@pcwalton what's up with this? Something you can fix or should this be closed for now? |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 25, 2021
more lintcheck updates * do some refactoring and renaming here and there * add comments to functions * fix bug where git repos would not get checked out to the proper commits (cmd was not actually run in repo directory 😅 ) * print warnings if we can't clone or check out a git repo * filter out noise from cargo-metadata errors and lint messages that contained absolute file paths (these would change with every pinned-nightly bump, polluting the logs) changelog: more lintcheck refactoring and fixes for git crates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @graydon