Rollup of 10 pull requests #71907
Merged
Rollup of 10 pull requests #71907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already tested (at least) by src/test/ui/unsized/unsized-enum2.rs
This is tracked by a GH issue 17164, and having an ignored test for it isn't helpful.
And also point people to use the associated constants of f32 instead.
The `remove_current` method only returns the inner `T` and deallocates the list node. This is unnecessary for move operations, where the element is going to be linked back into this (or even a different) `LinkedList`. The `remove_current_as_list` method avoids this by returning the unlinked list node as a new single-element `LinkedList` structure .
It looks like they were copied from the `or_insert` docs. This change makes the example more like the hash_map::VacantEntry::insert docs.
… r=nikomatsakis Report cannot move errors in promoted MIR Closes rust-lang#70934
…ikomatsakis Updates to some ignored tests This removes or fixes some ignored test cases. cc rust-lang#13745
…dtolnay Add const examples I only added them to `std::f32` to get feedback on this approach before adding the other constants. When looking at rust-lang#68952, I found the docs a little confusing. Unless you're intimately aware of what's going on here, I don't think it's super clear what is deprecated and what you're supposed to do instead. I think short examples really clarify what's meant here, so that's what I did.
Add remove_current_as_list to LinkedList's CursorMut The `remove_current` method only returns the inner `T` and deallocates the list node. This is unnecessary for move operations, where the element is going to be linked back into this (or even a different) `LinkedList`. The `remove_current_as_list` method avoids this by returning the unlinked list node as a new single-element `LinkedList` structure. (per rust-lang#58533 (comment))
Correctly handle UEFI targets as Windows-like when emitting sections for LLVM bitcode This handles UEFI handles when emitting inline assembly for sections containing LLVM bitcode. See details in rust-lang#71880. I have locally confirmed that this change fixes compilation of projects using the `x86_64-unknown-uefi` target compiling with `cargo-xbuild`, but I am not very familiar with LLVM bitcode so this may not be the correct approach. r? @alexcrichton as they wrote the initial LLVM bitcode emitting code?
add a missing "at" in a comment
¬∃x. ¬y => ∀x. y
…docs, r=jonas-schievink Update btree_map::VacantEntry::insert docs to actually call insert It looks like they were copied from the `or_insert` docs. This change makes the example more like the hash_map::VacantEntry::insert docs.
Suggest to add missing feature when using gated const features Fixes rust-lang#71797
…vink fix typo in function name Drive-by fix.
|
@bors r+ rollup=never p=10 |
|
📌 Commit 8b781b0 has been approved by |
bors
added
the
S-waiting-on-bors
|
@bors r+ |
|
@jyn514: 🔑 Insufficient privileges: Not in reviewers |
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost