Fix logging for rustdoc #75081
Merged
Fix logging for rustdoc #75081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Going to go ahead and approve this so we get unbroken faster. I suspect that this is the right long-term fix anyway. @bors r+ |
|
📌 Commit e97e6fb has been approved by |
bors
added
S-waiting-on-bors
pickfire
reviewed
Aug 3, 2020
| @@ -43,7 +43,7 @@ extern crate rustc_trait_selection; | |||
| extern crate rustc_typeck; | |||
| extern crate test as testing; | |||
| #[macro_use] | |||
| extern crate log; | |||
| extern crate tracing as log; | |||
There was a problem hiding this comment.
Why not just change all log to tracing instead?
There was a problem hiding this comment.
This was less work 🤷 feel free to make a follow-up PR
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 3, 2020
Fix logging for rustdoc rust-lang#74726 (comment)
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 3, 2020
Fix logging for rustdoc rust-lang#74726 (comment)
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 3, 2020
Fix logging for rustdoc rust-lang#74726 (comment)
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 3, 2020
Fix logging for rustdoc rust-lang#74726 (comment)
ollie27
added
the
T-rustdoc
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 4, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#74759 (add `unsigned_abs` to signed integers) - rust-lang#75043 (rustc_ast: `(Nested)MetaItem::check_name` -> `has_name`) - rust-lang#75056 (Lint path statements to suggest using drop when the type needs drop) - rust-lang#75081 (Fix logging for rustdoc) - rust-lang#75083 (Do not trigger `unused_braces` for `while let`) - rust-lang#75084 (Stabilize Ident::new_raw) - rust-lang#75103 (Disable building rust-analyzer on riscv64) - rust-lang#75106 (Enable docs on in the x86_64-unknown-linux-musl manifest) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#74726 (comment)