Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove two fields from `SubstFolder`. #75133

Merged
merged 1 commit into from Aug 4, 2020

Conversation

@nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Aug 4, 2020

They're only used in error messages printed if there's an internal
compiler error, and the cost of maintaining them is high enough to show
up in profiles.

r? @matthewjasper

@nnethercote
Copy link
Contributor Author

@nnethercote nnethercote commented Aug 4, 2020

Some local measurements:

wf-projection-stress-65510-che...
        avg: -1.6%      min: -2.5%      max: -0.0%
ctfe-stress-4-check
        avg: -0.3%?     min: -0.5%?     max: -0.0%?
packed-simd-check
        avg: -0.2%      min: -0.3%      max: -0.0%
regression-31157-check
        avg: -0.1%      min: -0.3%      max: -0.0%
futures-check
        avg: -0.1%      min: -0.3%      max: -0.0%
wg-grammar-check
        avg: -0.2%      min: -0.2%      max: -0.0%
piston-image-check
        avg: -0.1%      min: -0.2%      max: -0.0%
ripgrep-check
        avg: -0.1%      min: -0.2%      max: 0.0%
serde-check
        avg: -0.1%      min: -0.2%      max: -0.0%
hyper-2-check
        avg: -0.1%      min: -0.2%      max: -0.0%
cargo-check
        avg: -0.1%      min: -0.2%      max: -0.0%

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

@rust-timer rust-timer commented Aug 4, 2020

Awaiting bors try build completion

@bors
Copy link
Contributor

@bors bors commented Aug 4, 2020

Trying commit ff51bdc with merge 0b19afe...

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 4, 2020
…<try>

Remove two fields from `SubstFolder`.

They're only used in error messages printed if there's an internal
compiler error, and the cost of maintaining them is high enough to show
up in profiles.

r? @matthiaskrgr
@bors
Copy link
Contributor

@bors bors commented Aug 4, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 0b19afe (0b19afee13894f423bd57e571688ba5631ec40ce)

@rust-timer
Copy link
Collaborator

@rust-timer rust-timer commented Aug 4, 2020

Queued 0b19afe with parent 80f84eb, future comparison URL.

@matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Aug 4, 2020

Did you mean to r? matthewjasper perhaps?

@nnethercote
Copy link
Contributor Author

@nnethercote nnethercote commented Aug 4, 2020

Did you mean to r? matthewjasper perhaps?

GitHub suggested you as a reviewer, but it sounds like that wasn't a good suggestion.

r? @matthewjasper

They're only used in error messages printed if there's an internal
compiler error, and the cost of maintaining them is high enough to show
up in profiles.
@nnethercote nnethercote force-pushed the nnethercote:rm-SubstFolder-fields branch from ff51bdc to eeb4b83 Aug 4, 2020
@matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Aug 4, 2020

That's strange, I don't think I am in the reviewers list/have r+ powers 😅

@rust-timer
Copy link
Collaborator

@rust-timer rust-timer commented Aug 4, 2020

Finished benchmarking try commit (0b19afe): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@matthewjasper
Copy link
Contributor

@matthewjasper matthewjasper commented Aug 4, 2020

@bors r+

@bors
Copy link
Contributor

@bors bors commented Aug 4, 2020

📌 Commit eeb4b83 has been approved by matthewjasper

@bors
Copy link
Contributor

@bors bors commented Aug 4, 2020

Testing commit eeb4b83 with merge d08eb98...

@bors
Copy link
Contributor

@bors bors commented Aug 4, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: matthewjasper
Pushing d08eb98 to master...

@bors bors added the merged-by-bors label Aug 4, 2020
@bors bors merged commit d08eb98 into rust-lang:master Aug 4, 2020
12 checks passed
12 checks passed
PR (mingw-check, ubuntu-latest-xl)
Details
PR (x86_64-gnu-llvm-8, ubuntu-latest-xl)
Details
PR (x86_64-gnu-tools, 1, ubuntu-latest-xl)
Details
try
Details
auto
Details
auto-fallible
Details
master
Details
bors build finished
Details
bors build finished
Details
bors build finished
Details
bors build finished
Details
homu Test successful
Details
@nnethercote nnethercote deleted the nnethercote:rm-SubstFolder-fields branch Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.