Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Remove two fields from `SubstFolder`. #75133
Conversation
|
Some local measurements:
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
…<try> Remove two fields from `SubstFolder`. They're only used in error messages printed if there's an internal compiler error, and the cost of maintaining them is high enough to show up in profiles. r? @matthiaskrgr
|
|
|
Queued 0b19afe with parent 80f84eb, future comparison URL. |
|
Did you mean to |
GitHub suggested you as a reviewer, but it sounds like that wasn't a good suggestion. |
They're only used in error messages printed if there's an internal compiler error, and the cost of maintaining them is high enough to show up in profiles.
ff51bdc
to
eeb4b83
|
That's strange, I don't think I am in the reviewers list/have r+ powers |
|
Finished benchmarking try commit (0b19afe): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
|
@bors r+ |
|
|
|
|
They're only used in error messages printed if there's an internal
compiler error, and the cost of maintaining them is high enough to show
up in profiles.
r? @matthewjasper