Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show multi extension example for Path in doctests #75262

Merged
merged 1 commit into from
Aug 9, 2020

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Aug 7, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 7, 2020
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup=always

The foo.tar behavior is surprising to me!

@jyn514
Copy link
Member

jyn514 commented Aug 8, 2020

@bors r+ rollup=always

Looks like bors was confused because it was a 'review'.

@bors
Copy link
Contributor

bors commented Aug 8, 2020

📌 Commit 06cf40f has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2020
@pickfire
Copy link
Contributor Author

pickfire commented Aug 8, 2020

The foo.tar behavior is surprising to me!

Not just you, me too.

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 8, 2020
Rollup of 15 pull requests

Successful merges:

 - rust-lang#74712 (Update E0271 explanation)
 - rust-lang#74842 (adjust remaining targets)
 - rust-lang#75151 (Consistent variable name alloc for raw_vec)
 - rust-lang#75162 (Fix the documentation for move about Fn traits implementations)
 - rust-lang#75248 (Add `as_mut_ptr` to `NonNull<[T]>`)
 - rust-lang#75262 (Show multi extension example for Path in doctests)
 - rust-lang#75266 (Add safety section to `NonNull::as_*` method docs)
 - rust-lang#75284 (Show relative example for Path ancestors)
 - rust-lang#75285 (Separate example for Path strip_prefix)
 - rust-lang#75287 (Show Path extension example change multi extension)
 - rust-lang#75288 (Use assert! for Path exists example to check bool)
 - rust-lang#75289 (Remove ambiguity from PathBuf pop example)
 - rust-lang#75290 (fix `min_const_generics` version)
 - rust-lang#75291 (Clean up E0750)
 - rust-lang#75292 (Clean up E0502)

Failed merges:

r? @ghost
@bors bors merged commit cbc6914 into rust-lang:master Aug 9, 2020
@pickfire pickfire deleted the patch-6 branch August 9, 2020 02:49
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants