Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up E0750 #75291

Merged
merged 2 commits into from
Aug 9, 2020
Merged

Clean up E0750 #75291

merged 2 commits into from
Aug 9, 2020

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2020
@rust-lang rust-lang deleted a comment from rust-highfive Aug 8, 2020
pickfire
pickfire suggested changes Aug 8, 2020
View reviewed changes
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than the mentioned change.

src/librustc_error_codes/error_codes/E0750.md Outdated Show resolved Hide resolved
@GuillaumeGomez
Copy link
Member Author

@pickfire Thanks for the review! Updated.

@GuillaumeGomez
Copy link
Member Author

@bors: r=pickfire rollup

@bors
Copy link
Contributor

bors commented Aug 8, 2020

📌 Commit 17db7a4 has been approved by pickfire

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2020
@JohnTitor JohnTitor mentioned this pull request Aug 8, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 8, 2020
@bors
Auto merge of rust-lang#75308 - JohnTitor:rollup-vnnny43, r=JohnTitor
dcf1077 
Rollup of 15 pull requests

Successful merges:

 - rust-lang#74712 (Update E0271 explanation)
 - rust-lang#74842 (adjust remaining targets)
 - rust-lang#75151 (Consistent variable name alloc for raw_vec)
 - rust-lang#75162 (Fix the documentation for move about Fn traits implementations)
 - rust-lang#75248 (Add `as_mut_ptr` to `NonNull<[T]>`)
 - rust-lang#75262 (Show multi extension example for Path in doctests)
 - rust-lang#75266 (Add safety section to `NonNull::as_*` method docs)
 - rust-lang#75284 (Show relative example for Path ancestors)
 - rust-lang#75285 (Separate example for Path strip_prefix)
 - rust-lang#75287 (Show Path extension example change multi extension)
 - rust-lang#75288 (Use assert! for Path exists example to check bool)
 - rust-lang#75289 (Remove ambiguity from PathBuf pop example)
 - rust-lang#75290 (fix `min_const_generics` version)
 - rust-lang#75291 (Clean up E0750)
 - rust-lang#75292 (Clean up E0502)

Failed merges:

r? @ghost
@bors bors merged commit bc3ee48 into rust-lang:master Aug 9, 2020
@GuillaumeGomez GuillaumeGomez deleted the cleanup-e0750 branch August 9, 2020 03:23
@pickfire pickfire mentioned this pull request Aug 9, 2020
Merged
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickfire pickfire pickfire approved these changes

Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @bors @pickfire @cuviper @rust-highfive @Dylan-DPC-zz