Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polymorphize: if any param in a predicate is used, then all are used #75595

Merged
merged 1 commit into from
Aug 20, 2020
Merged

polymorphize: if any param in a predicate is used, then all are used #75595

merged 1 commit into from
Aug 20, 2020

Conversation

davidtwco
Copy link
Member

Addresses review comments from @eddyb in #75518 that I didn't get to resolve before bors merged.

This PR modifies polymorphization's handling of predicates so that if any generic parameter is used in a predicate then all parameters in that predicate are used.

r? @eddyb

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2020
@davidtwco davidtwco mentioned this pull request Aug 16, 2020
Merged
eddyb
eddyb approved these changes Aug 16, 2020
View reviewed changes
Copy link
Member

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with or without removing the predicate kind filtering

@eddyb eddyb added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2020
@davidtwco
polymorphize: ∃ used param ∈ predicate → all used
5703b28 
This commit modifies polymorphization's handling of predicates so that
if any generic parameter is used in a predicate then all parameters in
that predicate are used.

Signed-off-by: David Wood <david@davidtw.co>
@davidtwco davidtwco force-pushed the polymorphization-predicate-simplification-correction branch from 71d4741 to 5703b28 Compare August 17, 2020 13:14
@davidtwco davidtwco added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 17, 2020
@eddyb
Copy link
Member

eddyb commented Aug 18, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Aug 18, 2020

📌 Commit 5703b28 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2020
@bors
Copy link
Contributor

bors commented Aug 20, 2020

⌛ Testing commit 5703b28 with merge 1a22a0f...

@bors
Copy link
Contributor

bors commented Aug 20, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: eddyb
Pushing 1a22a0f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 20, 2020
@bors bors merged commit 1a22a0f into rust-lang:master Aug 20, 2020
@davidtwco davidtwco deleted the polymorphization-predicate-simplification-correction branch August 20, 2020 10:09
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb eddyb approved these changes

Assignees

@eddyb eddyb

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
5 participants
@davidtwco @eddyb @bors @cuviper @rust-highfive