Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--test-args flag description #78243

Merged
merged 1 commit into from
Oct 24, 2020
Merged

--test-args flag description #78243

merged 1 commit into from
Oct 24, 2020

Conversation

njasm
Copy link
Contributor

@njasm njasm commented Oct 22, 2020 •
edited
Loading

tiny enhancement/clarification for the help description of the --test-args option from x.py test subcommand.

Edit: ...as discussed in zulip here

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 22, 2020
@njasm
Copy link
Contributor Author

njasm commented Oct 22, 2020

r? @jyn514

@Mark-Simulacrum
Copy link
Member

Hm, I agree clarifying this is good, but we don't actually pass these to Cargo really -- rather, they get passed to the tool being run, which could be:

  • libtest, via cargo test -- <--test-args go here>
  • compiletest, directly
  • rustdoc --test-args, I think threading into libtest again

I'm not quite sure how to unify those into something short -- maybe "Arguments for the test tool being used"?

@njasm
Copy link
Contributor Author

njasm commented Oct 22, 2020

@Mark-Simulacrum Yes I agree with that. my bad I assumed that those were only for cargo.

I can change it now, or I can wait for @jyn514 to jump in with his opinion, so we all can settle in a phrase before i push something again? what you think, sounds like a plan?

jyn514
jyn514 reviewed Oct 22, 2020
View reviewed changes
src/bootstrap/flags.rs Outdated Show resolved Hide resolved
@jyn514 jyn514 added A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-enhancement Category: An issue proposing an enhancement or a PR with one. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 23, 2020

@njasm do you mind squashing the commits into one? There are instructions at https://rustc-dev-guide.rust-lang.org/git.html#advanced-rebasing, if you have trouble it's ok to keep it as-is though.

r=me after that.

@njasm njasm force-pushed the patch_test_args_description branch from 94ebd1d to c3cbaf6 Compare October 23, 2020 19:12
@njasm
Copy link
Contributor Author

njasm commented Oct 23, 2020

I think the rebase went well 😅

@rustbot modify labels: -S-waiting-on-author +S-waiting-on-review

?r @jyn514

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 23, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 23, 2020

@bors r+ rollup

Thanks for working on this!

@bors
Copy link
Contributor

bors commented Oct 23, 2020

📌 Commit c3cbaf6 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2020
@jonas-schievink jonas-schievink mentioned this pull request Oct 23, 2020
Closed
@jonas-schievink jonas-schievink mentioned this pull request Oct 24, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 24, 2020
@bors
Auto merge of rust-lang#78319 - jonas-schievink:rollup-vzj8a6l, r=jon…
89fdb30 
…as-schievink

Rollup of 15 pull requests

Successful merges:

 - rust-lang#76649 (Add a spin loop hint for Arc::downgrade)
 - rust-lang#77392 (add `insert` to `Option`)
 - rust-lang#77716 (Revert "Allow dynamic linking for iOS/tvOS targets.")
 - rust-lang#78109 (Check for exhaustion in RangeInclusive::contains and slicing)
 - rust-lang#78198 (Simplify assert terminator only if condition evaluates to expected value)
 - rust-lang#78243 (--test-args flag description)
 - rust-lang#78249 (improve const infer error)
 - rust-lang#78250 (Document inline-const)
 - rust-lang#78264 (Add regression test for issue-77475)
 - rust-lang#78274 (Update description of Empty Enum for accuracy)
 - rust-lang#78278 (move `visit_predicate` into `TypeVisitor`)
 - rust-lang#78292 (Loop instead of recursion)
 - rust-lang#78293 (Always store Rustdoc theme when it's changed)
 - rust-lang#78300 (Make codegen coverage_context optional, and check)
 - rust-lang#78307 (Revert "Set .llvmbc and .llvmcmd sections as allocatable")

Failed merges:

r? `@ghost`
@bors bors merged commit 6b2ed99 into rust-lang:master Oct 24, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 24, 2020
@njasm njasm deleted the patch_test_args_description branch October 25, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@jyn514 jyn514

Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-enhancement Category: An issue proposing an enhancement or a PR with one. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
6 participants
@njasm @rust-highfive @Mark-Simulacrum @jyn514 @bors @rustbot