Skip to content

Conversation

camelid
Copy link
Member

@camelid camelid commented Oct 22, 2020

Part of #76001.

r? @spastorino

@camelid camelid added F-inline_const Inline constants (aka: const blocks, const expressions, anonymous constants) A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-lang Relevant to the language team labels Oct 22, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 22, 2020
@camelid
Copy link
Member Author

camelid commented Oct 22, 2020

Do I need to update the Reference?

@spastorino
Copy link
Member

@camelid so far so good but to be honest I'm not sure exactly how tnew features should be documented.

@camelid camelid force-pushed the document-inline-const branch from dc8604f to fa77c6f Compare October 22, 2020 21:47
@camelid camelid force-pushed the document-inline-const branch from fa77c6f to 9775ac6 Compare October 23, 2020 00:08
@camelid
Copy link
Member Author

camelid commented Oct 23, 2020

Joshua Nelson and scottmcm said just the Unstable Book book is fine, so I think this should be ready!

@camelid camelid marked this pull request as ready for review October 23, 2020 03:24
@spastorino
Copy link
Member

@bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented Oct 23, 2020

📌 Commit 9775ac6 has been approved by spastorino

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 24, 2020
…as-schievink

Rollup of 15 pull requests

Successful merges:

 - rust-lang#76649 (Add a spin loop hint for Arc::downgrade)
 - rust-lang#77392 (add `insert` to `Option`)
 - rust-lang#77716 (Revert "Allow dynamic linking for iOS/tvOS targets.")
 - rust-lang#78109 (Check for exhaustion in RangeInclusive::contains and slicing)
 - rust-lang#78198 (Simplify assert terminator only if condition evaluates to expected value)
 - rust-lang#78243 (--test-args flag description)
 - rust-lang#78249 (improve const infer error)
 - rust-lang#78250 (Document inline-const)
 - rust-lang#78264 (Add regression test for issue-77475)
 - rust-lang#78274 (Update description of Empty Enum for accuracy)
 - rust-lang#78278 (move `visit_predicate` into `TypeVisitor`)
 - rust-lang#78292 (Loop instead of recursion)
 - rust-lang#78293 (Always store Rustdoc theme when it's changed)
 - rust-lang#78300 (Make codegen coverage_context optional, and check)
 - rust-lang#78307 (Revert "Set .llvmbc and .llvmcmd sections as allocatable")

Failed merges:

r? `@ghost`
@bors bors merged commit 20ba9ff into rust-lang:master Oct 24, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 24, 2020
@camelid camelid deleted the document-inline-const branch October 24, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools F-inline_const Inline constants (aka: const blocks, const expressions, anonymous constants) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants