Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some more code out of CodegenBackend::{codegen_crate,link} #79662

Merged
merged 2 commits into from
Dec 28, 2020

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Dec 3, 2020

Kind of a follow up to #77795

@bjorn3 bjorn3 added A-driver Area: rustc_driver that ties everything together into the `rustc` compiler T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 3, 2020
@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 3, 2020
@bjorn3 bjorn3 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2020
@bjorn3 bjorn3 force-pushed the move_more_code_out_of_codegen_backend branch from b77990e to 2638e38 Compare December 3, 2020 15:06
@bjorn3 bjorn3 force-pushed the move_more_code_out_of_codegen_backend branch from 2638e38 to 2c0dccb Compare December 17, 2020 09:02
@bjorn3
Copy link
Member Author

bjorn3 commented Dec 17, 2020

Fixed the tests.

@bjorn3 bjorn3 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Dec 28, 2020

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned eddyb Dec 28, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Dec 28, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Dec 28, 2020

📌 Commit 3a3a23f has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 28, 2020
…n_backend, r=oli-obk

Move some more code out of CodegenBackend::{codegen_crate,link}

Kind of a follow up to rust-lang#77795
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 28, 2020
Rollup of 11 pull requests

Successful merges:

 - rust-lang#79662 (Move some more code out of CodegenBackend::{codegen_crate,link})
 - rust-lang#79815 (Update RELEASES.md for 1.49.0)
 - rust-lang#80284 (Suggest fn ptr rather than fn item and suggest to use `Fn` trait bounds rather than the unique closure type in E0121)
 - rust-lang#80331 (Add more comments to trait queries)
 - rust-lang#80344 (use matches!() macro in more places)
 - rust-lang#80353 (BTreeMap: test split_off (and append) more thoroughly)
 - rust-lang#80362 (Document rustc_macros on nightly-rustc)
 - rust-lang#80399 (Remove FIXME in rustc_privacy)
 - rust-lang#80408 (Sync rustc_codegen_cranelift)
 - rust-lang#80411 (rustc_span: Remove `Symbol::with`)
 - rust-lang#80434 (bootstrap: put the component name in the tarball temp dir path)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 98d80bd into rust-lang:master Dec 28, 2020
@bors
Copy link
Contributor

bors commented Dec 28, 2020

⌛ Testing commit 3a3a23f with merge 2987785...

@rustbot rustbot added this to the 1.51.0 milestone Dec 28, 2020
@bjorn3 bjorn3 deleted the move_more_code_out_of_codegen_backend branch December 28, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants