Add match pattern diagnostics regression test #81897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
vandenheuvel
force-pushed
the
match_exhaustive_diagnostics_regression_test
branch
from
0b61d07
to
1bcd946
Compare
This comment has been minimized.
This comment has been minimized.
vandenheuvel
force-pushed
the
match_exhaustive_diagnostics_regression_test
branch
from
1bcd946
to
451f591
Compare
This comment has been minimized.
This comment has been minimized.
vandenheuvel
force-pushed
the
match_exhaustive_diagnostics_regression_test
branch
from
451f591
to
e3bfc24
Compare
This comment has been minimized.
This comment has been minimized.
vandenheuvel
force-pushed
the
match_exhaustive_diagnostics_regression_test
branch
from
e3bfc24
to
5339b43
Compare
|
r=me with spuriously added timings.ods removed |
Mark-Simulacrum
added
S-waiting-on-author
vandenheuvel
force-pushed
the
match_exhaustive_diagnostics_regression_test
branch
from
5339b43
to
5fe8490
Compare
|
@Mark-Simulacrum removed that, thanks for paying attention. |
|
@bors r+ rollup |
|
📌 Commit 5fe8490 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 15, 2021
…ostics_regression_test, r=Mark-Simulacrum Add match pattern diagnostics regression test Closes rust-lang#72377 by adding a regression test. This test case fails on stable but now works on beta and nightly. It *should* have worked already for years, the crucial point whether it is mentioned that some uncovered patterns are not explicitly mentioned.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 15, 2021
…ostics_regression_test, r=Mark-Simulacrum Add match pattern diagnostics regression test Closes rust-lang#72377 by adding a regression test. This test case fails on stable but now works on beta and nightly. It *should* have worked already for years, the crucial point whether it is mentioned that some uncovered patterns are not explicitly mentioned.
This was referenced Feb 15, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 16, 2021
…as-schievink Rollup of 19 pull requests Successful merges: - rust-lang#81503 (Suggest to create a new `const` item if the `fn` in the array is a `const fn`) - rust-lang#81897 (Add match pattern diagnostics regression test) - rust-lang#81975 (Seal the CommandExt, OsStrExt and OsStringExt traits) - rust-lang#82009 (const_generics: Dont evaluate array length const when handling errors) - rust-lang#82060 (Fix typos in BTreeSet::{first, last} docs) - rust-lang#82061 (CTFE validation: catch ReadPointerAsBytes and better error) - rust-lang#82063 (Fixed minor typo in catch_unwind docs) - rust-lang#82067 (const_generics: Fix incorrect ty::ParamEnv::empty() usage) - rust-lang#82077 (Edit `rustc_arena::DropArena` docs) - rust-lang#82096 (Fix a typo) - rust-lang#82106 (Remove unnecessary `Option` in `default_doc`) - rust-lang#82107 (expand: Some cleanup) - rust-lang#82118 (Add missing env!-decl variant) - rust-lang#82119 (Fix typo in link to CreateSymbolicLinkW documentation.) - rust-lang#82120 (Stabilize Arguments::as_str) - rust-lang#82129 (Remove redundant bool_to_option feature gate) - rust-lang#82133 (Update link for extern prelude.) - rust-lang#82141 (32-bit ARM: Emit `lr` instead of `r14` when specified as an `asm!` output register.) - rust-lang#82147 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
vandenheuvel
deleted the
match_exhaustive_diagnostics_regression_test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72377 by adding a regression test.
This test case fails on stable but now works on beta and nightly. It should have worked already for years, the crucial point whether it is mentioned that some uncovered patterns are not explicitly mentioned.