CTFE validation: catch ReadPointerAsBytes and better error #82061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit d6dcb3d has been approved by |
bors
added
S-waiting-on-bors
This was referenced Feb 15, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 16, 2021
…as-schievink Rollup of 19 pull requests Successful merges: - rust-lang#81503 (Suggest to create a new `const` item if the `fn` in the array is a `const fn`) - rust-lang#81897 (Add match pattern diagnostics regression test) - rust-lang#81975 (Seal the CommandExt, OsStrExt and OsStringExt traits) - rust-lang#82009 (const_generics: Dont evaluate array length const when handling errors) - rust-lang#82060 (Fix typos in BTreeSet::{first, last} docs) - rust-lang#82061 (CTFE validation: catch ReadPointerAsBytes and better error) - rust-lang#82063 (Fixed minor typo in catch_unwind docs) - rust-lang#82067 (const_generics: Fix incorrect ty::ParamEnv::empty() usage) - rust-lang#82077 (Edit `rustc_arena::DropArena` docs) - rust-lang#82096 (Fix a typo) - rust-lang#82106 (Remove unnecessary `Option` in `default_doc`) - rust-lang#82107 (expand: Some cleanup) - rust-lang#82118 (Add missing env!-decl variant) - rust-lang#82119 (Fix typo in link to CreateSymbolicLinkW documentation.) - rust-lang#82120 (Stabilize Arguments::as_str) - rust-lang#82129 (Remove redundant bool_to_option feature gate) - rust-lang#82133 (Update link for extern prelude.) - rust-lang#82141 (32-bit ARM: Emit `lr` instead of `r14` when specified as an `asm!` output register.) - rust-lang#82147 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Feb 16, 2021
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 16, 2021
validation: fix invalid-fn-ptr error message rust-lang#82061 changed the code here to print an `ImmTy` instead of a `ScalarMaybeUninit`; that was an accident. So go back to printing a `ScalarMaybeUninit`. r? `@oli-obk`
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 16, 2021
validation: fix invalid-fn-ptr error message rust-lang#82061 changed the code here to print an `ImmTy` instead of a `ScalarMaybeUninit`; that was an accident. So go back to printing a `ScalarMaybeUninit`. r? ``@oli-obk``
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 16, 2021
validation: fix invalid-fn-ptr error message rust-lang#82061 changed the code here to print an `ImmTy` instead of a `ScalarMaybeUninit`; that was an accident. So go back to printing a `ScalarMaybeUninit`. r? ```@oli-obk```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk
Fixes #79690
Cc rust-lang/miri#1706