Move rustdoc UI tests into a subdirectory #82800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
the
A-testsuite
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jyn514
force-pushed
the
group-rustdoc-tests
branch
2 times, most recently
from
5ea970f
to
a0e98a4
Compare
JohnTitor
reviewed
Mar 5, 2021
jyn514
force-pushed
the
group-rustdoc-tests
branch
from
a0e98a4
to
e3997b0
Compare
|
@JohnTitor not sure if you have r+ permissions in rust-lang/rust or not, but just in case: @bors delegate=JohnTitor |
|
✌️ @JohnTitor can now approve this pull request |
|
I have but it's for making rollup and I'm not part of any teams that r+ PRs here (though this LGTM). So I'd wait for Mark (or someone else) to review it, sorry. |
This comment has been minimized.
This comment has been minimized.
jyn514
force-pushed
the
group-rustdoc-tests
branch
from
e3997b0
to
6328026
Compare
|
Seems to be an accidental submodule update, r=me with that removed. |
Mark-Simulacrum
added
S-waiting-on-author
This also adds a little leeway to the test limit.
jyn514
force-pushed
the
group-rustdoc-tests
branch
from
6328026
to
bc1fbf5
Compare
Thanks, fixed. @bors r=Mark-Simulacrum rollup |
|
📌 Commit bc1fbf5 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 9, 2021
Rollup of 11 pull requests Successful merges: - rust-lang#82711 (Add documentation for string->Cow conversions) - rust-lang#82767 (Update minifier dependency version) - rust-lang#82800 (Move rustdoc UI tests into a subdirectory) - rust-lang#82810 (Typo fix in Unstable book: `cargo cov` -> `cargo profdata`) - rust-lang#82829 (Handle negative literals in cast overflow warning) - rust-lang#82854 (Account for `if (let pat = expr) {}`) - rust-lang#82870 (Add note about the `#[doc(no-inline)]` usage) - rust-lang#82874 (Add codegen tests for some issues closed by LLVM 12) - rust-lang#82881 (diagnostics: Be clear about "crate root" and `::foo` paths in resolve diagnostics) - rust-lang#82888 (Grammar Fixes) - rust-lang#82897 ([.mailmap] Add entry for Ramkumar Ramachandra) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #73494.