Skip to content

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Mar 4, 2021

Very small PR simply upgrading the minifier-rs version we use in rustdoc.

Some details might be useful: there were a few bug fixes and a lot of cleanup/code improvements.

r? @camelid

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2021
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the update-minifier-crate-version branch from 3ac245d to fc08412 Compare March 4, 2021 17:08
@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Mar 4, 2021
@GuillaumeGomez GuillaumeGomez force-pushed the update-minifier-crate-version branch from fc08412 to e70eb22 Compare March 5, 2021 11:38
@GuillaumeGomez GuillaumeGomez force-pushed the update-minifier-crate-version branch from e70eb22 to 6052211 Compare March 5, 2021 20:18
@GuillaumeGomez
Copy link
Member Author

ping @camelid

@camelid
Copy link
Member

camelid commented Mar 7, 2021

I don't know our process for updating dependencies, so I'd rather have someone else review this.

@camelid camelid removed their assignment Mar 7, 2021
@GuillaumeGomez
Copy link
Member Author

r? @jyn514

@jyn514
Copy link
Member

jyn514 commented Mar 7, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 7, 2021

📌 Commit 6052211 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 7, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2021
Rollup of 11 pull requests

Successful merges:

 - rust-lang#82711 (Add documentation for string->Cow conversions)
 - rust-lang#82767 (Update minifier dependency version)
 - rust-lang#82800 (Move rustdoc UI tests into a subdirectory)
 - rust-lang#82810 (Typo fix in Unstable book: `cargo cov` -> `cargo profdata`)
 - rust-lang#82829 (Handle negative literals in cast overflow warning)
 - rust-lang#82854 (Account for `if (let pat = expr) {}`)
 - rust-lang#82870 (Add note about the `#[doc(no-inline)]` usage)
 - rust-lang#82874 (Add codegen tests for some issues closed by LLVM 12)
 - rust-lang#82881 (diagnostics: Be clear about "crate root" and `::foo` paths in resolve diagnostics)
 - rust-lang#82888 (Grammar Fixes)
 - rust-lang#82897 ([.mailmap] Add entry for Ramkumar Ramachandra)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6e9a94a into rust-lang:master Mar 9, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 9, 2021
@GuillaumeGomez GuillaumeGomez deleted the update-minifier-crate-version branch March 9, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants