Fix HashMap/HashSet LLDB pretty-printer after hashbrown 0.11.0 #83920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
The pretty-printer was broken in rust-lang#77566 after updating hashbrown to 0.11.0. Note that the corresponding GDB pretty-printer was updated properly.
artemmukhin
force-pushed
the
fix-hashmap-lldb-pretty-printer-1.52
branch
from
d057468
to
3d3a5ca
Compare
artemmukhin
changed the title
artemmukhin
added a commit
to intellij-rust/intellij-rust
that referenced
this pull request
Apr 6, 2021
The corresponding PRs in rustc: rust-lang/rust#77566 rust-lang/rust#83920
|
@bors r+ |
|
📌 Commit 3d3a5ca has been approved by |
bors
added
S-waiting-on-bors
bors bot
added a commit
to intellij-rust/intellij-rust
that referenced
this pull request
Apr 6, 2021
7059: Update HashMap/HashSet pretty-printers to Rust 1.52 r=Undin a=ortem The corresponding PRs in rustc: rust-lang/rust#77566 rust-lang/rust#83920 Fixes #7045 changelog: Update LLDB/GDB pretty-printers to render `HashMap`/`HashSet` on Rust 1.52 or higher Co-authored-by: ortem <ortem00@gmail.com>
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#82963 (Move `SharedContext` to `context.rs`) - rust-lang#83829 (rustc_target: Rely on defaults more in target specs) - rust-lang#83895 (Add listing of lints (eg via `-W help`) to rustdoc) - rust-lang#83902 (Update LLVM to support more wasm simd ops) - rust-lang#83903 (Fix typo in TokenStream documentation) - rust-lang#83910 (Update cargo) - rust-lang#83920 (Fix HashMap/HashSet LLDB pretty-printer after hashbrown 0.11.0) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Undin
pushed a commit
to intellij-rust/intellij-rust
that referenced
this pull request
Apr 7, 2021
The corresponding PRs in rustc: rust-lang/rust#77566 rust-lang/rust#83920 (cherry picked from commit e78fbe5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pretty-printer was broken in #77566 after updating hashbrown to 0.11.0.
Note that the corresponding GDB pretty-printer was updated properly.
Fixes #83891