-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change librustdoc write!(.. \n) to writeln!(..); fix comment grammar #84852
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Isn't |
https://doc.rust-lang.org/std/macro.writeln.html #[macro_export]
#[stable(feature = "rust1", since = "1.0.0")]
#[allow_internal_unstable(format_args_nl)]
macro_rules! writeln {
($dst:expr $(,)?) => (
$crate::write!($dst, "\n")
);
($dst:expr, $($arg:tt)*) => (
$dst.write_fmt($crate::format_args_nl!($($arg)*))
);
} I think it's just calling \n? (I apologize if I'm referring to the wrong macro or missing something, not particularly familiar with macros). |
No that seems correct, thanks for the confirmation! (I was only reading the source code and not the docs... Well, now I know sometimes reading docs is better haha). |
r=me once CI pass |
Ah, thanks for double checking; I hadn't thought to look there! : ) |
@bors: r+ rollup |
📌 Commit 8db7973 has been approved by |
…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#84835 (Add link to Issue rust-lang#34202 in udp docs) - rust-lang#84852 (Change librustdoc write!(.. \n) to writeln!(..); fix comment grammar) - rust-lang#84854 (use double quotes and full path for E0761) - rust-lang#84856 (Correct stability of ErrorKind::OutOfMemory) - rust-lang#84858 (Fix stability attributes of byte-to-string specialization) - rust-lang#84860 (Link to MCP from target tier policy) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Howdy,
This PR does the following:
Best,
Mautamu