Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only pass --[no-]gc-sections if linker is GNU ld. #85274

Merged
merged 5 commits into from
May 19, 2021
Merged

Only pass --[no-]gc-sections if linker is GNU ld. #85274

merged 5 commits into from
May 19, 2021

Commits on May 13, 2021

  1. Only pass --[no-]gc-sections if linker is GNU ld. 

    LinkerFlavor::Gcc does not always mean GNU ld specifically. And in the
case of at least the solaris ld in illumos, that flag is unrecognized
and will cause the linking step to fail.
    @luqmana
    luqmana committed May 13, 2021
    Configuration menu
    Copy the full SHA
    3fe1d7f View commit details
    Browse the repository at this point in the history

Commits on May 16, 2021

  1. Windows mingw targets use gcc as the linker so the target spec should… 

    … also indicate linker_is_gnu.
    @luqmana
    luqmana committed May 16, 2021
    Configuration menu
    Copy the full SHA
    45225d2 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. Adjust linker_is_gnu branches for cases that don't work on windows.

    @luqmana
    luqmana committed May 17, 2021
    Configuration menu
    Copy the full SHA
    a862b1f View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. Undo unnecessary changes.

    @luqmana
    luqmana committed May 18, 2021
    Configuration menu
    Copy the full SHA
    e0d5872 View commit details
    Browse the repository at this point in the history

  2. Don't pass -pie to linker on windows targets.

    @luqmana
    luqmana committed May 18, 2021
    Configuration menu
    Copy the full SHA
    ac5fd90 View commit details
    Browse the repository at this point in the history