Miri fn ptr check: don't use conservative null check #94343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #94270 I used the wrong NULL check for function pointers:
memory.ptr_may_be_null
is conservative even on machines that support ptr-to-int casts, leading to false errors in Miri.This fixes that problem, and also replaces that foot-fun of a method with
scalar_may_be_null
which is never unnecessarily conservative.r? @oli-obk