Rollup of 4 pull requests #97624
Merged
Rollup of 4 pull requests #97624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Noah Lev <camelidcamel@gmail.com>
…rk, r=estebank suggest `?` when method is missing on `Result<T, _>` but found on `T` The wording needs help, I think. Fixes rust-lang#95729
…ailing-to-resolve-use-crate, r=estebank Suggest `extern crate foo` when failing to resolve `use foo` closes rust-lang#97095 r? ``@estebank``
…uillaumeGomez rustdoc: also index impl trait and raw pointers Revives rust-lang#92339
update Miri Fixes rust-lang#97563 Cc ``@rust-lang/miri`` r? ``@ghost``
rustbot
added
T-compiler
|
@bors r+ rollup=never p=4 |
|
📌 Commit 89e765f has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jun 1, 2022
Tested on commit rust-lang/rust@b5a2d27. Direct link to PR: <rust-lang/rust#97624> 🎉 miri on windows: test-fail → test-pass (cc @eddyb @oli-obk @RalfJung). 🎉 miri on linux: test-fail → test-pass (cc @eddyb @oli-obk @RalfJung).
|
Finished benchmarking commit (b5a2d27): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesThis benchmark run did not return any relevant results for this metric. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
?when method is missing onResult<T, _>but found onT#96271 (suggest?when method is missing onResult<T, _>but found onT)extern crate foowhen failing to resolveuse foo#97264 (Suggestextern crate foowhen failing to resolveuse foo)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup