Skip to content

Make the rustc-pull workflow run less often #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Feb 3, 2025

Recently, I made the rustc-pull workflow run every day, with the idea that it would create a "rolling" PR that would be merged from tiem to time. However, it is not clear when should such a PR be merged, and merging it every day creates unnecessary churn and a lot of useless merge commits.

This PR changes the cron workflow so that it runs twice a week (Monday and Thursday), to give us a faster notice when there are merge conflicts, but doesn't create a new PR every day. If there is a PR that is more than a week old, the workflow will notify us on Zulip.

@tshepang
Copy link
Member

tshepang commented Feb 4, 2025

where is the thursday part

@Kobzol
Copy link
Member Author

Kobzol commented Feb 4, 2025

Sorry, forgot to push the latest commit. Now it's there.

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu jieyouxu merged commit 4ff0d40 into rust-lang:master Feb 4, 2025
1 check passed
@Kobzol Kobzol deleted the pull-cron branch February 4, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants