Update links between ty-module and binders #2398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order might have been reversed at some point, leading to the two chapters talking about each other in the wrong order.
|
Just to make it clearer for review: at the moment, instantiating_binders comes first (chapter 48.1). It refers to param_ty_const_regions (chapter 50.2) indirectly via "As discussed in a previous chapter, RegionKind has two variants for representing generic parameters, ReLateParam and ReEarlyParam.". I searched in the docs and saw no other references to ReLateParam and ReEarlyParam, so I proposed this change. |
|
Possibly we should move the "the ty module" chapter before the binders chapter, but I'm not sure and regardless it seems like an improvement to make the wording be chapter order insensitive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order might have been reversed at some point, leading to the two chapters talking about each other in the wrong order.