Update the "Updating LLVM" documentation #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cuviper I've also updated README.md in rust-lang/llvm-project to point to this documentation about updating. |
cuviper
reviewed
Sep 20, 2019
src/codegen/updating-llvm.md
Outdated
| 5. Build your commit. Make sure you've committed the previous changes to ensure | ||
| 3. Build the new LLVM in the `rust` repository. To do this you'll want to update | ||
| the `src/llvm-project` repository to your branch and the revision you've | ||
| created. Make sure you've committed changes to `src/llvm-project` to ensure |
There was a problem hiding this comment.
We should make sure to update the branch name in .gitmodules too, as this enables easy git submodules update --remote src/llvm-project.
src/codegen/updating-llvm.md
Outdated
| 7. Send a Pull Request to rust-lang/llvm-project to the same branch as before | ||
| 7. Send a Pull Request to rust-lang/llvm-project to the same branch as before. | ||
| Be sure to reference the Rust and/or LLVM issue that you're fixing in the PR | ||
| description. | ||
| 8. Wait for the PR to be merged | ||
| 9. Send a PR to rust-lang/rust updating the `src/llvm-project` submodule with | ||
| your bugfix |
There was a problem hiding this comment.
This is another place to mention git submodule update --remote src/llvm-project, assuming the branch name in .gitmodules is current.
Make sure existing sections are up-to-date and then also add some words about the recent convention we developed for updating LLVM versions with respect to branch naming as well.
alexcrichton
force-pushed
the
moar-update
branch
from
dc0b26e to
5aa935f
Compare
|
Excellent points, updated! |
cuviper
approved these changes
Sep 20, 2019
mark-i-m
pushed a commit
to spastorino/rustc-dev-guide
that referenced
this pull request
Jan 2, 2020
Make sure existing sections are up-to-date and then also add some words about the recent convention we developed for updating LLVM versions with respect to branch naming as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure existing sections are up-to-date and then also add some words
about the recent convention we developed for updating LLVM versions with
respect to branch naming as well.