Skip to content

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Sep 20, 2025

This removes one half of the usage of the benchmark index. Now when loading the status page or computing the queue for deciding which requests to enqueue, we only load pending requests from the database, together with the information whether their parent is completed or not, and we no longer have to load all completed requests from the DB.

This leaves only one usage of the benchmark index, when determining whether to add master/release requests into the database.

@Kobzol Kobzol requested a review from Jamesbarford September 20, 2025 08:15
@Jamesbarford
Copy link
Contributor

This leaves only one usage of the benchmark index, when determining whether to add master/release requests into the database

Would one of the database conditions we've added catch this? Also if we need a Vec<_> to check something prior to inserting something into the database then we should be able to do that in a query? Perhaps not in this PR but it theoretically seems reasonable unless I've missed something.

With one exception; when starting the new system we need to temporarily have a manual check for the parent_sha and make it Null if it does not exist as it's own request.

@Kobzol Kobzol force-pushed the benchmark-index-in-memory branch from 49a1c4b to 962de49 Compare September 22, 2025 07:38
@Kobzol Kobzol requested a review from Jamesbarford September 22, 2025 07:46
Copy link
Contributor

@Jamesbarford Jamesbarford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kobzol Kobzol enabled auto-merge September 22, 2025 07:48
@Kobzol Kobzol merged commit b420aaf into rust-lang:master Sep 22, 2025
11 checks passed
@Kobzol Kobzol deleted the benchmark-index-in-memory branch September 22, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants