Skip to content

Show stderr when an eprintln profiler invocation fails #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
+9 −2
Merged

Show stderr when an eprintln profiler invocation fails #2274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions collector/src/bin/rustc-fake.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,11 +355,18 @@ fn main() {

"Eprintln" => {
let mut cmd = Command::new(tool);

let file_path = "eprintln";
cmd.args(args).stderr(std::process::Stdio::from(
std::fs::File::create("eprintln").unwrap(),
std::fs::File::create(file_path).unwrap(),
));

run_with_determinism_env(cmd);
determinism_env(&mut cmd);
let status = cmd.status().expect("failed to spawn");
if !status.success() {
let stderr = std::fs::read_to_string(file_path).unwrap_or_default();
panic!("command did not complete successfully: {cmd:?}\nstderr:\n{stderr}");
}
}

"LlvmLines" => {
Expand Down
Loading