Display "cache-state" names consistently #758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means they get the same color across different benchmarks and they appear in the same order. Unfortunately, we lose the tooltip border color, but this isn't too important, and could be fixed later.
Mark-Simulacrum
added a commit
that referenced
this pull request
Sep 14, 2020
…ixes Fix some fallout from #758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means they get the same color across different benchmarks and they appear in the same order. Unfortunately, we lose the tooltip border color, but this isn't too important and could be fixed later.
This has been a minor annoyance for me when looking at perf graphs, since what looks like a regression on
fullbuilds based on its color can sometimes be anincr-unchangedregression, which is less serious.