Sort archs and make the generate predictable #153
Conversation
src/intrinsic/archs.rs
Outdated
| "llvm.objectsize.v8i16.p0i8" => "__builtin_object_size", | ||
| "llvm.stackrestore" => "__builtin_stack_restore", | ||
| "llvm.stacksave" => "__builtin_stack_save", | ||
| "llvm.trap" => "__builtin_trap", |
There was a problem hiding this comment.
I don't think any of these are used by stdarch or any other part of the standard library.
There was a problem hiding this comment.
llvm.trap is in the rustc code.
There was a problem hiding this comment.
It is only used inside cg_llvm as implementation for the abort builder function. cg_gcc directly calls the abort builtin function there.
There was a problem hiding this comment.
llvm.debugtrap is needed by the breakpoint intrinsic.
There was a problem hiding this comment.
Wouldn't the implementation of said intrinsic directly call the right gcc builtin?
|
It seems like these functions shouldn't be added then. Is it fine to still have the sorting predictable? |
Indeed. We can add them later if needed. Yes, please, go ahead for the sorting. |
GuillaumeGomez
force-pushed
the
general-intrinsics
branch
from
8a138f2 to
035ac03
Compare
GuillaumeGomez
changed the title
|
Done! |
Sorry for the noise, I didn't pay attention to the order of the archs. It's now predictable so this shouldn't happen again.
This PR adds the "general" intrinsics (not bound to any arch).
Last part of #151.