Avoid using Symbol::intern #4268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| match mac.path.segments.first() { | ||
| Some(first_segment) => { | ||
| if first_segment.ident.name != Symbol::intern("cfg_if") { | ||
| match mac.path.segments.last() { |
There was a problem hiding this comment.
I assume the first to last change will still allow support for cfg_if::cfg_if! and cfg_if! correct?
There was a problem hiding this comment.
Yes, I added to support self-importing like pub use cfg_if::cfg_if; in the root file and using cfg_if! as crate::cfg_if!.
There was a problem hiding this comment.
Even better! Changes LGTM, CI failures seem to just be due to the configuration snippet tests needing lazy_static
There was a problem hiding this comment.
Thanks for the catch! Fixed in 5c7cb94.
topecongiro
force-pushed
the
cfg-if-symbol
branch
from
c36a011 to
5c7cb94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4266.