Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust span derivation for const generics #5936

Merged
merged 1 commit into from Oct 8, 2023
Merged

adjust span derivation for const generics #5936

merged 1 commit into from Oct 8, 2023
+18 −1

Conversation

calebcartwright
Copy link
Member

@calebcartwright calebcartwright commented Oct 8, 2023 •
edited

Fixes #5935

r? @ytmimi if you have time, otherwise I may just pull this in for the release later given the trivial nature of the change

@calebcartwright calebcartwright added the release-notes Needs an associated changelog entry label Oct 8, 2023
ytmimi
ytmimi approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, very trivial change. Looks good to me!

@ytmimi ytmimi merged commit 2707103 into rust-lang:master Oct 8, 2023
27 checks passed
@krh
Copy link

krh commented Oct 9, 2023

Thanks everybody!

@calebcartwright calebcartwright deleted the issue-5935 branch October 11, 2023 05:12
@ytmimi ytmimi removed the release-notes Needs an associated changelog entry label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytmimi ytmimi ytmimi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rustfmt generates invalid code with for const int generic with default argument
4 participants
@calebcartwright @krh @ytmimi @rustbot