Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests Pass no matter what if the code compiles #149

Closed
ZSteinberger opened this issue Apr 29, 2019 · 2 comments
Closed

Tests Pass no matter what if the code compiles #149

ZSteinberger opened this issue Apr 29, 2019 · 2 comments

Comments

@ZSteinberger
Copy link

Ran through the rustlings tutorial and had to remove the --nocapture flag in exrecise.rs in order for the tests to properly run.
Command:
rustlings verify
rustlings run
Expected Results:
If an assert fails there should be some output stating why.
Actual Results:
A success message is displayed stating you passed the test. (only if the code can compile)
@stevenzyang
Copy link

+1

@tyilo tyilo mentioned this issue May 7, 2019
Closed
@komaeda komaeda closed this as completed in 35c3d0b May 7, 2019
@komaeda
Copy link
Contributor

komaeda commented May 7, 2019

Released 1.2.2

pedantic79 pushed a commit to pedantic79/rustlings that referenced this issue Apr 11, 2020
@komaeda
Revert --nocapture flag
c5fdd08 
This closes rust-lang#149 and rust-lang#152
ppp3 pushed a commit to ppp3/rustlings that referenced this issue May 23, 2022
Revert --nocapture flag
d0baea7 
This closes rust-lang#149 and rust-lang#152
dmoore04 pushed a commit to dmoore04/rustlings that referenced this issue Sep 11, 2022
@komaeda
Revert --nocapture flag
d0c16d5 
This closes rust-lang#149 and rust-lang#152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stevenzyang @ZSteinberger @komaeda