Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apple visionOS support #503

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

QuentinPerez
Copy link
Contributor

Motivation

Add the support of Apple VisionOS 121419

Solution

Add target_os = "visionos"

@Thomasdezeeuw
Copy link
Collaborator

Can you add the target to the CI and local dev?

  • target: ["aarch64-apple-ios", "aarch64-linux-android", "x86_64-apple-darwin", "x86_64-unknown-fuchsia", "x86_64-pc-windows-msvc", "x86_64-pc-solaris", "x86_64-unknown-freebsd", "x86_64-unknown-illumos", "x86_64-unknown-linux-gnu", "x86_64-unknown-linux-musl", "x86_64-unknown-netbsd", "x86_64-unknown-redox", "armv7-linux-androideabi", "i686-linux-android"]
  • TARGETS ?= "aarch64-apple-ios" "aarch64-linux-android" "x86_64-apple-darwin" "x86_64-unknown-fuchsia" "x86_64-pc-windows-msvc" "x86_64-pc-solaris" "x86_64-unknown-freebsd" "x86_64-unknown-illumos" "x86_64-unknown-linux-gnu" "x86_64-unknown-linux-musl" "x86_64-unknown-netbsd" "x86_64-unknown-redox" "armv7-linux-androideabi" "i686-linux-android"

@QuentinPerez
Copy link
Contributor Author

@Thomasdezeeuw do you mind if I use target_env = "apple" ? Instead of changing this every time Apple releases a new device

@Thomasdezeeuw
Copy link
Collaborator

@Thomasdezeeuw do you mind if I use target_env = "apple" ? Instead of changing this every time Apple releases a new device

I think that is deprecated. Or was that target_family?

@Thomasdezeeuw
Copy link
Collaborator

@Thomasdezeeuw do you mind if I use target_env = "apple" ? Instead of changing this every time Apple releases a new device

I think that is deprecated. Or was that target_family?

target_vendor is being deprecated: rust-lang/rust#100343. For now let's stick with explicit OS, I don't really want to deal with all the target stuff a the moment, at least we know that this works.

@madsmtm
Copy link

madsmtm commented May 21, 2024

target_vendor = "apple" will not be deprecated unless an alternative appears, see rust-lang/rust#100343 (comment), so I think you can safely use that

@Thomasdezeeuw
Copy link
Collaborator

Thomasdezeeuw commented May 21, 2024

target_vendor = "apple" will not be deprecated unless an alternative appears, see rust-lang/rust#100343 (comment), so I think you can safely use that

Let's still go with target_os for now, we'll let the dust settle on vendor vs. family vs. os, etc. first.

.cirrus.yml Outdated
@@ -1,5 +1,5 @@
freebsd_instance:
image_family: freebsd-13-2
image_family: freebsd-13-3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it due to the not found error on freebsd-13-2

@QuentinPerez
Copy link
Contributor Author

@Thomasdezeeuw do you think that we can merge ?

@Thomasdezeeuw
Copy link
Collaborator

I want to merge #520 first, then it's a lot easier to add new targets.

@Darksonn
Copy link
Collaborator

#520 has been merged now.

@Thomasdezeeuw Thomasdezeeuw merged commit 3a93893 into rust-lang:master Jul 2, 2024
41 of 42 checks passed
@Thomasdezeeuw
Copy link
Collaborator

Thanks @QuentinPerez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants