Skip to content

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Mar 19, 2024

This is an attempt to try to capture what I think should be guidelines for merging and reviewing, based on some of the discussion from the 2024-03-14 meeting.

I placed this within an outline of other team documentation I think we should have to give context to where it fits in. I expect to have these other sections filled in the future.

This explicitly does not cover how "final approval" is given by teams like the lang team, which I think will need a separate process.

Closes #25

Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ironically, is a policy change PR that should be approved by the t-spec team without blocking changes 😊

@JoelMarcey JoelMarcey requested review from pnkfelix and m-ou-se March 20, 2024 01:03
@JoelMarcey JoelMarcey added the C-meta Category: Meta discussion about the repository itself. We should refine each use of the policy label label Mar 20, 2024
@JoelMarcey
Copy link
Contributor

@rfcbot poll "t-spec approve"

@JoelMarcey
Copy link
Contributor

JoelMarcey commented Apr 3, 2024

Maybe rfcbot doesn't fully work yet.

I was trying to get the t-spec team checkboxes going.

@rfcbot
Copy link

rfcbot commented Apr 3, 2024

Team member @JoelMarcey has asked teams: , for consensus on:

"t-spec approve"

@ehuss ehuss added the T-spec Team: Specification label Apr 3, 2024
@ehuss
Copy link
Contributor Author

ehuss commented Apr 3, 2024

@JoelMarcey You have to make sure the T-spec label is applied, otherwise rfcbot doesn't know which team to ping. Also, it can take ~10 minutes for it to respond since it is currently polling (once infra sets up the webhook, it should be immediate).

@rfcbot poll "t-spec approve"

@rfcbot
Copy link

rfcbot commented Apr 3, 2024

Team member @ehuss has asked teams: T-spec, for consensus on:

"t-spec approve"

@ehuss
Copy link
Contributor Author

ehuss commented Apr 3, 2024

🤷 Bot now seems confused. Here are checkboxes:

@m-ou-se m-ou-se merged commit 1957b8a into rust-lang:main Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-meta Category: Meta discussion about the repository itself. We should refine each use of the policy label T-spec Team: Specification
Development

Successfully merging this pull request may close these issues.

Review policy
5 participants