Skip to content

wasm: use {read, write}_unaligned methods #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025

Conversation

folkertdev
Copy link
Contributor

This is shorter and more directly expresses what we want here.

(obviously blocked on getting CI working again)

@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2025

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor

tgross35 commented Aug 14, 2025

This was added in cf1dbfa when read_unaligned definitely existed, @alexcrichton any reason not to do this?

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that was just my own ignorance for not using {read,write}_unaligned, agreed this is much better!

@folkertdev folkertdev force-pushed the wasm-read-unaligned branch from 8163a42 to a195a24 Compare August 20, 2025 20:11
@Amanieu Amanieu added this pull request to the merge queue Aug 20, 2025
Merged via the queue into rust-lang:master with commit cd8bad8 Aug 20, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants