s390x: use the new u128::funnel_shl
#1913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayantn
reviewed
Sep 6, 2025
crates/core_arch/src/s390x/vector.rs
Outdated
| unsafe fn vec_sld<const C: u32>(self, b: Self) -> Self { | ||
| static_assert_uimm_bits!(C, 4); | ||
| transmute(funnel_shl_u128(transmute(self), transmute(b), const { C as u128 * 8 })) | ||
| transmute(u128::funnel_shl(transmute(self), transmute(b), const { C * 8 })) |
There was a problem hiding this comment.
Are these const blocks needed here? Is LLVM not propagating const status?
There was a problem hiding this comment.
that's a bit of an artifact of using the s390x intrinsic originally, where you had to manually make sure that you passed a const or else llvm would panic. It looks like they can be removed now, everything still works without them (as expected, really).
folkertdev
force-pushed
the
s390x-vector-funnel-shift
branch
from
33b732a to
d8c08f7
Compare
folkertdev
force-pushed
the
s390x-vector-funnel-shift
branch
from
d8c08f7 to
9985832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @sayantn
btw the tracking issue mentions
wrapping_funnel_{shl,shr}but those are not actually implemented (yet?).